From: "Rob Herring (Arm)" <robh@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-mips@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ansuelsmth@gmail.com,
Conor Dooley <conor+dt@kernel.org>,
Stanislaw Gruszka <stf_xl@wp.pl>,
linux-mediatek@lists.infradead.org,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
yangshiji66@qq.com
Subject: Re: [PATCH 5/6] dt-bindings: net: wireless: rt2800: add
Date: Sun, 06 Jul 2025 17:29:47 -0500 [thread overview]
Message-ID: <175184098772.672740.2328928098872646704.robh@kernel.org> (raw)
In-Reply-To: <20250706214111.45687-6-rosenp@gmail.com>
On Sun, 06 Jul 2025 14:41:10 -0700, Rosen Penev wrote:
> Add device-tree bindings for the RT2800 SOC wifi device found in older
> Ralink/Mediatek devices.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> .../bindings/net/wireless/ralink,rt2800.yaml | 49 +++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml:43:5: [warning] wrong indentation: expected 2 but found 4 (indentation)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml: ignoring, error in schema: examples
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml: examples: 'wifi@110180000 { compatible = "ralink,rt2880-wifi"; reg = <0x10180000 0x40000>; clocks = <&sysc 16>; interrupt-parent = <&cpuintc>; interrupts = <6>; };' is not of type 'array'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml: examples: 'wifi@110180000 { compatible = "ralink,rt2880-wifi"; reg = <0x10180000 0x40000>; clocks = <&sysc 16>; interrupt-parent = <&cpuintc>; interrupts = <6>; };' is not of type 'array'
from schema $id: http://devicetree.org/meta-schemas/base.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml: properties:interrupt-parent: False schema does not allow {'maxItems': 1}
from schema $id: http://devicetree.org/meta-schemas/interrupts.yaml#
Error: Documentation/devicetree/bindings/net/wireless/ralink,rt2800.example.dts:19.5-6 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/net/wireless/ralink,rt2800.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1525: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250706214111.45687-6-rosenp@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-07-06 22:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-06 21:41 [PATCH 0/6] wifi: rt2x00: add OF bindings + cleanup Rosen Penev
2025-07-06 21:41 ` [PATCH 1/6] wifi: rt2x00: fix compilation Rosen Penev
2025-07-08 10:00 ` Sergio Paracuellos
2025-07-06 21:41 ` [PATCH 2/6] wifi: rt2x00: remove mod_name from platform_driver Rosen Penev
2025-07-08 10:01 ` Sergio Paracuellos
2025-07-06 21:41 ` [PATCH 3/6] wifi: rt2800soc: allow loading from OF Rosen Penev
2025-07-08 10:03 ` Sergio Paracuellos
2025-07-06 21:41 ` [PATCH 4/6] wifi: rt2x00: soc: move and modernize probe Rosen Penev
2025-07-08 10:07 ` Sergio Paracuellos
2025-07-06 21:41 ` [PATCH 5/6] dt-bindings: net: wireless: rt2800: add Rosen Penev
2025-07-06 22:29 ` Rob Herring (Arm) [this message]
2025-07-06 23:51 ` Rosen Penev
2025-07-06 21:41 ` [PATCH 6/6] MIPS: dts: ralink: mt7628a: add wifi binding Rosen Penev
2025-07-08 1:19 ` Daniel Golle
2025-07-08 1:36 ` Rosen Penev
2025-07-07 9:01 ` [PATCH 0/6] wifi: rt2x00: add OF bindings + cleanup Johannes Berg
2025-07-07 17:41 ` Rosen Penev
2025-07-07 18:36 ` Johannes Berg
2025-07-07 22:55 ` Rosen Penev
2025-07-08 6:51 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175184098772.672740.2328928098872646704.robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rosenp@gmail.com \
--cc=stf_xl@wp.pl \
--cc=tsbogend@alpha.franken.de \
--cc=yangshiji66@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®