From: Daniel Golle <daniel@makrotopia.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
yangshiji66@qq.com, ansuelsmth@gmail.com,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Stanislaw Gruszka <stf_xl@wp.pl>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:MIPS" <linux-mips@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 6/6] MIPS: dts: ralink: mt7628a: add wifi binding
Date: Tue, 8 Jul 2025 02:19:11 +0100 [thread overview]
Message-ID: <aGxyD3mtzdNZPPnx@makrotopia.org> (raw)
In-Reply-To: <20250706214111.45687-7-rosenp@gmail.com>
On Sun, Jul 06, 2025 at 02:41:11PM -0700, Rosen Penev wrote:
> MT7620A devices all contain a wifi device as part of the SOC. Add it
> here to get it working.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> arch/mips/boot/dts/ralink/mt7620a.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
The commit title
MIPS: dts: ralink: mt7628a: add wifi binding
seems wrong as the commit (correctly) touches mt7620a.dtsi and not
mt7628a.dtsi (which would be wrong as the WiFi part of MT7628A is
already supported by the mt76 driver and part of the device tree).
Also the word 'binding' seems wrong in this context, you are adding
a node to the device tree, not to the device tree bindings.
I'd hence suggest to change the commit title to
MIPS: dts: ralink: mt7620a: add wifi
next prev parent reply other threads:[~2025-07-08 1:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-06 21:41 [PATCH 0/6] wifi: rt2x00: add OF bindings + cleanup Rosen Penev
2025-07-06 21:41 ` [PATCH 1/6] wifi: rt2x00: fix compilation Rosen Penev
2025-07-08 10:00 ` Sergio Paracuellos
2025-07-06 21:41 ` [PATCH 2/6] wifi: rt2x00: remove mod_name from platform_driver Rosen Penev
2025-07-08 10:01 ` Sergio Paracuellos
2025-07-06 21:41 ` [PATCH 3/6] wifi: rt2800soc: allow loading from OF Rosen Penev
2025-07-08 10:03 ` Sergio Paracuellos
2025-07-06 21:41 ` [PATCH 4/6] wifi: rt2x00: soc: move and modernize probe Rosen Penev
2025-07-08 10:07 ` Sergio Paracuellos
2025-07-06 21:41 ` [PATCH 5/6] dt-bindings: net: wireless: rt2800: add Rosen Penev
2025-07-06 22:29 ` Rob Herring (Arm)
2025-07-06 23:51 ` Rosen Penev
2025-07-06 21:41 ` [PATCH 6/6] MIPS: dts: ralink: mt7628a: add wifi binding Rosen Penev
2025-07-08 1:19 ` Daniel Golle [this message]
2025-07-08 1:36 ` Rosen Penev
2025-07-07 9:01 ` [PATCH 0/6] wifi: rt2x00: add OF bindings + cleanup Johannes Berg
2025-07-07 17:41 ` Rosen Penev
2025-07-07 18:36 ` Johannes Berg
2025-07-07 22:55 ` Rosen Penev
2025-07-08 6:51 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGxyD3mtzdNZPPnx@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
--cc=stf_xl@wp.pl \
--cc=tsbogend@alpha.franken.de \
--cc=yangshiji66@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®