[PATCH 1/1] ASoC: codec: tlv320aic32x4: Fix reset GPIO check

[PATCH 1/1] ASoC: codec: tlv320aic32x4: Fix reset GPIO check

[Alexander Stein]

rstn_gpio being a GPIO descriptor the check is wrong (inverted) for
releasing the reset of the codec.

Fixes: 790d5f8ee6f2 ("ASoC: codec: tlv320aic32x4: Convert to GPIO descriptors")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
AFAICT this bug was introduced on v2 of the series which changed the
validity check

 sound/soc/codecs/tlv320aic32x4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c
index 3b89980e9bcf2..7399080f8580c 100644
--- a/sound/soc/codecs/tlv320aic32x4.c
+++ b/sound/soc/codecs/tlv320aic32x4.c
@@ -1388,7 +1388,7 @@ int aic32x4_probe(struct device *dev, struct regmap *regmap,
 		return ret;
 	}
 
-	if (!aic32x4->rstn_gpio) {
+	if (aic32x4->rstn_gpio) {
 		ndelay(10);
 		/* deassert reset */
 		gpiod_set_value_cansleep(aic32x4->rstn_gpio, 0);
-- 
2.43.0

RE: [PATCH 1/1] ASoC: codec: tlv320aic32x4: Fix reset GPIO check

[Peng Fan]

> Subject: [PATCH 1/1] ASoC: codec: tlv320aic32x4: Fix reset GPIO check
> 
> rstn_gpio being a GPIO descriptor the check is wrong (inverted) for
> releasing the reset of the codec.
> 
> Fixes: 790d5f8ee6f2 ("ASoC: codec: tlv320aic32x4: Convert to GPIO
> descriptors")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> AFAICT this bug was introduced on v2 of the series which changed the
> validity check
> 
>  sound/soc/codecs/tlv320aic32x4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/tlv320aic32x4.c
> b/sound/soc/codecs/tlv320aic32x4.c
> index 3b89980e9bcf2..7399080f8580c 100644
> --- a/sound/soc/codecs/tlv320aic32x4.c
> +++ b/sound/soc/codecs/tlv320aic32x4.c
> @@ -1388,7 +1388,7 @@ int aic32x4_probe(struct device *dev, struct
> regmap *regmap,
>  		return ret;
>  	}
> 
> -	if (!aic32x4->rstn_gpio) {
> +	if (aic32x4->rstn_gpio) {

Oops! Thanks for spotting this.

Reviewed-by: Peng Fan <peng.fan@nxp.com>

Re: [PATCH 1/1] ASoC: codec: tlv320aic32x4: Fix reset GPIO check

[Mark Brown]

On Wed, 16 Jul 2025 08:57:07 +0200, Alexander Stein wrote:
> rstn_gpio being a GPIO descriptor the check is wrong (inverted) for
> releasing the reset of the codec.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: codec: tlv320aic32x4: Fix reset GPIO check
      commit: 8778837f0a5b7c1bc5dbf0cccd7619fec6981588

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark