* [PATCH] arm64: dts: qcom: sa8775p: rename bus clock to follow the bindings
@ 2025-06-02 7:23 Dmitry Baryshkov
2025-06-14 20:10 ` Konrad Dybcio
2025-07-16 19:40 ` Bjorn Andersson
0 siblings, 2 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2025-06-02 7:23 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov, Mahadevan
Cc: linux-arm-msm, devicetree, linux-kernel
DT bindings for the DPU SA8775P declare the first clock to be "nrt_bus",
not just "bus". Fix the DT file accordingly.
Fixes: 2f39d2d46c73 ("arm64: dts: qcom: sa8775p: add display dt nodes for MDSS0 and DPU")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 45f536633f6449e6ce6bb0109b5446968921f684..7eac6919b2992a3512df1e042af22d0cbad04853 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -4122,7 +4122,7 @@ mdss0_mdp: display-controller@ae01000 {
<&dispcc0 MDSS_DISP_CC_MDSS_MDP_LUT_CLK>,
<&dispcc0 MDSS_DISP_CC_MDSS_MDP_CLK>,
<&dispcc0 MDSS_DISP_CC_MDSS_VSYNC_CLK>;
- clock-names = "bus",
+ clock-names = "nrt_bus",
"iface",
"lut",
"core",
---
base-commit: 460178e842c7a1e48a06df684c66eb5fd630bcf7
change-id: 20250602-sa8775p-fix-dts-2eb4013c4dbe
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sa8775p: rename bus clock to follow the bindings
2025-06-02 7:23 [PATCH] arm64: dts: qcom: sa8775p: rename bus clock to follow the bindings Dmitry Baryshkov
@ 2025-06-14 20:10 ` Konrad Dybcio
2025-06-15 12:34 ` Dmitry Baryshkov
2025-07-16 19:40 ` Bjorn Andersson
1 sibling, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2025-06-14 20:10 UTC (permalink / raw)
To: Dmitry Baryshkov, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Dmitry Baryshkov, Mahadevan
Cc: linux-arm-msm, devicetree, linux-kernel
On 6/2/25 9:23 AM, Dmitry Baryshkov wrote:
> DT bindings for the DPU SA8775P declare the first clock to be "nrt_bus",
> not just "bus". Fix the DT file accordingly.
>
> Fixes: 2f39d2d46c73 ("arm64: dts: qcom: sa8775p: add display dt nodes for MDSS0 and DPU")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 45f536633f6449e6ce6bb0109b5446968921f684..7eac6919b2992a3512df1e042af22d0cbad04853 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -4122,7 +4122,7 @@ mdss0_mdp: display-controller@ae01000 {
> <&dispcc0 MDSS_DISP_CC_MDSS_MDP_LUT_CLK>,
> <&dispcc0 MDSS_DISP_CC_MDSS_MDP_CLK>,
> <&dispcc0 MDSS_DISP_CC_MDSS_VSYNC_CLK>;
> - clock-names = "bus",
> + clock-names = "nrt_bus",
Is it the "nrt" clock though, and not "rt"?
There used to be a split for non-/real-time use cases, but
I have little idea about the specifics.
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sa8775p: rename bus clock to follow the bindings
2025-06-14 20:10 ` Konrad Dybcio
@ 2025-06-15 12:34 ` Dmitry Baryshkov
2025-06-21 11:05 ` Konrad Dybcio
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Baryshkov @ 2025-06-15 12:34 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov, Mahadevan, linux-arm-msm,
devicetree, linux-kernel
On Sat, Jun 14, 2025 at 10:10:59PM +0200, Konrad Dybcio wrote:
> On 6/2/25 9:23 AM, Dmitry Baryshkov wrote:
> > DT bindings for the DPU SA8775P declare the first clock to be "nrt_bus",
> > not just "bus". Fix the DT file accordingly.
> >
> > Fixes: 2f39d2d46c73 ("arm64: dts: qcom: sa8775p: add display dt nodes for MDSS0 and DPU")
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > ---
> > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> > index 45f536633f6449e6ce6bb0109b5446968921f684..7eac6919b2992a3512df1e042af22d0cbad04853 100644
> > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> > @@ -4122,7 +4122,7 @@ mdss0_mdp: display-controller@ae01000 {
> > <&dispcc0 MDSS_DISP_CC_MDSS_MDP_LUT_CLK>,
> > <&dispcc0 MDSS_DISP_CC_MDSS_MDP_CLK>,
> > <&dispcc0 MDSS_DISP_CC_MDSS_VSYNC_CLK>;
> > - clock-names = "bus",
> > + clock-names = "nrt_bus",
>
> Is it the "nrt" clock though, and not "rt"?
>
> There used to be a split for non-/real-time use cases, but
> I have little idea about the specifics.
I think this matches the SM8550 / SM8650. SM8550 provides a good
example, because it lists both "bus" and "nrt_bus" clocks:
clocks = <&gcc GCC_DISP_AHB_CLK>,
<&gcc GCC_DISP_HF_AXI_CLK>,
[...]
clock-names = "bus",
"nrt_bus",
So, I think, let's fix the clock name here to follow the the schema and
other pltforms.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sa8775p: rename bus clock to follow the bindings
2025-06-15 12:34 ` Dmitry Baryshkov
@ 2025-06-21 11:05 ` Konrad Dybcio
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2025-06-21 11:05 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov, Mahadevan, linux-arm-msm,
devicetree, linux-kernel
On 6/15/25 2:34 PM, Dmitry Baryshkov wrote:
> On Sat, Jun 14, 2025 at 10:10:59PM +0200, Konrad Dybcio wrote:
>> On 6/2/25 9:23 AM, Dmitry Baryshkov wrote:
>>> DT bindings for the DPU SA8775P declare the first clock to be "nrt_bus",
>>> not just "bus". Fix the DT file accordingly.
>>>
>>> Fixes: 2f39d2d46c73 ("arm64: dts: qcom: sa8775p: add display dt nodes for MDSS0 and DPU")
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>>> index 45f536633f6449e6ce6bb0109b5446968921f684..7eac6919b2992a3512df1e042af22d0cbad04853 100644
>>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>>> @@ -4122,7 +4122,7 @@ mdss0_mdp: display-controller@ae01000 {
>>> <&dispcc0 MDSS_DISP_CC_MDSS_MDP_LUT_CLK>,
>>> <&dispcc0 MDSS_DISP_CC_MDSS_MDP_CLK>,
>>> <&dispcc0 MDSS_DISP_CC_MDSS_VSYNC_CLK>;
>>> - clock-names = "bus",
>>> + clock-names = "nrt_bus",
>>
>> Is it the "nrt" clock though, and not "rt"?
>>
>> There used to be a split for non-/real-time use cases, but
>> I have little idea about the specifics.
>
> I think this matches the SM8550 / SM8650. SM8550 provides a good
> example, because it lists both "bus" and "nrt_bus" clocks:
>
> clocks = <&gcc GCC_DISP_AHB_CLK>,
> <&gcc GCC_DISP_HF_AXI_CLK>,
> [...]
> clock-names = "bus",
> "nrt_bus",
>
> So, I think, let's fix the clock name here to follow the the schema and
> other pltforms.
if we don't know any better, let's just make the checker happy
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sa8775p: rename bus clock to follow the bindings
2025-06-02 7:23 [PATCH] arm64: dts: qcom: sa8775p: rename bus clock to follow the bindings Dmitry Baryshkov
2025-06-14 20:10 ` Konrad Dybcio
@ 2025-07-16 19:40 ` Bjorn Andersson
1 sibling, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2025-07-16 19:40 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Dmitry Baryshkov, Mahadevan, Dmitry Baryshkov
Cc: linux-arm-msm, devicetree, linux-kernel
On Mon, 02 Jun 2025 10:23:35 +0300, Dmitry Baryshkov wrote:
> DT bindings for the DPU SA8775P declare the first clock to be "nrt_bus",
> not just "bus". Fix the DT file accordingly.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sa8775p: rename bus clock to follow the bindings
commit: 84742ace114f881e92663f02ff8c6d65f3b06e27
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-07-16 19:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-02 7:23 [PATCH] arm64: dts: qcom: sa8775p: rename bus clock to follow the bindings Dmitry Baryshkov
2025-06-14 20:10 ` Konrad Dybcio
2025-06-15 12:34 ` Dmitry Baryshkov
2025-06-21 11:05 ` Konrad Dybcio
2025-07-16 19:40 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®