From: "tip-bot2 for Thomas Weißschuh" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: linux@weissschuh.net, Mark Brown <broonie@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: locking/core] spi: spi-nxp-fspi: Check return value of devm_mutex_init()
Date: Sat, 19 Jul 2025 17:40:17 -0000 [thread overview]
Message-ID: <175294681741.1420.3193151064662689491.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250617-must_check-devm_mutex_init-v7-1-d9e449f4d224@weissschuh.net>
The following commit has been merged into the locking/core branch of tip:
Commit-ID: d24a54e032021cf381af3c3cf119cc5cf6b3c1be
Gitweb: https://git.kernel.org/tip/d24a54e032021cf381af3c3cf119cc5cf6b3c1be
Author: Thomas Weißschuh <linux@weissschuh.net>
AuthorDate: Tue, 17 Jun 2025 19:08:12 +02:00
Committer: Boqun Feng <boqun.feng@gmail.com>
CommitterDate: Fri, 11 Jul 2025 15:02:07 -07:00
spi: spi-nxp-fspi: Check return value of devm_mutex_init()
devm_mutex_init() can fail. With CONFIG_DEBUG_MUTEXES=y the mutex will
be marked as unusable and trigger errors on usage.
Add the missed check.
Fixes: 48900813abd2 ("spi: spi-nxp-fspi: remove the goto in probe")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Reviewed-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20250617-must_check-devm_mutex_init-v7-1-d9e449f4d224@weissschuh.net
---
drivers/spi/spi-nxp-fspi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index e63c77e..f3d5765 100644
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -1273,7 +1273,9 @@ static int nxp_fspi_probe(struct platform_device *pdev)
if (ret)
return dev_err_probe(dev, ret, "Failed to request irq\n");
- devm_mutex_init(dev, &f->lock);
+ ret = devm_mutex_init(dev, &f->lock);
+ if (ret)
+ return dev_err_probe(dev, ret, "Failed to initialize lock\n");
ctlr->bus_num = -1;
ctlr->num_chipselect = NXP_FSPI_MAX_CHIPSELECT;
next prev parent reply other threads:[~2025-07-19 17:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 17:08 [PATCH v7 0/3] locking/mutex: Mark devm_mutex_init() as __must_check Thomas Weißschuh
2025-06-17 17:08 ` [PATCH v7 1/3] spi: spi-nxp-fspi: check return value of devm_mutex_init() Thomas Weißschuh
2025-06-17 19:02 ` Mark Brown
2025-07-19 17:40 ` tip-bot2 for Thomas Weißschuh [this message]
2025-06-17 17:08 ` [PATCH v7 2/3] leds: lp8860: Check " Thomas Weißschuh
2025-06-19 12:34 ` (subset) " Lee Jones
2025-06-19 15:34 ` Thomas Weißschuh
2025-06-25 9:04 ` Lee Jones
2025-06-26 10:54 ` Thomas Weißschuh
2025-06-27 12:58 ` Lee Jones
2025-07-19 17:40 ` [tip: locking/core] " tip-bot2 for Thomas Weißschuh
2025-06-17 17:08 ` [PATCH v7 3/3] locking/mutex: Mark devm_mutex_init() as __must_check Thomas Weißschuh
2025-06-17 17:32 ` Boqun Feng
2025-07-19 17:40 ` [tip: locking/core] " tip-bot2 for Thomas Weißschuh
2025-07-11 22:12 ` [PATCH v7 0/3] " Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175294681741.1420.3193151064662689491.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®