From: Lee Jones <lee@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk>,
Will Deacon <will@kernel.org>, Han Xu <han.xu@nxp.com>,
Haibo Chen <haibo.chen@nxp.com>,
Yogesh Gaur <yogeshgaur.83@gmail.com>,
Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@kernel.org>,
Andrew Davis <afd@ti.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-spi@vger.kernel.org, imx@lists.linux.dev,
linux-leds@vger.kernel.org
Subject: Re: (subset) [PATCH v7 2/3] leds: lp8860: Check return value of devm_mutex_init()
Date: Wed, 25 Jun 2025 10:04:39 +0100 [thread overview]
Message-ID: <20250625090439.GQ795775@google.com> (raw)
In-Reply-To: <f1cc8959-d420-4ba3-922f-ed7c6f054f22@t-8ch.de>
On Thu, 19 Jun 2025, Thomas Weißschuh wrote:
> Hi Lee,
>
> On 2025-06-19 13:34:56+0100, Lee Jones wrote:
> > On Tue, 17 Jun 2025 19:08:13 +0200, Thomas Weißschuh wrote:
> > > devm_mutex_init() can fail. With CONFIG_DEBUG_MUTEXES=y the mutex will be
> > > marked as unusable and trigger errors on usage.
> > >
> > > Add the missed check.
> >
> > Applied, thanks!
> >
> > [2/3] leds: lp8860: Check return value of devm_mutex_init()
> > commit: 426e0c8e8eed26b67bbbd138483bb5973724adae
>
> Thanks, but (as mentioned in the cover letter) these patches should go
> together through the mutex/locking tree.
> Could you drop it on your side and give an Ack instead?
There has to be good reasons to do this.
I didn't see any dependents or dependencies in this patch.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-06-25 9:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 17:08 [PATCH v7 0/3] locking/mutex: Mark devm_mutex_init() as __must_check Thomas Weißschuh
2025-06-17 17:08 ` [PATCH v7 1/3] spi: spi-nxp-fspi: check return value of devm_mutex_init() Thomas Weißschuh
2025-06-17 19:02 ` Mark Brown
2025-07-19 17:40 ` [tip: locking/core] spi: spi-nxp-fspi: Check " tip-bot2 for Thomas Weißschuh
2025-06-17 17:08 ` [PATCH v7 2/3] leds: lp8860: " Thomas Weißschuh
2025-06-19 12:34 ` (subset) " Lee Jones
2025-06-19 15:34 ` Thomas Weißschuh
2025-06-25 9:04 ` Lee Jones [this message]
2025-06-26 10:54 ` Thomas Weißschuh
2025-06-27 12:58 ` Lee Jones
2025-07-19 17:40 ` [tip: locking/core] " tip-bot2 for Thomas Weißschuh
2025-06-17 17:08 ` [PATCH v7 3/3] locking/mutex: Mark devm_mutex_init() as __must_check Thomas Weißschuh
2025-06-17 17:32 ` Boqun Feng
2025-07-19 17:40 ` [tip: locking/core] " tip-bot2 for Thomas Weißschuh
2025-07-11 22:12 ` [PATCH v7 0/3] " Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625090439.GQ795775@google.com \
--to=lee@kernel.org \
--cc=afd@ti.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=boqun.feng@gmail.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=pavel@kernel.org \
--cc=peterz@infradead.org \
--cc=vicentiu.galanopulo@remote-tech.co.uk \
--cc=will@kernel.org \
--cc=yogeshgaur.83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®