mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mtd: rawnand: atmel: set pmecc data setup time
@ 2025-07-21 10:43 Balamanikandan Gunasundar
  2025-07-28 10:17 ` Miquel Raynal
  0 siblings, 1 reply; 2+ messages in thread
From: Balamanikandan Gunasundar @ 2025-07-21 10:43 UTC (permalink / raw)
  To: miquel.raynal, richard, vigneshr, nicolas.ferre,
	alexandre.belloni, claudiu.beznea, dan.carpenter, bbrezillon,
	linux-mtd, linux-arm-kernel, linux-kernel
  Cc: Balamanikandan Gunasundar, Zixun LI, Ada Couprie Diaz

Setup the pmecc data setup time as 3 clock cycles for 133MHz as recommended
by the datasheet.

Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
Reported-by: Zixun LI <admin@hifiphile.com>
Closes: https://lore.kernel.org/all/c015bb20-6a57-4f63-8102-34b3d83e0f5b@microchip.com
Suggested-by: Ada Couprie Diaz <ada.coupriediaz@arm.com>
Signed-off-by: Balamanikandan Gunasundar <balamanikandan.gunasundar@microchip.com>
---
 drivers/mtd/nand/raw/atmel/pmecc.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/mtd/nand/raw/atmel/pmecc.c b/drivers/mtd/nand/raw/atmel/pmecc.c
index 3c7dee1be21d..0b402823b619 100644
--- a/drivers/mtd/nand/raw/atmel/pmecc.c
+++ b/drivers/mtd/nand/raw/atmel/pmecc.c
@@ -143,6 +143,7 @@ struct atmel_pmecc_caps {
 	int nstrengths;
 	int el_offset;
 	bool correct_erased_chunks;
+	bool clk_ctrl;
 };
 
 struct atmel_pmecc {
@@ -843,6 +844,10 @@ static struct atmel_pmecc *atmel_pmecc_create(struct platform_device *pdev,
 	if (IS_ERR(pmecc->regs.errloc))
 		return ERR_CAST(pmecc->regs.errloc);
 
+	/* pmecc data setup time */
+	if (caps->clk_ctrl)
+		writel(PMECC_CLK_133MHZ, pmecc->regs.base + ATMEL_PMECC_CLK);
+
 	/* Disable all interrupts before registering the PMECC handler. */
 	writel(0xffffffff, pmecc->regs.base + ATMEL_PMECC_IDR);
 	atmel_pmecc_reset(pmecc);
@@ -896,6 +901,7 @@ static struct atmel_pmecc_caps at91sam9g45_caps = {
 	.strengths = atmel_pmecc_strengths,
 	.nstrengths = 5,
 	.el_offset = 0x8c,
+	.clk_ctrl = true,
 };
 
 static struct atmel_pmecc_caps sama5d4_caps = {
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtd: rawnand: atmel: set pmecc data setup time
  2025-07-21 10:43 [PATCH] mtd: rawnand: atmel: set pmecc data setup time Balamanikandan Gunasundar
@ 2025-07-28 10:17 ` Miquel Raynal
  0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2025-07-28 10:17 UTC (permalink / raw)
  To: richard, vigneshr, nicolas.ferre, alexandre.belloni,
	claudiu.beznea, dan.carpenter, bbrezillon, linux-mtd,
	linux-arm-kernel, linux-kernel, Balamanikandan Gunasundar
  Cc: Zixun LI, Ada Couprie Diaz

On Mon, 21 Jul 2025 16:13:40 +0530, Balamanikandan Gunasundar wrote:
> Setup the pmecc data setup time as 3 clock cycles for 133MHz as recommended
> by the datasheet.
> 
> 

Applied to nand/next, thanks!

[1/1] mtd: rawnand: atmel: set pmecc data setup time
      commit: c115e7ed66f0dc6cf96f9bf3e3c46f6c44aa531b

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-28 10:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-21 10:43 [PATCH] mtd: rawnand: atmel: set pmecc data setup time Balamanikandan Gunasundar
2025-07-28 10:17 ` Miquel Raynal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®