* [PATCH v2] block, bfq: remove redundant __GFP_NOWARN
@ 2025-08-11 8:11 Qianfeng Rong
2025-08-11 14:01 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Qianfeng Rong @ 2025-08-11 8:11 UTC (permalink / raw)
To: Yu Kuai, Jens Axboe, linux-block, linux-kernel; +Cc: Qianfeng Rong
Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT") made
GFP_NOWAIT implicitly include __GFP_NOWARN.
Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT (e.g.,
`GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean up these
redundant flags across subsystems.
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
block/bfq-iosched.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index 3bf76902f07f..50e51047e1fe 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -5847,8 +5847,7 @@ static struct bfq_queue *bfq_get_queue(struct bfq_data *bfqd,
goto out;
}
- bfqq = kmem_cache_alloc_node(bfq_pool,
- GFP_NOWAIT | __GFP_ZERO | __GFP_NOWARN,
+ bfqq = kmem_cache_alloc_node(bfq_pool, GFP_NOWAIT | __GFP_ZERO,
bfqd->queue->node);
if (bfqq) {
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] block, bfq: remove redundant __GFP_NOWARN
2025-08-11 8:11 [PATCH v2] block, bfq: remove redundant __GFP_NOWARN Qianfeng Rong
@ 2025-08-11 14:01 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2025-08-11 14:01 UTC (permalink / raw)
To: Yu Kuai, linux-block, linux-kernel, Qianfeng Rong
On Mon, 11 Aug 2025 16:11:35 +0800, Qianfeng Rong wrote:
> Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT") made
> GFP_NOWAIT implicitly include __GFP_NOWARN.
>
> Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT (e.g.,
> `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean up these
> redundant flags across subsystems.
>
> [...]
Applied, thanks!
[1/1] block, bfq: remove redundant __GFP_NOWARN
commit: 8f3e4e87b0945aeea8b5a5aa43c419f4a1b4ca6a
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-11 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-11 8:11 [PATCH v2] block, bfq: remove redundant __GFP_NOWARN Qianfeng Rong
2025-08-11 14:01 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®