* [PATCH v2 0/4] arm64: dts: qcom: sort out RPMhPD domain indices
@ 2025-07-18 15:25 Dmitry Baryshkov
2025-07-18 15:25 ` [PATCH v2 1/4] arm64: dts: qcom: sa8775p: fix RPMh power " Dmitry Baryshkov
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2025-07-18 15:25 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bartosz Golaszewski, Ling Xu, Dmitry Baryshkov,
Tengfei Fan, Jagadeesh Kona
Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio
Several Qualcomm board DTs either use incorrect power domain indices or
use old defines for RPMhPD even though the platform should be using
RPMHPD_foo defines. Correct all those issues.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Changes in v2:
- Fixed SM8160 -> SM8150 typo (Konrad)
- Made corresponding commit message more obvious by specifying indices
(Konrad)
- Link to v1: https://lore.kernel.org/r/20250717-fix-rpmhpd-abi-v1-0-4c82e25e3280@oss.qualcomm.com
---
Dmitry Baryshkov (4):
arm64: dts: qcom: sa8775p: fix RPMh power domain indices
arm64: dts: qcom: sm8150: use correct PD for DisplayPort controller
arm64: dts: qcom: sm8250: stop using SoC-specific genpd indices
arm64: dts: qcom: sm8550: stop using SoC-specific genpd indices
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 25 ++++++++++-----------
arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sm8250.dtsi | 42 +++++++++++++++++------------------
arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +-
4 files changed, 35 insertions(+), 36 deletions(-)
---
base-commit: 78a8f8d4ec2bf09266a03a0a8cb0af82da0766d5
change-id: 20250716-fix-rpmhpd-abi-2ac5b7e5865f
Best regards,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2 1/4] arm64: dts: qcom: sa8775p: fix RPMh power domain indices 2025-07-18 15:25 [PATCH v2 0/4] arm64: dts: qcom: sort out RPMhPD domain indices Dmitry Baryshkov @ 2025-07-18 15:25 ` Dmitry Baryshkov 2025-07-20 3:28 ` Bjorn Andersson 2025-07-18 15:25 ` [PATCH v2 2/4] arm64: dts: qcom: sm8150: use correct PD for DisplayPort controller Dmitry Baryshkov ` (3 subsequent siblings) 4 siblings, 1 reply; 9+ messages in thread From: Dmitry Baryshkov @ 2025-07-18 15:25 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Ling Xu, Dmitry Baryshkov, Tengfei Fan, Jagadeesh Kona Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio On SA8775P power domains device doesn't use unufied (RPMHPD_foo) ABI, but it uses SoC-specific indices (SA8775P_foo). Consequently, all DSP on that platform are referencing random PDs instead of the expected ones. Correct indices used for that platform. Fixes: df54dcb34ff2 ("arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes") Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 9997a29901f57d7894dc1eacb6a809caa427c6c4..214e2c0e74ef53e8bc57acb8ee88901ef1006298 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -17,7 +17,6 @@ #include <dt-bindings/interconnect/qcom,sa8775p-rpmh.h> #include <dt-bindings/mailbox/qcom-ipcc.h> #include <dt-bindings/firmware/qcom,scm.h> -#include <dt-bindings/power/qcom,rpmhpd.h> #include <dt-bindings/power/qcom-rpmpd.h> #include <dt-bindings/soc/qcom,rpmh-rsc.h> @@ -6055,8 +6054,8 @@ remoteproc_gpdsp0: remoteproc@20c00000 { clocks = <&rpmhcc RPMH_CXO_CLK>; clock-names = "xo"; - power-domains = <&rpmhpd RPMHPD_CX>, - <&rpmhpd RPMHPD_MXC>; + power-domains = <&rpmhpd SA8775P_CX>, + <&rpmhpd SA8775P_MXC>; power-domain-names = "cx", "mxc"; interconnects = <&gpdsp_anoc MASTER_DSP0 0 @@ -6098,8 +6097,8 @@ remoteproc_gpdsp1: remoteproc@21c00000 { clocks = <&rpmhcc RPMH_CXO_CLK>; clock-names = "xo"; - power-domains = <&rpmhpd RPMHPD_CX>, - <&rpmhpd RPMHPD_MXC>; + power-domains = <&rpmhpd SA8775P_CX>, + <&rpmhpd SA8775P_MXC>; power-domain-names = "cx", "mxc"; interconnects = <&gpdsp_anoc MASTER_DSP1 0 @@ -6239,9 +6238,9 @@ remoteproc_cdsp0: remoteproc@26300000 { clocks = <&rpmhcc RPMH_CXO_CLK>; clock-names = "xo"; - power-domains = <&rpmhpd RPMHPD_CX>, - <&rpmhpd RPMHPD_MXC>, - <&rpmhpd RPMHPD_NSP0>; + power-domains = <&rpmhpd SA8775P_CX>, + <&rpmhpd SA8775P_MXC>, + <&rpmhpd SA8775P_NSP0>; power-domain-names = "cx", "mxc", "nsp"; interconnects = <&nspa_noc MASTER_CDSP_PROC 0 @@ -6371,9 +6370,9 @@ remoteproc_cdsp1: remoteproc@2a300000 { clocks = <&rpmhcc RPMH_CXO_CLK>; clock-names = "xo"; - power-domains = <&rpmhpd RPMHPD_CX>, - <&rpmhpd RPMHPD_MXC>, - <&rpmhpd RPMHPD_NSP1>; + power-domains = <&rpmhpd SA8775P_CX>, + <&rpmhpd SA8775P_MXC>, + <&rpmhpd SA8775P_NSP1>; power-domain-names = "cx", "mxc", "nsp"; interconnects = <&nspb_noc MASTER_CDSP_PROC_B 0 @@ -6527,8 +6526,8 @@ remoteproc_adsp: remoteproc@30000000 { clocks = <&rpmhcc RPMH_CXO_CLK>; clock-names = "xo"; - power-domains = <&rpmhpd RPMHPD_LCX>, - <&rpmhpd RPMHPD_LMX>; + power-domains = <&rpmhpd SA8775P_LCX>, + <&rpmhpd SA8775P_LMX>; power-domain-names = "lcx", "lmx"; interconnects = <&lpass_ag_noc MASTER_LPASS_PROC 0 &mc_virt SLAVE_EBI1 0>; -- 2.39.5 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/4] arm64: dts: qcom: sa8775p: fix RPMh power domain indices 2025-07-18 15:25 ` [PATCH v2 1/4] arm64: dts: qcom: sa8775p: fix RPMh power " Dmitry Baryshkov @ 2025-07-20 3:28 ` Bjorn Andersson 0 siblings, 0 replies; 9+ messages in thread From: Bjorn Andersson @ 2025-07-20 3:28 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Ling Xu, Dmitry Baryshkov, Tengfei Fan, Jagadeesh Kona, linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio On Fri, Jul 18, 2025 at 06:25:38PM +0300, Dmitry Baryshkov wrote: > On SA8775P power domains device doesn't use unufied (RPMHPD_foo) ABI, "unified" > but it uses SoC-specific indices (SA8775P_foo). Consequently, all DSP on > that platform are referencing random PDs instead of the expected ones. > > Correct indices used for that platform. > Reviewed-by: Bjorn Andersson <andersson@kernel.org> Regards, Bjorn > Fixes: df54dcb34ff2 ("arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes") > Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 25 ++++++++++++------------- > 1 file changed, 12 insertions(+), 13 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 9997a29901f57d7894dc1eacb6a809caa427c6c4..214e2c0e74ef53e8bc57acb8ee88901ef1006298 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -17,7 +17,6 @@ > #include <dt-bindings/interconnect/qcom,sa8775p-rpmh.h> > #include <dt-bindings/mailbox/qcom-ipcc.h> > #include <dt-bindings/firmware/qcom,scm.h> > -#include <dt-bindings/power/qcom,rpmhpd.h> > #include <dt-bindings/power/qcom-rpmpd.h> > #include <dt-bindings/soc/qcom,rpmh-rsc.h> > > @@ -6055,8 +6054,8 @@ remoteproc_gpdsp0: remoteproc@20c00000 { > clocks = <&rpmhcc RPMH_CXO_CLK>; > clock-names = "xo"; > > - power-domains = <&rpmhpd RPMHPD_CX>, > - <&rpmhpd RPMHPD_MXC>; > + power-domains = <&rpmhpd SA8775P_CX>, > + <&rpmhpd SA8775P_MXC>; > power-domain-names = "cx", "mxc"; > > interconnects = <&gpdsp_anoc MASTER_DSP0 0 > @@ -6098,8 +6097,8 @@ remoteproc_gpdsp1: remoteproc@21c00000 { > clocks = <&rpmhcc RPMH_CXO_CLK>; > clock-names = "xo"; > > - power-domains = <&rpmhpd RPMHPD_CX>, > - <&rpmhpd RPMHPD_MXC>; > + power-domains = <&rpmhpd SA8775P_CX>, > + <&rpmhpd SA8775P_MXC>; > power-domain-names = "cx", "mxc"; > > interconnects = <&gpdsp_anoc MASTER_DSP1 0 > @@ -6239,9 +6238,9 @@ remoteproc_cdsp0: remoteproc@26300000 { > clocks = <&rpmhcc RPMH_CXO_CLK>; > clock-names = "xo"; > > - power-domains = <&rpmhpd RPMHPD_CX>, > - <&rpmhpd RPMHPD_MXC>, > - <&rpmhpd RPMHPD_NSP0>; > + power-domains = <&rpmhpd SA8775P_CX>, > + <&rpmhpd SA8775P_MXC>, > + <&rpmhpd SA8775P_NSP0>; > power-domain-names = "cx", "mxc", "nsp"; > > interconnects = <&nspa_noc MASTER_CDSP_PROC 0 > @@ -6371,9 +6370,9 @@ remoteproc_cdsp1: remoteproc@2a300000 { > clocks = <&rpmhcc RPMH_CXO_CLK>; > clock-names = "xo"; > > - power-domains = <&rpmhpd RPMHPD_CX>, > - <&rpmhpd RPMHPD_MXC>, > - <&rpmhpd RPMHPD_NSP1>; > + power-domains = <&rpmhpd SA8775P_CX>, > + <&rpmhpd SA8775P_MXC>, > + <&rpmhpd SA8775P_NSP1>; > power-domain-names = "cx", "mxc", "nsp"; > > interconnects = <&nspb_noc MASTER_CDSP_PROC_B 0 > @@ -6527,8 +6526,8 @@ remoteproc_adsp: remoteproc@30000000 { > clocks = <&rpmhcc RPMH_CXO_CLK>; > clock-names = "xo"; > > - power-domains = <&rpmhpd RPMHPD_LCX>, > - <&rpmhpd RPMHPD_LMX>; > + power-domains = <&rpmhpd SA8775P_LCX>, > + <&rpmhpd SA8775P_LMX>; > power-domain-names = "lcx", "lmx"; > > interconnects = <&lpass_ag_noc MASTER_LPASS_PROC 0 &mc_virt SLAVE_EBI1 0>; > > -- > 2.39.5 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/4] arm64: dts: qcom: sm8150: use correct PD for DisplayPort controller 2025-07-18 15:25 [PATCH v2 0/4] arm64: dts: qcom: sort out RPMhPD domain indices Dmitry Baryshkov 2025-07-18 15:25 ` [PATCH v2 1/4] arm64: dts: qcom: sa8775p: fix RPMh power " Dmitry Baryshkov @ 2025-07-18 15:25 ` Dmitry Baryshkov 2025-07-20 3:30 ` Bjorn Andersson 2025-07-18 15:25 ` [PATCH v2 3/4] arm64: dts: qcom: sm8250: stop using SoC-specific genpd indices Dmitry Baryshkov ` (2 subsequent siblings) 4 siblings, 1 reply; 9+ messages in thread From: Dmitry Baryshkov @ 2025-07-18 15:25 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Ling Xu, Dmitry Baryshkov, Tengfei Fan, Jagadeesh Kona Cc: linux-arm-msm, devicetree, linux-kernel Commit 5dd110c90a50 ("arm64: dts: qcom: sm8150: add DisplayPort controller") specified SM8250_MMCX (= 6) for the DisplayPort power domain, however on SM8150 this indices maps to SM8150_MX_AO (= 6). Use correct indice instead (SM8150_MMCX = 9). Fixes: 5dd110c90a50 ("arm64: dts: qcom: sm8150: add DisplayPort controller") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index abf12e10d33f1ce5c74e3e9136585bcb0a578492..4b347ee3244100a4db515515b73575383c5a0cb7 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -3908,7 +3908,7 @@ mdss_dp: displayport-controller@ae90000 { #sound-dai-cells = <0>; operating-points-v2 = <&dp_opp_table>; - power-domains = <&rpmhpd SM8250_MMCX>; + power-domains = <&rpmhpd SM8150_MMCX>; status = "disabled"; -- 2.39.5 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/4] arm64: dts: qcom: sm8150: use correct PD for DisplayPort controller 2025-07-18 15:25 ` [PATCH v2 2/4] arm64: dts: qcom: sm8150: use correct PD for DisplayPort controller Dmitry Baryshkov @ 2025-07-20 3:30 ` Bjorn Andersson 0 siblings, 0 replies; 9+ messages in thread From: Bjorn Andersson @ 2025-07-20 3:30 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Ling Xu, Dmitry Baryshkov, Tengfei Fan, Jagadeesh Kona, linux-arm-msm, devicetree, linux-kernel On Fri, Jul 18, 2025 at 06:25:39PM +0300, Dmitry Baryshkov wrote: > Commit 5dd110c90a50 ("arm64: dts: qcom: sm8150: add DisplayPort > controller") specified SM8250_MMCX (= 6) for the DisplayPort power > domain, however on SM8150 this indices maps to SM8150_MX_AO (= 6). Use > correct indice instead (SM8150_MMCX = 9). > Reviewed-by: Bjorn Andersson <andersson@kernel.org> > Fixes: 5dd110c90a50 ("arm64: dts: qcom: sm8150: add DisplayPort controller") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > index abf12e10d33f1ce5c74e3e9136585bcb0a578492..4b347ee3244100a4db515515b73575383c5a0cb7 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > @@ -3908,7 +3908,7 @@ mdss_dp: displayport-controller@ae90000 { > #sound-dai-cells = <0>; > > operating-points-v2 = <&dp_opp_table>; > - power-domains = <&rpmhpd SM8250_MMCX>; > + power-domains = <&rpmhpd SM8150_MMCX>; > > status = "disabled"; > > > -- > 2.39.5 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 3/4] arm64: dts: qcom: sm8250: stop using SoC-specific genpd indices 2025-07-18 15:25 [PATCH v2 0/4] arm64: dts: qcom: sort out RPMhPD domain indices Dmitry Baryshkov 2025-07-18 15:25 ` [PATCH v2 1/4] arm64: dts: qcom: sa8775p: fix RPMh power " Dmitry Baryshkov 2025-07-18 15:25 ` [PATCH v2 2/4] arm64: dts: qcom: sm8150: use correct PD for DisplayPort controller Dmitry Baryshkov @ 2025-07-18 15:25 ` Dmitry Baryshkov 2025-07-18 15:25 ` [PATCH v2 4/4] arm64: dts: qcom: sm8550: " Dmitry Baryshkov 2025-08-11 14:57 ` [PATCH v2 0/4] arm64: dts: qcom: sort out RPMhPD domain indices Bjorn Andersson 4 siblings, 0 replies; 9+ messages in thread From: Dmitry Baryshkov @ 2025-07-18 15:25 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Ling Xu, Dmitry Baryshkov, Tengfei Fan, Jagadeesh Kona Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio The SM8250 has switched to RPMHPD_* indices for RPMh power domains, however commit 86a9264b6c56 ("arm64: dts: qcom: sm8250: Add interconnects and power-domains to QUPs") brought some more old-style indices. Convert all of them to use common RPMh PD indices. Fixes: 86a9264b6c56 ("arm64: dts: qcom: sm8250: Add interconnects and power-domains to QUPs") Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 42 ++++++++++++++++++------------------ 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index b0197602c677d49f7833f31d71f72436499bfe84..244339cfbed5c32708c282de18f5655535e2ff45 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -1030,7 +1030,7 @@ i2c14: i2c@880000 { dmas = <&gpi_dma2 0 0 QCOM_GPI_I2C>, <&gpi_dma2 1 0 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_2 0 &qup_virt SLAVE_QUP_CORE_2 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_2 0>, <&aggre1_noc MASTER_QUP_2 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1075,7 +1075,7 @@ i2c15: i2c@884000 { dmas = <&gpi_dma2 0 1 QCOM_GPI_I2C>, <&gpi_dma2 1 1 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_2 0 &qup_virt SLAVE_QUP_CORE_2 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_2 0>, <&aggre1_noc MASTER_QUP_2 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1120,7 +1120,7 @@ i2c16: i2c@888000 { dmas = <&gpi_dma2 0 2 QCOM_GPI_I2C>, <&gpi_dma2 1 2 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_2 0 &qup_virt SLAVE_QUP_CORE_2 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_2 0>, <&aggre1_noc MASTER_QUP_2 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1165,7 +1165,7 @@ i2c17: i2c@88c000 { dmas = <&gpi_dma2 0 3 QCOM_GPI_I2C>, <&gpi_dma2 1 3 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_2 0 &qup_virt SLAVE_QUP_CORE_2 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_2 0>, <&aggre1_noc MASTER_QUP_2 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1227,7 +1227,7 @@ i2c18: i2c@890000 { dmas = <&gpi_dma2 0 4 QCOM_GPI_I2C>, <&gpi_dma2 1 4 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_2 0 &qup_virt SLAVE_QUP_CORE_2 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_2 0>, <&aggre1_noc MASTER_QUP_2 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1289,7 +1289,7 @@ i2c19: i2c@894000 { dmas = <&gpi_dma2 0 5 QCOM_GPI_I2C>, <&gpi_dma2 1 5 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_2 0 &qup_virt SLAVE_QUP_CORE_2 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_2 0>, <&aggre1_noc MASTER_QUP_2 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1370,7 +1370,7 @@ i2c0: i2c@980000 { dmas = <&gpi_dma0 0 0 QCOM_GPI_I2C>, <&gpi_dma0 1 0 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_0 0 &qup_virt SLAVE_QUP_CORE_0 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_0 0>, <&aggre2_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1415,7 +1415,7 @@ i2c1: i2c@984000 { dmas = <&gpi_dma0 0 1 QCOM_GPI_I2C>, <&gpi_dma0 1 1 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_0 0 &qup_virt SLAVE_QUP_CORE_0 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_0 0>, <&aggre2_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1460,7 +1460,7 @@ i2c2: i2c@988000 { dmas = <&gpi_dma0 0 2 QCOM_GPI_I2C>, <&gpi_dma0 1 2 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_0 0 &qup_virt SLAVE_QUP_CORE_0 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_0 0>, <&aggre2_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1522,7 +1522,7 @@ i2c3: i2c@98c000 { dmas = <&gpi_dma0 0 3 QCOM_GPI_I2C>, <&gpi_dma0 1 3 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_0 0 &qup_virt SLAVE_QUP_CORE_0 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_0 0>, <&aggre2_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1567,7 +1567,7 @@ i2c4: i2c@990000 { dmas = <&gpi_dma0 0 4 QCOM_GPI_I2C>, <&gpi_dma0 1 4 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_0 0 &qup_virt SLAVE_QUP_CORE_0 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_0 0>, <&aggre2_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1612,7 +1612,7 @@ i2c5: i2c@994000 { dmas = <&gpi_dma0 0 5 QCOM_GPI_I2C>, <&gpi_dma0 1 5 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_0 0 &qup_virt SLAVE_QUP_CORE_0 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_0 0>, <&aggre2_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1657,7 +1657,7 @@ i2c6: i2c@998000 { dmas = <&gpi_dma0 0 6 QCOM_GPI_I2C>, <&gpi_dma0 1 6 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_0 0 &qup_virt SLAVE_QUP_CORE_0 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_0 0>, <&aggre2_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1719,7 +1719,7 @@ i2c7: i2c@99c000 { dmas = <&gpi_dma0 0 7 QCOM_GPI_I2C>, <&gpi_dma0 1 7 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_0 0 &qup_virt SLAVE_QUP_CORE_0 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_0 0>, <&aggre2_noc MASTER_QUP_0 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1797,7 +1797,7 @@ i2c8: i2c@a80000 { dmas = <&gpi_dma1 0 0 QCOM_GPI_I2C>, <&gpi_dma1 1 0 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_1 0 &qup_virt SLAVE_QUP_CORE_1 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_1 0>, <&aggre1_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1842,7 +1842,7 @@ i2c9: i2c@a84000 { dmas = <&gpi_dma1 0 1 QCOM_GPI_I2C>, <&gpi_dma1 1 1 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_1 0 &qup_virt SLAVE_QUP_CORE_1 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_1 0>, <&aggre1_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1887,7 +1887,7 @@ i2c10: i2c@a88000 { dmas = <&gpi_dma1 0 2 QCOM_GPI_I2C>, <&gpi_dma1 1 2 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_1 0 &qup_virt SLAVE_QUP_CORE_1 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_1 0>, <&aggre1_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1932,7 +1932,7 @@ i2c11: i2c@a8c000 { dmas = <&gpi_dma1 0 3 QCOM_GPI_I2C>, <&gpi_dma1 1 3 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_1 0 &qup_virt SLAVE_QUP_CORE_1 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_1 0>, <&aggre1_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -1977,7 +1977,7 @@ i2c12: i2c@a90000 { dmas = <&gpi_dma1 0 4 QCOM_GPI_I2C>, <&gpi_dma1 1 4 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_1 0 &qup_virt SLAVE_QUP_CORE_1 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_1 0>, <&aggre1_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -2039,7 +2039,7 @@ i2c13: i2c@a94000 { dmas = <&gpi_dma1 0 5 QCOM_GPI_I2C>, <&gpi_dma1 1 5 QCOM_GPI_I2C>; dma-names = "tx", "rx"; - power-domains = <&rpmhpd SM8250_CX>; + power-domains = <&rpmhpd RPMHPD_CX>; interconnects = <&qup_virt MASTER_QUP_CORE_1 0 &qup_virt SLAVE_QUP_CORE_1 0>, <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_1 0>, <&aggre1_noc MASTER_QUP_1 0 &mc_virt SLAVE_EBI_CH0 0>; @@ -4789,7 +4789,7 @@ mdss_dp: displayport-controller@ae90000 { #sound-dai-cells = <0>; operating-points-v2 = <&dp_opp_table>; - power-domains = <&rpmhpd SM8250_MMCX>; + power-domains = <&rpmhpd RPMHPD_MMCX>; status = "disabled"; -- 2.39.5 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 4/4] arm64: dts: qcom: sm8550: stop using SoC-specific genpd indices 2025-07-18 15:25 [PATCH v2 0/4] arm64: dts: qcom: sort out RPMhPD domain indices Dmitry Baryshkov ` (2 preceding siblings ...) 2025-07-18 15:25 ` [PATCH v2 3/4] arm64: dts: qcom: sm8250: stop using SoC-specific genpd indices Dmitry Baryshkov @ 2025-07-18 15:25 ` Dmitry Baryshkov 2025-07-24 8:19 ` neil.armstrong 2025-08-11 14:57 ` [PATCH v2 0/4] arm64: dts: qcom: sort out RPMhPD domain indices Bjorn Andersson 4 siblings, 1 reply; 9+ messages in thread From: Dmitry Baryshkov @ 2025-07-18 15:25 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Ling Xu, Dmitry Baryshkov, Tengfei Fan, Jagadeesh Kona Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio The SM8550 has switched to RPMHPD_* indices for RPMh power domains, however commit e271b59e39a6 ("arm64: dts: qcom: sm8550: Add camera clock controller") brought some more old-style indices. Convert all of them to use common RPMh PD indices. Fixes: e271b59e39a6 ("arm64: dts: qcom: sm8550: Add camera clock controller") Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index 45713d46f3c52487d2638b7ab194c111f58679ce..a4ca06679c2f1eebacdd5938e380981c1b17925b 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -3623,7 +3623,7 @@ camcc: clock-controller@ade0000 { <&bi_tcxo_div2>, <&bi_tcxo_ao_div2>, <&sleep_clk>; - power-domains = <&rpmhpd SM8550_MMCX>; + power-domains = <&rpmhpd RPMHPD_MMCX>; required-opps = <&rpmhpd_opp_low_svs>; #clock-cells = <1>; #reset-cells = <1>; -- 2.39.5 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 4/4] arm64: dts: qcom: sm8550: stop using SoC-specific genpd indices 2025-07-18 15:25 ` [PATCH v2 4/4] arm64: dts: qcom: sm8550: " Dmitry Baryshkov @ 2025-07-24 8:19 ` neil.armstrong 0 siblings, 0 replies; 9+ messages in thread From: neil.armstrong @ 2025-07-24 8:19 UTC (permalink / raw) To: Dmitry Baryshkov, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Ling Xu, Dmitry Baryshkov, Tengfei Fan, Jagadeesh Kona Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio On 18/07/2025 17:25, Dmitry Baryshkov wrote: > The SM8550 has switched to RPMHPD_* indices for RPMh power domains, > however commit e271b59e39a6 ("arm64: dts: qcom: sm8550: Add camera clock > controller") brought some more old-style indices. Convert all of them to > use common RPMh PD indices. > > Fixes: e271b59e39a6 ("arm64: dts: qcom: sm8550: Add camera clock controller") > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi > index 45713d46f3c52487d2638b7ab194c111f58679ce..a4ca06679c2f1eebacdd5938e380981c1b17925b 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi > @@ -3623,7 +3623,7 @@ camcc: clock-controller@ade0000 { > <&bi_tcxo_div2>, > <&bi_tcxo_ao_div2>, > <&sleep_clk>; > - power-domains = <&rpmhpd SM8550_MMCX>; > + power-domains = <&rpmhpd RPMHPD_MMCX>; > required-opps = <&rpmhpd_opp_low_svs>; > #clock-cells = <1>; > #reset-cells = <1>; > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/4] arm64: dts: qcom: sort out RPMhPD domain indices 2025-07-18 15:25 [PATCH v2 0/4] arm64: dts: qcom: sort out RPMhPD domain indices Dmitry Baryshkov ` (3 preceding siblings ...) 2025-07-18 15:25 ` [PATCH v2 4/4] arm64: dts: qcom: sm8550: " Dmitry Baryshkov @ 2025-08-11 14:57 ` Bjorn Andersson 4 siblings, 0 replies; 9+ messages in thread From: Bjorn Andersson @ 2025-08-11 14:57 UTC (permalink / raw) To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Ling Xu, Dmitry Baryshkov, Tengfei Fan, Jagadeesh Kona, Dmitry Baryshkov Cc: linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio On Fri, 18 Jul 2025 18:25:37 +0300, Dmitry Baryshkov wrote: > Several Qualcomm board DTs either use incorrect power domain indices or > use old defines for RPMhPD even though the platform should be using > RPMHPD_foo defines. Correct all those issues. > > Applied, thanks! [1/4] arm64: dts: qcom: sa8775p: fix RPMh power domain indices commit: 3ede313b5ec41bf1064fc35a168618eaee0d8e98 [2/4] arm64: dts: qcom: sm8150: use correct PD for DisplayPort controller commit: 1d517444b21e49bb049dc1ca9df0281ba5203c86 [3/4] arm64: dts: qcom: sm8250: stop using SoC-specific genpd indices commit: c48aa92720dc1b883982b1b7e110429d2e316c22 [4/4] arm64: dts: qcom: sm8550: stop using SoC-specific genpd indices commit: 633ffe23173d947e4075ecf419889a59e6851ea9 Best regards, -- Bjorn Andersson <andersson@kernel.org> ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-08-11 14:57 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2025-07-18 15:25 [PATCH v2 0/4] arm64: dts: qcom: sort out RPMhPD domain indices Dmitry Baryshkov 2025-07-18 15:25 ` [PATCH v2 1/4] arm64: dts: qcom: sa8775p: fix RPMh power " Dmitry Baryshkov 2025-07-20 3:28 ` Bjorn Andersson 2025-07-18 15:25 ` [PATCH v2 2/4] arm64: dts: qcom: sm8150: use correct PD for DisplayPort controller Dmitry Baryshkov 2025-07-20 3:30 ` Bjorn Andersson 2025-07-18 15:25 ` [PATCH v2 3/4] arm64: dts: qcom: sm8250: stop using SoC-specific genpd indices Dmitry Baryshkov 2025-07-18 15:25 ` [PATCH v2 4/4] arm64: dts: qcom: sm8550: " Dmitry Baryshkov 2025-07-24 8:19 ` neil.armstrong 2025-08-11 14:57 ` [PATCH v2 0/4] arm64: dts: qcom: sort out RPMhPD domain indices Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®