[PATCH 0/2] Add QPIC SPI NAND support for IPQ5018

[PATCH 0/2] Add QPIC SPI NAND support for IPQ5018

[George Moussalem via B4 Relay]

Add support for the QPIC SPI NAND controller found in IPQ5018 which is 
the same as the one found in IPQ5018.

Signed-off-by: George Moussalem <george.moussalem@outlook.com>
---
George Moussalem (2):
      dt-bindings: spi: spi-qpic-snand: Add IPQ5018 compatible
      arm64: dts: qcom: ipq5018: Add SPI nand support

 .../bindings/spi/qcom,spi-qpic-snand.yaml          |  8 +++--
 arch/arm64/boot/dts/qcom/ipq5018.dtsi              | 38 ++++++++++++++++++++++
 2 files changed, 44 insertions(+), 2 deletions(-)
---
base-commit: 8a2d53ce3c5f82683ad3df9a9a55822816fe64e7
change-id: 20250501-ipq5018-spi-qpic-snand-94965e899233

Best regards,
-- 
George Moussalem <george.moussalem@outlook.com>

[PATCH 1/2] dt-bindings: spi: spi-qpic-snand: Add IPQ5018 compatible

[George Moussalem via B4 Relay]

From: George Moussalem <george.moussalem@outlook.com>

IPQ5018 contains the QPIC-SPI-NAND flash controller which is the same as
the one found in IPQ9574. So let's document the IPQ5018 compatible and
use IPQ9574 as the fallback.

Signed-off-by: George Moussalem <george.moussalem@outlook.com>
---
 Documentation/devicetree/bindings/spi/qcom,spi-qpic-snand.yaml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qpic-snand.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qpic-snand.yaml
index aa3f933192034fe6d54d6149373d50c31ec4aa96..cb1f15224b45574a3c3d603566c859a9bec41937 100644
--- a/Documentation/devicetree/bindings/spi/qcom,spi-qpic-snand.yaml
+++ b/Documentation/devicetree/bindings/spi/qcom,spi-qpic-snand.yaml
@@ -21,8 +21,12 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - qcom,ipq9574-snand
+    oneOf:
+      - items:
+          - enum:
+              - qcom,ipq5018-snand
+          - const: qcom,ipq9574-snand
+      - const: qcom,ipq9574-snand
 
   reg:
     maxItems: 1

-- 
2.49.0

Re: [PATCH 1/2] dt-bindings: spi: spi-qpic-snand: Add IPQ5018 compatible

[Krzysztof Kozlowski]

On Thu, May 01, 2025 at 01:20:51PM GMT, George Moussalem wrote:
> IPQ5018 contains the QPIC-SPI-NAND flash controller which is the same as
> the one found in IPQ9574. So let's document the IPQ5018 compatible and
> use IPQ9574 as the fallback.
> 
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> ---
>  Documentation/devicetree/bindings/spi/qcom,spi-qpic-snand.yaml | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 2/2] arm64: dts: qcom: ipq5018: Add SPI nand support

[George Moussalem via B4 Relay]

From: George Moussalem <george.moussalem@outlook.com>

Add QPIC SPI NAND support for IPQ5018 SoC.

Signed-off-by: George Moussalem <george.moussalem@outlook.com>
---
 arch/arm64/boot/dts/qcom/ipq5018.dtsi | 38 +++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
index 8914f2ef0bc47fda243b19174f77ce73fc10757d..b7454ed64474edb71c284bdb8e9f1e781b128437 100644
--- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
@@ -238,6 +238,44 @@ blsp1_spi1: spi@78b5000 {
 			status = "disabled";
 		};
 
+		qpic_bam: dma-controller@7984000 {
+			compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
+			reg = <0x07984000 0x1c000>;
+
+			interrupts = <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>;
+
+			clocks = <&gcc GCC_QPIC_AHB_CLK>;
+			clock-names = "bam_clk";
+
+			#dma-cells = <1>;
+			qcom,ee = <0>;
+
+			status = "disabled";
+		};
+
+		qpic_nand: spi@79b0000 {
+			compatible = "qcom,ipq5018-snand", "qcom,ipq9574-snand";
+			reg = <0x079b0000 0x10000>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			clocks = <&gcc GCC_QPIC_CLK>,
+				 <&gcc GCC_QPIC_AHB_CLK>,
+				 <&gcc GCC_QPIC_IO_MACRO_CLK>;
+			clock-names = "core",
+				      "aon",
+				      "iom";
+
+			dmas = <&qpic_bam 0>,
+			       <&qpic_bam 1>,
+			       <&qpic_bam 2>;
+			dma-names = "tx",
+				    "rx",
+				    "cmd";
+
+			status = "disabled";
+		};
+
 		usb: usb@8af8800 {
 			compatible = "qcom,ipq5018-dwc3", "qcom,dwc3";
 			reg = <0x08af8800 0x400>;

-- 
2.49.0

Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: Add SPI nand support

[Konrad Dybcio]

On 5/1/25 11:20 AM, George Moussalem via B4 Relay wrote:
> From: George Moussalem <george.moussalem@outlook.com>
> 
> Add QPIC SPI NAND support for IPQ5018 SoC.
> 
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: (subset) [PATCH 0/2] Add QPIC SPI NAND support for IPQ5018

[Mark Brown]

On Thu, 01 May 2025 13:20:50 +0400, George Moussalem wrote:
> Add support for the QPIC SPI NAND controller found in IPQ5018 which is
> the same as the one found in IPQ5018.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] dt-bindings: spi: spi-qpic-snand: Add IPQ5018 compatible
      commit: 2dbe74c63cb73829be0aab0d0e7e68b87071b5fa

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: (subset) [PATCH 0/2] Add QPIC SPI NAND support for IPQ5018

[Bjorn Andersson]

On Thu, 01 May 2025 13:20:50 +0400, George Moussalem wrote:
> Add support for the QPIC SPI NAND controller found in IPQ5018 which is
> the same as the one found in IPQ5018.
> 
> 

Applied, thanks!

[2/2] arm64: dts: qcom: ipq5018: Add SPI nand support
      commit: 8d2a8e8dc448f218b36b3b9f3790c9c0dfaa2b74

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>