From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Liao Yuanhong <liaoyuanhong@vivo.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Cc: Liao Yuanhong <liaoyuanhong@vivo.com>
Subject: Re: [PATCH] media: imx296: Remove redundant semicolons
Date: Wed, 13 Aug 2025 11:18:16 +0100 [thread overview]
Message-ID: <175508029630.560048.7835285687538106544@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <20250813094746.557013-1-liaoyuanhong@vivo.com>
Quoting Liao Yuanhong (2025-08-13 10:47:46)
> Remove unnecessary semicolons.
Well ... there's only one so it's not plural ;-) but indeed this is very
redundant!
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
> drivers/media/i2c/imx296.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx296.c b/drivers/media/i2c/imx296.c
> index f3bec16b527c..cbbe0e7a37a9 100644
> --- a/drivers/media/i2c/imx296.c
> +++ b/drivers/media/i2c/imx296.c
> @@ -922,7 +922,7 @@ static int imx296_read_temperature(struct imx296 *sensor, int *temp)
>
> tmdout &= IMX296_TMDOUT_MASK;
>
> - /* T(��C) = 246.312 - 0.304 * TMDOUT */;
> + /* T(��C) = 246.312 - 0.304 * TMDOUT */
> *temp = 246312 - 304 * tmdout;
>
> return imx296_write(sensor, IMX296_TMDCTRL, 0, NULL);
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-08-13 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 9:47 Liao Yuanhong
2025-08-13 10:18 ` Kieran Bingham [this message]
2025-08-13 10:38 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175508029630.560048.7835285687538106544@ping.linuxembedded.co.uk \
--to=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=liaoyuanhong@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®