mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Liao Yuanhong <liaoyuanhong@vivo.com>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] media: imx296: Remove redundant semicolons
Date: Wed, 13 Aug 2025 13:38:49 +0300	[thread overview]
Message-ID: <20250813103849.GC6440@pendragon.ideasonboard.com> (raw)
In-Reply-To: <175508029630.560048.7835285687538106544@ping.linuxembedded.co.uk>

On Wed, Aug 13, 2025 at 11:18:16AM +0100, Kieran Bingham wrote:
> Quoting Liao Yuanhong (2025-08-13 10:47:46)
> > Remove unnecessary semicolons.
> 
> Well ... there's only one so it's not plural ;-) but indeed this is very
> redundant!
> 
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > 
> > Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> > ---
> >  drivers/media/i2c/imx296.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/i2c/imx296.c b/drivers/media/i2c/imx296.c
> > index f3bec16b527c..cbbe0e7a37a9 100644
> > --- a/drivers/media/i2c/imx296.c
> > +++ b/drivers/media/i2c/imx296.c
> > @@ -922,7 +922,7 @@ static int imx296_read_temperature(struct imx296 *sensor, int *temp)
> >  
> >         tmdout &= IMX296_TMDOUT_MASK;
> >  
> > -       /* T(��C) = 246.312 - 0.304 * TMDOUT */;
> > +       /* T(��C) = 246.312 - 0.304 * TMDOUT */
> >         *temp = 246312 - 304 * tmdout;
> >  
> >         return imx296_write(sensor, IMX296_TMDCTRL, 0, NULL);

-- 
Regards,

Laurent Pinchart

      reply	other threads:[~2025-08-13 10:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13  9:47 Liao Yuanhong
2025-08-13 10:18 ` Kieran Bingham
2025-08-13 10:38   ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250813103849.GC6440@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=liaoyuanhong@vivo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®