mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: William Breathitt Gray <wbg@kernel.org>
To: Vignesh Raghavendra <vigneshr@ti.com>,
	Julien Panis <jpanis@baylibre.com>, Andrew Davis <afd@ti.com>,
	Waqar Hameed <waqar.hameed@axis.com>
Cc: William Breathitt Gray <wbg@kernel.org>,
	kernel@axis.com, linux-iio@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] counter: ti-ecap-capture: Use devm_pm_runtime_enable()
Date: Sun, 24 Aug 2025 17:06:24 +0900	[thread overview]
Message-ID: <175602272525.419332.11059830322724662200.b4-ty@kernel.org> (raw)
In-Reply-To: <pnda54bjmij.a.out@axis.com>


On Thu, 07 Aug 2025 15:21:08 +0200, Waqar Hameed wrote:
> There is no need to register a manual `devm` action for
> `pm_runtime_disable()` when `devm_pm_runtime_enable()` exists. It does
> the same thing (but also calls `pm_runtime_dont_use_autosuspend()`,
> which should be fine here).
> 
> Moreover, when `devm_add_action_or_reset()` fails, it is due to a failed
> memory allocation and will thus return `-ENOMEM`. `dev_err_probe()`
> doesn't do anything when error is `-ENOMEM`. Therefore, the call to
> `dev_err_probe()` is useless. Note that `devm_pm_runtime_enable()` has a
> tail call to `devm_add_action_or_reset()` and thus returns that value.
> Therefore, replace `dev_err_probe()` with the returning value.
> 
> [...]

Applied, thanks!

[1/1] counter: ti-ecap-capture: Use devm_pm_runtime_enable()
      commit: 51548c36b37d0e84bd43a5f20bcbc36f70e61c5a

Best regards,
-- 
William Breathitt Gray <wbg@kernel.org>

      parent reply	other threads:[~2025-08-24  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-07 13:21 Waqar Hameed
2025-08-07 13:56 ` Andrew Davis
2025-08-24  8:06 ` William Breathitt Gray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175602272525.419332.11059830322724662200.b4-ty@kernel.org \
    --to=wbg@kernel.org \
    --cc=afd@ti.com \
    --cc=jpanis@baylibre.com \
    --cc=kernel@axis.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=vigneshr@ti.com \
    --cc=waqar.hameed@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®