[PATCH v4] platform/x86: portwell-ec: Add suspend/resume support for watchdog

[PATCH v4] platform/x86: portwell-ec: Add suspend/resume support for watchdog

[Yen-Chi Huang]

Portwell EC does not disable the watchdog during suspend. To avoid unwanted
resets, this patch adds suspend and resume callbacks (pwec_suspend() and
pwec_resume()) to the driver.

The watchdog is stopped in pwec_suspend() and restarted in pwec_resume() if
it was active before suspend.

Signed-off-by: Yen-Chi Huang <jesse.huang@portwell.com.tw>
---
V3->v4:
  - Switch from legacy .suspend/.resume callbacks to .pm with
    DEFINE_SIMPLE_DEV_PM_OPS and pm_sleep_ptr(), as suggested by Ilpo.
---
 drivers/platform/x86/portwell-ec.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/platform/x86/portwell-ec.c b/drivers/platform/x86/portwell-ec.c
index 322f296e9315..d2e91d5c3b3a 100644
--- a/drivers/platform/x86/portwell-ec.c
+++ b/drivers/platform/x86/portwell-ec.c
@@ -30,6 +30,7 @@
 #include <linux/ioport.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
+#include <linux/pm.h>
 #include <linux/sizes.h>
 #include <linux/string.h>
 #include <linux/watchdog.h>
@@ -246,9 +247,28 @@ static int pwec_probe(struct platform_device *pdev)
 	return 0;
 }
 
+static int pwec_suspend(struct device *dev)
+{
+	if (watchdog_active(&ec_wdt_dev))
+		return pwec_wdt_stop(&ec_wdt_dev);
+3
+	return 0;
+}
+
+static int pwec_resume(struct device *dev)
+{
+	if (watchdog_active(&ec_wdt_dev))
+		return pwec_wdt_start(&ec_wdt_dev);
+
+	return 0;
+}
+
+static DEFINE_SIMPLE_DEV_PM_OPS(pwec_dev_pm_ops, pwec_suspend, pwec_resume);
+
 static struct platform_driver pwec_driver = {
 	.driver = {
 		.name = "portwell-ec",
+		.pm = pm_sleep_ptr(&pwec_dev_pm_ops),
 	},
 	.probe = pwec_probe,
 };
-- 
2.34.1

Re: [PATCH v4] platform/x86: portwell-ec: Add suspend/resume support for watchdog

[Ilpo Järvinen]

On Thu, 28 Aug 2025 13:31:17 +0800, Yen-Chi Huang wrote:

> Portwell EC does not disable the watchdog during suspend. To avoid unwanted
> resets, this patch adds suspend and resume callbacks (pwec_suspend() and
> pwec_resume()) to the driver.
> 
> The watchdog is stopped in pwec_suspend() and restarted in pwec_resume() if
> it was active before suspend.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: portwell-ec: Add suspend/resume support for watchdog
      commit: 54cf44517550d53960d2fc5f85cf55d668c8889d

--
 i.