[PATCH] platform/x86/intel-uncore-freq: Fix warning in partitioned system

[PATCH] platform/x86/intel-uncore-freq: Fix warning in partitioned system

[Srinivas Pandruvada]

A partitioned system configured with only one package and one compute
die, warning will be generated for duplicate sysfs entry. This typically
occurs during the platform bring-up phase.

Partitioned systems expose dies, equivalent to TPMI compute domains,
through the CPUID. Each partitioned system must contains at least one
compute die per partition, resulting in a minimum of two dies per
package. Hence the function topology_max_dies_per_package() returns at
least two, and the condition "topology_max_dies_per_package() > 1"
prevents the creation of a root domain.

In this case topology_max_dies_per_package() will return 1 and root
domain will be created for partition 0 and a duplicate sysfs warning
for partition 1 as both partitions have same package ID.

To address this also check for non zero partition in addition to
topology_max_dies_per_package() > 1.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---

Non urgent as there is no such production system at this time.

 .../platform/x86/intel/uncore-frequency/uncore-frequency-tpmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-tpmi.c b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-tpmi.c
index 6df55c8e16b7..cb4905bad89b 100644
--- a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-tpmi.c
+++ b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-tpmi.c
@@ -633,7 +633,7 @@ static int uncore_probe(struct auxiliary_device *auxdev, const struct auxiliary_
 
 	auxiliary_set_drvdata(auxdev, tpmi_uncore);
 
-	if (topology_max_dies_per_package() > 1)
+	if (topology_max_dies_per_package() > 1 || plat_info->partition)
 		return 0;
 
 	tpmi_uncore->root_cluster.root_domain = true;
-- 
2.49.0

Re: [PATCH] platform/x86/intel-uncore-freq: Fix warning in partitioned system

[Ilpo Järvinen]

On Tue, 19 Aug 2025 14:10:34 -0700, Srinivas Pandruvada wrote:

> A partitioned system configured with only one package and one compute
> die, warning will be generated for duplicate sysfs entry. This typically
> occurs during the platform bring-up phase.
> 
> Partitioned systems expose dies, equivalent to TPMI compute domains,
> through the CPUID. Each partitioned system must contains at least one
> compute die per partition, resulting in a minimum of two dies per
> package. Hence the function topology_max_dies_per_package() returns at
> least two, and the condition "topology_max_dies_per_package() > 1"
> prevents the creation of a root domain.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86/intel-uncore-freq: Fix warning in partitioned system
      commit: 6d47b4f08436cb682fb2644e6265a3897fd42a77

--
 i.