[PATCH] PCI: tegra: fix devm_kcalloc argument order for port->phys allocation

[PATCH] PCI: tegra: fix devm_kcalloc argument order for port->phys allocation

[Alok Tiwari]

Fix incorrect argument order in devm_kcalloc() when allocating
port->phys, The original call used sizeof(phy) as the number of
elements and port->lanes as the element size, which is reversed.
While this happens to produce the correct total allocation size with
current pointer size and lane counts, the argument order is wrong.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
 drivers/pci/controller/pci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
index 467ddc701adc..bb88767a3797 100644
--- a/drivers/pci/controller/pci-tegra.c
+++ b/drivers/pci/controller/pci-tegra.c
@@ -1344,7 +1344,7 @@ static int tegra_pcie_port_get_phys(struct tegra_pcie_port *port)
 	unsigned int i;
 	int err;
 
-	port->phys = devm_kcalloc(dev, sizeof(phy), port->lanes, GFP_KERNEL);
+	port->phys = devm_kcalloc(dev, port->lanes, sizeof(phy), GFP_KERNEL);
 	if (!port->phys)
 		return -ENOMEM;
 
-- 
2.50.1

Re: [PATCH] PCI: tegra: fix devm_kcalloc argument order for port->phys allocation

[Manivannan Sadhasivam]

On Tue, Aug 19, 2025 at 08:04:08AM GMT, Alok Tiwari wrote:
> Fix incorrect argument order in devm_kcalloc() when allocating
> port->phys, The original call used sizeof(phy) as the number of
> elements and port->lanes as the element size, which is reversed.
> While this happens to produce the correct total allocation size with
> current pointer size and lane counts, the argument order is wrong.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>

Missing Fixes tag. I'll add it while applying.

- Mani

> ---
>  drivers/pci/controller/pci-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index 467ddc701adc..bb88767a3797 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -1344,7 +1344,7 @@ static int tegra_pcie_port_get_phys(struct tegra_pcie_port *port)
>  	unsigned int i;
>  	int err;
>  
> -	port->phys = devm_kcalloc(dev, sizeof(phy), port->lanes, GFP_KERNEL);
> +	port->phys = devm_kcalloc(dev, port->lanes, sizeof(phy), GFP_KERNEL);
>  	if (!port->phys)
>  		return -ENOMEM;
>  
> -- 
> 2.50.1
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH] PCI: tegra: fix devm_kcalloc argument order for port->phys allocation

[Manivannan Sadhasivam]

On Tue, 19 Aug 2025 08:04:08 -0700, Alok Tiwari wrote:
> Fix incorrect argument order in devm_kcalloc() when allocating
> port->phys, The original call used sizeof(phy) as the number of
> elements and port->lanes as the element size, which is reversed.
> While this happens to produce the correct total allocation size with
> current pointer size and lane counts, the argument order is wrong.
> 
> 
> [...]

Applied, thanks!

[1/1] PCI: tegra: fix devm_kcalloc argument order for port->phys allocation
      commit: b69f898bf94b374a97d367459ff2fb52b4ab8829

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>