* [PATCH] soundwire: bus: Drop dev_pm_domain_detach() call
@ 2025-08-27 10:15 Claudiu
2025-08-27 11:35 ` Ulf Hansson
2025-09-01 17:19 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Claudiu @ 2025-08-27 10:15 UTC (permalink / raw)
To: vkoul, yung-chuan.liao, pierre-louis.bossart, ulf.hansson, rafael
Cc: claudiu.beznea, linux-sound, linux-kernel, Claudiu Beznea
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Starting with commit f99508074e78 ("PM: domains: Detach on
device_unbind_cleanup()"), there is no longer a need to call
dev_pm_domain_detach() in the bus remove function. The
device_unbind_cleanup() function now handles this to avoid
invoking devres cleanup handlers while the PM domain is
powered off, which could otherwise lead to failures as
described in the above-mentioned commit.
Drop the explicit dev_pm_domain_detach() call and rely instead
on the flags passed to dev_pm_domain_attach() to power off the
domain.
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
---
drivers/soundwire/bus_type.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
index bc1e653080d9..91e70cb46fb5 100644
--- a/drivers/soundwire/bus_type.c
+++ b/drivers/soundwire/bus_type.c
@@ -114,7 +114,6 @@ static int sdw_drv_probe(struct device *dev)
ret = drv->probe(slave, id);
if (ret) {
- dev_pm_domain_detach(dev, false);
ida_free(&slave->bus->slave_ida, slave->index);
return ret;
}
@@ -180,8 +179,6 @@ static int sdw_drv_remove(struct device *dev)
if (drv->remove)
ret = drv->remove(slave);
- dev_pm_domain_detach(dev, false);
-
ida_free(&slave->bus->slave_ida, slave->index);
return ret;
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] soundwire: bus: Drop dev_pm_domain_detach() call
2025-08-27 10:15 [PATCH] soundwire: bus: Drop dev_pm_domain_detach() call Claudiu
@ 2025-08-27 11:35 ` Ulf Hansson
2025-09-01 17:19 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2025-08-27 11:35 UTC (permalink / raw)
To: Claudiu
Cc: vkoul, yung-chuan.liao, pierre-louis.bossart, rafael,
linux-sound, linux-kernel, Claudiu Beznea
On Wed, 27 Aug 2025 at 12:15, Claudiu <claudiu.beznea@tuxon.dev> wrote:
>
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Starting with commit f99508074e78 ("PM: domains: Detach on
> device_unbind_cleanup()"), there is no longer a need to call
> dev_pm_domain_detach() in the bus remove function. The
> device_unbind_cleanup() function now handles this to avoid
> invoking devres cleanup handlers while the PM domain is
> powered off, which could otherwise lead to failures as
> described in the above-mentioned commit.
>
> Drop the explicit dev_pm_domain_detach() call and rely instead
> on the flags passed to dev_pm_domain_attach() to power off the
> domain.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> drivers/soundwire/bus_type.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
> index bc1e653080d9..91e70cb46fb5 100644
> --- a/drivers/soundwire/bus_type.c
> +++ b/drivers/soundwire/bus_type.c
> @@ -114,7 +114,6 @@ static int sdw_drv_probe(struct device *dev)
>
> ret = drv->probe(slave, id);
> if (ret) {
> - dev_pm_domain_detach(dev, false);
> ida_free(&slave->bus->slave_ida, slave->index);
> return ret;
> }
> @@ -180,8 +179,6 @@ static int sdw_drv_remove(struct device *dev)
> if (drv->remove)
> ret = drv->remove(slave);
>
> - dev_pm_domain_detach(dev, false);
> -
> ida_free(&slave->bus->slave_ida, slave->index);
>
> return ret;
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] soundwire: bus: Drop dev_pm_domain_detach() call
2025-08-27 10:15 [PATCH] soundwire: bus: Drop dev_pm_domain_detach() call Claudiu
2025-08-27 11:35 ` Ulf Hansson
@ 2025-09-01 17:19 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2025-09-01 17:19 UTC (permalink / raw)
To: yung-chuan.liao, pierre-louis.bossart, ulf.hansson, rafael, Claudiu
Cc: linux-sound, linux-kernel, Claudiu Beznea
On Wed, 27 Aug 2025 13:15:06 +0300, Claudiu wrote:
> Starting with commit f99508074e78 ("PM: domains: Detach on
> device_unbind_cleanup()"), there is no longer a need to call
> dev_pm_domain_detach() in the bus remove function. The
> device_unbind_cleanup() function now handles this to avoid
> invoking devres cleanup handlers while the PM domain is
> powered off, which could otherwise lead to failures as
> described in the above-mentioned commit.
>
> [...]
Applied, thanks!
[1/1] soundwire: bus: Drop dev_pm_domain_detach() call
commit: 969bf687c12cd9f64ed9368f0c7429445de7c10b
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-01 17:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-27 10:15 [PATCH] soundwire: bus: Drop dev_pm_domain_detach() call Claudiu
2025-08-27 11:35 ` Ulf Hansson
2025-09-01 17:19 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®