* [PATCH] irqchip/renesas-rzg2l: Remove dev_err_probe() if error is -ENOMEM
@ 2025-08-21 9:38 Xichao Zhao
2025-09-03 12:14 ` [tip: irq/drivers] " tip-bot2 for Xichao Zhao
0 siblings, 1 reply; 2+ messages in thread
From: Xichao Zhao @ 2025-08-21 9:38 UTC (permalink / raw)
To: tglx; +Cc: linux-kernel, Xichao Zhao
The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
Therefore, remove the useless call to dev_err_probe(), and just
return the value instead.
Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
---
drivers/irqchip/irq-renesas-rzg2l.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c
index 360d88687e4f..2a54adeb4cc7 100644
--- a/drivers/irqchip/irq-renesas-rzg2l.c
+++ b/drivers/irqchip/irq-renesas-rzg2l.c
@@ -578,7 +578,7 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
&rzg2l_irqc_domain_ops, rzg2l_irqc_data);
if (!irq_domain) {
pm_runtime_put(dev);
- return dev_err_probe(dev, -ENOMEM, "failed to add irq domain\n");
+ return -ENOMEM;
}
register_syscore_ops(&rzg2l_irqc_syscore_ops);
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip: irq/drivers] irqchip/renesas-rzg2l: Remove dev_err_probe() if error is -ENOMEM
2025-08-21 9:38 [PATCH] irqchip/renesas-rzg2l: Remove dev_err_probe() if error is -ENOMEM Xichao Zhao
@ 2025-09-03 12:14 ` tip-bot2 for Xichao Zhao
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Xichao Zhao @ 2025-09-03 12:14 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Xichao Zhao, Thomas Gleixner, x86, linux-kernel
The following commit has been merged into the irq/drivers branch of tip:
Commit-ID: d36bf356068cdb5499b9bc458db9149c0fd938a2
Gitweb: https://git.kernel.org/tip/d36bf356068cdb5499b9bc458db9149c0fd938a2
Author: Xichao Zhao <zhao.xichao@vivo.com>
AuthorDate: Thu, 21 Aug 2025 17:38:45 +08:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 03 Sep 2025 14:12:55 +02:00
irqchip/renesas-rzg2l: Remove dev_err_probe() if error is -ENOMEM
The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
Therefore, remove the useless call to dev_err_probe(), and just return the
value instead.
Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250821093845.564496-1-zhao.xichao@vivo.com
---
drivers/irqchip/irq-renesas-rzg2l.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c
index 360d886..2a54ade 100644
--- a/drivers/irqchip/irq-renesas-rzg2l.c
+++ b/drivers/irqchip/irq-renesas-rzg2l.c
@@ -578,7 +578,7 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
&rzg2l_irqc_domain_ops, rzg2l_irqc_data);
if (!irq_domain) {
pm_runtime_put(dev);
- return dev_err_probe(dev, -ENOMEM, "failed to add irq domain\n");
+ return -ENOMEM;
}
register_syscore_ops(&rzg2l_irqc_syscore_ops);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-03 12:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-21 9:38 [PATCH] irqchip/renesas-rzg2l: Remove dev_err_probe() if error is -ENOMEM Xichao Zhao
2025-09-03 12:14 ` [tip: irq/drivers] " tip-bot2 for Xichao Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®