mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] slimbus: messaging: Remove redundant code
@ 2025-09-03  7:51 liuqiangneo
  2025-09-04  7:10 ` Srinivas Kandagatla
  0 siblings, 1 reply; 2+ messages in thread
From: liuqiangneo @ 2025-09-03  7:51 UTC (permalink / raw)
  To: srini, sdharia; +Cc: linux-sound, linux-kernel, Qiang Liu

From: Qiang Liu <liuqiang@kylinos.cn>

Assigning txn->comp to itself has no effect.

Signed-off-by: Qiang Liu <liuqiang@kylinos.cn>
---
 drivers/slimbus/messaging.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c
index 6f01d944f9c6..27ca16f00e77 100644
--- a/drivers/slimbus/messaging.c
+++ b/drivers/slimbus/messaging.c
@@ -143,8 +143,6 @@ int slim_do_transfer(struct slim_controller *ctrl, struct slim_msg_txn *txn)
 
 		if (!txn->msg->comp)
 			txn->comp = &done;
-		else
-			txn->comp = txn->comp;
 	}
 
 	ret = ctrl->xfer_msg(ctrl, txn);
-- 
2.43.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] slimbus: messaging: Remove redundant code
  2025-09-03  7:51 [PATCH] slimbus: messaging: Remove redundant code liuqiangneo
@ 2025-09-04  7:10 ` Srinivas Kandagatla
  0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2025-09-04  7:10 UTC (permalink / raw)
  To: sdharia, liuqiangneo; +Cc: linux-sound, linux-kernel, Qiang Liu


On Wed, 03 Sep 2025 15:51:55 +0800, liuqiangneo@163.com wrote:
> Assigning txn->comp to itself has no effect.
> 
> 

Applied, thanks!

[1/1] slimbus: messaging: Remove redundant code
      commit: 9ad5660840925cd6067b22f8e0bd1db87275cf58

Best regards,
-- 
Srinivas Kandagatla <srini@kernel.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-09-04  7:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-03  7:51 [PATCH] slimbus: messaging: Remove redundant code liuqiangneo
2025-09-04  7:10 ` Srinivas Kandagatla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®