* [PATCH v2] KVM: arm64: vgic: fix incorrect spinlock API usage
@ 2025-09-08 18:04 Alok Tiwari
2025-09-08 18:23 ` Oliver Upton
0 siblings, 1 reply; 2+ messages in thread
From: Alok Tiwari @ 2025-09-08 18:04 UTC (permalink / raw)
To: julien.thierry, marc.zyngier, jintack, christoffer.dall, maz,
oliver.upton, joey.gouly, suzuki.poulose, yuzenghui,
catalin.marinas, will, linux-arm-kernel, kvmarm
Cc: alok.a.tiwari, linux-kernel
The function vgic_flush_lr_state() is calling _raw_spin_unlock()
instead of the proper raw_spin_unlock().
_raw_spin_unlock() is an internal low-level API and should not
be used directly; using raw_spin_unlock() ensures proper locking
semantics in the vgic code.
Fixes: 8fa3adb8c6be ("KVM: arm/arm64: vgic: Make vgic_irq->irq_lock a raw_spinlock")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Acked-by: Marc Zyngier <maz@kernel.org>
---
v1 -> v2
Dropped extra paragraph and added Acked-by Marc
---
arch/arm64/kvm/vgic/vgic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kvm/vgic/vgic.c b/arch/arm64/kvm/vgic/vgic.c
index f5148b38120a..c74d6120a12c 100644
--- a/arch/arm64/kvm/vgic/vgic.c
+++ b/arch/arm64/kvm/vgic/vgic.c
@@ -818,7 +818,7 @@ static void vgic_flush_lr_state(struct kvm_vcpu *vcpu)
* the AP list has been sorted already.
*/
if (multi_sgi && irq->priority > prio) {
- _raw_spin_unlock(&irq->irq_lock);
+ raw_spin_unlock(&irq->irq_lock);
break;
}
--
2.50.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] KVM: arm64: vgic: fix incorrect spinlock API usage
2025-09-08 18:04 [PATCH v2] KVM: arm64: vgic: fix incorrect spinlock API usage Alok Tiwari
@ 2025-09-08 18:23 ` Oliver Upton
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Upton @ 2025-09-08 18:23 UTC (permalink / raw)
To: jintack, christoffer.dall, maz, joey.gouly, suzuki.poulose,
yuzenghui, catalin.marinas, will, linux-arm-kernel, kvmarm,
Julien Thierry, Alok Tiwari
Cc: Oliver Upton, linux-kernel
On Mon, 08 Sep 2025 11:04:11 -0700, Alok Tiwari wrote:
> The function vgic_flush_lr_state() is calling _raw_spin_unlock()
> instead of the proper raw_spin_unlock().
>
> _raw_spin_unlock() is an internal low-level API and should not
> be used directly; using raw_spin_unlock() ensures proper locking
> semantics in the vgic code.
>
> [...]
Applied to fixes, thanks!
[1/1] KVM: arm64: vgic: fix incorrect spinlock API usage
https://git.kernel.org/kvmarm/kvmarm/c/2d0478279fc7
--
Best,
Oliver
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-08 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-08 18:04 [PATCH v2] KVM: arm64: vgic: fix incorrect spinlock API usage Alok Tiwari
2025-09-08 18:23 ` Oliver Upton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®