From: "tip-bot2 for Thomas Weißschuh" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: thomas.weissschuh@linutronix.de,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/vdso] selftests: vDSO: vdso_test_abi: Use explicit indices for name array
Date: Tue, 09 Sep 2025 09:02:36 -0000 [thread overview]
Message-ID: <175740855657.1920.16199757066882049899.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250812-vdso-tests-fixes-v2-5-90f499dd35f8@linutronix.de>
The following commit has been merged into the timers/vdso branch of tip:
Commit-ID: 74b408ff06c39238edd66350cd0d4057787fc853
Gitweb: https://git.kernel.org/tip/74b408ff06c39238edd66350cd0d4057787fc853
Author: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
AuthorDate: Tue, 12 Aug 2025 07:39:06 +02:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 09 Sep 2025 10:57:39 +02:00
selftests: vDSO: vdso_test_abi: Use explicit indices for name array
The array relies on the numeric values of the clock IDs.
When reading the code it is not obvious that the order is correct.
Make the code easier to read by using explicit indices.
While at it make the array static.
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250812-vdso-tests-fixes-v2-5-90f499dd35f8@linutronix.de
---
tools/testing/selftests/vDSO/vdso_test_abi.c | 26 +++++++++----------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/tools/testing/selftests/vDSO/vdso_test_abi.c b/tools/testing/selftests/vDSO/vdso_test_abi.c
index d236dd8..a9a65f0 100644
--- a/tools/testing/selftests/vDSO/vdso_test_abi.c
+++ b/tools/testing/selftests/vDSO/vdso_test_abi.c
@@ -31,19 +31,19 @@ typedef long (*vdso_clock_gettime_t)(clockid_t clk_id, struct timespec *ts);
typedef long (*vdso_clock_getres_t)(clockid_t clk_id, struct timespec *ts);
typedef time_t (*vdso_time_t)(time_t *t);
-const char *vdso_clock_name[12] = {
- "CLOCK_REALTIME",
- "CLOCK_MONOTONIC",
- "CLOCK_PROCESS_CPUTIME_ID",
- "CLOCK_THREAD_CPUTIME_ID",
- "CLOCK_MONOTONIC_RAW",
- "CLOCK_REALTIME_COARSE",
- "CLOCK_MONOTONIC_COARSE",
- "CLOCK_BOOTTIME",
- "CLOCK_REALTIME_ALARM",
- "CLOCK_BOOTTIME_ALARM",
- "CLOCK_SGI_CYCLE",
- "CLOCK_TAI",
+static const char * const vdso_clock_name[] = {
+ [CLOCK_REALTIME] = "CLOCK_REALTIME",
+ [CLOCK_MONOTONIC] = "CLOCK_MONOTONIC",
+ [CLOCK_PROCESS_CPUTIME_ID] = "CLOCK_PROCESS_CPUTIME_ID",
+ [CLOCK_THREAD_CPUTIME_ID] = "CLOCK_THREAD_CPUTIME_ID",
+ [CLOCK_MONOTONIC_RAW] = "CLOCK_MONOTONIC_RAW",
+ [CLOCK_REALTIME_COARSE] = "CLOCK_REALTIME_COARSE",
+ [CLOCK_MONOTONIC_COARSE] = "CLOCK_MONOTONIC_COARSE",
+ [CLOCK_BOOTTIME] = "CLOCK_BOOTTIME",
+ [CLOCK_REALTIME_ALARM] = "CLOCK_REALTIME_ALARM",
+ [CLOCK_BOOTTIME_ALARM] = "CLOCK_BOOTTIME_ALARM",
+ [10 /* CLOCK_SGI_CYCLE */] = "CLOCK_SGI_CYCLE",
+ [CLOCK_TAI] = "CLOCK_TAI",
};
static void vdso_test_gettimeofday(void)
next prev parent reply other threads:[~2025-09-09 9:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 5:39 [PATCH v2 0/8] selftests: vDSO: Clean up vdso_test_abi and drop vdso_test_clock_getres Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 1/8] selftests: vDSO: fix -Wunitialized in powerpc VDSO_CALL() wrapper Thomas Weißschuh
2025-08-12 6:05 ` Christophe Leroy
2025-09-09 9:02 ` [tip: timers/vdso] selftests: vDSO: Fix " tip-bot2 for Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 2/8] selftests: vDSO: vdso_test_abi: Correctly skip whole test with missing vDSO Thomas Weißschuh
2025-09-09 9:02 ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 3/8] selftests: vDSO: vdso_test_abi: Use ksft_finished() Thomas Weißschuh
2025-09-09 9:02 ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 4/8] selftests: vDSO: vdso_test_abi: Drop clock availability tests Thomas Weißschuh
2025-09-09 9:02 ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 5/8] selftests: vDSO: vdso_test_abi: Use explicit indices for name array Thomas Weißschuh
2025-09-09 9:02 ` tip-bot2 for Thomas Weißschuh [this message]
2025-08-12 5:39 ` [PATCH v2 6/8] selftests: vDSO: vdso_test_abi: Test CPUTIME clocks Thomas Weißschuh
2025-09-09 9:02 ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 7/8] selftests: vDSO: vdso_test_abi: Add tests for clock_gettime64() Thomas Weißschuh
2025-09-09 9:02 ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 8/8] selftests: vDSO: Drop vdso_test_clock_getres Thomas Weißschuh
2025-09-09 9:02 ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175740855657.1920.16199757066882049899.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.weissschuh@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®