From: "tip-bot2 for Thomas Weißschuh" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: thomas.weissschuh@linutronix.de,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/vdso] selftests: vDSO: vdso_test_abi: Correctly skip whole test with missing vDSO
Date: Tue, 09 Sep 2025 09:02:40 -0000 [thread overview]
Message-ID: <175740856023.1920.7634485400538853948.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250812-vdso-tests-fixes-v2-2-90f499dd35f8@linutronix.de>
The following commit has been merged into the timers/vdso branch of tip:
Commit-ID: 4b59a9f7628fd82b24f2148f62cf327a84d26555
Gitweb: https://git.kernel.org/tip/4b59a9f7628fd82b24f2148f62cf327a84d26555
Author: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
AuthorDate: Tue, 12 Aug 2025 07:39:03 +02:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 09 Sep 2025 10:57:38 +02:00
selftests: vDSO: vdso_test_abi: Correctly skip whole test with missing vDSO
If AT_SYSINFO_EHDR is missing the whole test needs to be skipped.
Currently this results in the following output:
TAP version 13
1..16
# AT_SYSINFO_EHDR is not present!
This output is incorrect, as "1..16" still requires the subtest lines to
be printed, which isn't done however.
Switch to the correct skipping functions, so the output now correctly
indicates that no subtests are being run:
TAP version 13
1..0 # SKIP AT_SYSINFO_EHDR is not present!
Fixes: 693f5ca08ca0 ("kselftest: Extend vDSO selftest")
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250812-vdso-tests-fixes-v2-2-90f499dd35f8@linutronix.de
---
tools/testing/selftests/vDSO/vdso_test_abi.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/vDSO/vdso_test_abi.c b/tools/testing/selftests/vDSO/vdso_test_abi.c
index a54424e..67cbfc5 100644
--- a/tools/testing/selftests/vDSO/vdso_test_abi.c
+++ b/tools/testing/selftests/vDSO/vdso_test_abi.c
@@ -182,12 +182,11 @@ int main(int argc, char **argv)
unsigned long sysinfo_ehdr = getauxval(AT_SYSINFO_EHDR);
ksft_print_header();
- ksft_set_plan(VDSO_TEST_PLAN);
- if (!sysinfo_ehdr) {
- ksft_print_msg("AT_SYSINFO_EHDR is not present!\n");
- return KSFT_SKIP;
- }
+ if (!sysinfo_ehdr)
+ ksft_exit_skip("AT_SYSINFO_EHDR is not present!\n");
+
+ ksft_set_plan(VDSO_TEST_PLAN);
version = versions[VDSO_VERSION];
name = (const char **)&names[VDSO_NAMES];
next prev parent reply other threads:[~2025-09-09 9:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 5:39 [PATCH v2 0/8] selftests: vDSO: Clean up vdso_test_abi and drop vdso_test_clock_getres Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 1/8] selftests: vDSO: fix -Wunitialized in powerpc VDSO_CALL() wrapper Thomas Weißschuh
2025-08-12 6:05 ` Christophe Leroy
2025-09-09 9:02 ` [tip: timers/vdso] selftests: vDSO: Fix " tip-bot2 for Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 2/8] selftests: vDSO: vdso_test_abi: Correctly skip whole test with missing vDSO Thomas Weißschuh
2025-09-09 9:02 ` tip-bot2 for Thomas Weißschuh [this message]
2025-08-12 5:39 ` [PATCH v2 3/8] selftests: vDSO: vdso_test_abi: Use ksft_finished() Thomas Weißschuh
2025-09-09 9:02 ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 4/8] selftests: vDSO: vdso_test_abi: Drop clock availability tests Thomas Weißschuh
2025-09-09 9:02 ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 5/8] selftests: vDSO: vdso_test_abi: Use explicit indices for name array Thomas Weißschuh
2025-09-09 9:02 ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 6/8] selftests: vDSO: vdso_test_abi: Test CPUTIME clocks Thomas Weißschuh
2025-09-09 9:02 ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 7/8] selftests: vDSO: vdso_test_abi: Add tests for clock_gettime64() Thomas Weißschuh
2025-09-09 9:02 ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-08-12 5:39 ` [PATCH v2 8/8] selftests: vDSO: Drop vdso_test_clock_getres Thomas Weißschuh
2025-09-09 9:02 ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175740856023.1920.7634485400538853948.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.weissschuh@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®