* [PATCH net] Revert "net/mlx5e: Update and set Xon/Xoff upon port speed set"
@ 2025-09-17 13:48 Tariq Toukan
2025-09-18 15:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Tariq Toukan @ 2025-09-17 13:48 UTC (permalink / raw)
To: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andrew Lunn, David S. Miller
Cc: Saeed Mahameed, Leon Romanovsky, Tariq Toukan, Mark Bloch,
netdev, linux-rdma, linux-kernel, Gal Pressman, Alexei Lazar,
Daniel Zahka
This reverts commit d24341740fe48add8a227a753e68b6eedf4b385a.
It caused a degradation, reported by Jakub here:
https://lore.kernel.org/all/20250910170011.70528106@kernel.org/
Fixes: d24341740fe4 ("net/mlx5e: Update and set Xon/Xoff upon port speed set")
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index e680673ffb72..15eded36b872 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -139,8 +139,6 @@ void mlx5e_update_carrier(struct mlx5e_priv *priv)
if (up) {
netdev_info(priv->netdev, "Link up\n");
netif_carrier_on(priv->netdev);
- mlx5e_port_manual_buffer_config(priv, 0, priv->netdev->mtu,
- NULL, NULL, NULL);
} else {
netdev_info(priv->netdev, "Link down\n");
netif_carrier_off(priv->netdev);
base-commit: 8c4748539985489b59a00b4c2ae919253b3d2762
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net] Revert "net/mlx5e: Update and set Xon/Xoff upon port speed set"
2025-09-17 13:48 [PATCH net] Revert "net/mlx5e: Update and set Xon/Xoff upon port speed set" Tariq Toukan
@ 2025-09-18 15:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-09-18 15:00 UTC (permalink / raw)
To: Tariq Toukan
Cc: edumazet, kuba, pabeni, andrew+netdev, davem, saeedm, leon,
mbloch, netdev, linux-rdma, linux-kernel, gal, alazar,
daniel.zahka
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 17 Sep 2025 16:48:54 +0300 you wrote:
> This reverts commit d24341740fe48add8a227a753e68b6eedf4b385a.
> It caused a degradation, reported by Jakub here:
> https://lore.kernel.org/all/20250910170011.70528106@kernel.org/
>
> Fixes: d24341740fe4 ("net/mlx5e: Update and set Xon/Xoff upon port speed set")
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
>
> [...]
Here is the summary with links:
- [net] Revert "net/mlx5e: Update and set Xon/Xoff upon port speed set"
https://git.kernel.org/netdev/net/c/3fbfe251cc9f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-18 15:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-17 13:48 [PATCH net] Revert "net/mlx5e: Update and set Xon/Xoff upon port speed set" Tariq Toukan
2025-09-18 15:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®