mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Robert Marko <robert.marko@sartura.hr>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
	krzk+dt@kernel.org,  lars.povlsen@microchip.com,
	daniel.machon@microchip.com,  benjamin.ryzman@canonical.com,
	linux-kernel@vger.kernel.org,  steen.hegelund@microchip.com,
	p.zabel@pengutronix.de,  luka.perkov@sartura.hr
Subject: Re: [PATCH v2 1/2] dt-bindings: reset: microchip: Add LAN969x support
Date: Fri, 19 Sep 2025 04:53:56 -0500	[thread overview]
Message-ID: <175827563611.434564.16492543952928423652.robh@kernel.org> (raw)
In-Reply-To: <20250919082919.19864-1-robert.marko@sartura.hr>


On Fri, 19 Sep 2025 10:28:38 +0200, Robert Marko wrote:
> LAN969x also uses the Microchip reset driver, it reuses the LAN966x
> support so use a fallback compatible.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> Changes in v2:
> * Use a fallback compatible
> 
>  .../devicetree/bindings/reset/microchip,rst.yaml      | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/reset/microchip,rst.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/reset/microchip,rst.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/reset/microchip,rst.yaml:29:11: [warning] wrong indentation: expected 12 but found 10 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250919082919.19864-1-robert.marko@sartura.hr

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2025-09-19  9:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19  8:28 Robert Marko
2025-09-19  8:28 ` [PATCH v2 2/2] reset: sparx5: add " Robert Marko
2025-09-19  9:53 ` Rob Herring (Arm) [this message]
2025-09-19 10:59   ` [PATCH v2 1/2] dt-bindings: reset: microchip: Add " Robert Marko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175827563611.434564.16492543952928423652.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=benjamin.ryzman@canonical.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.machon@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars.povlsen@microchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luka.perkov@sartura.hr \
    --cc=p.zabel@pengutronix.de \
    --cc=robert.marko@sartura.hr \
    --cc=steen.hegelund@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®