mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 1/2] dt-bindings: reset: microchip: Add LAN969x support
@ 2025-09-19  8:28 Robert Marko
  2025-09-19  8:28 ` [PATCH v2 2/2] reset: sparx5: add " Robert Marko
  2025-09-19  9:53 ` [PATCH v2 1/2] dt-bindings: reset: microchip: Add " Rob Herring (Arm)
  0 siblings, 2 replies; 4+ messages in thread
From: Robert Marko @ 2025-09-19  8:28 UTC (permalink / raw)
  To: p.zabel, robh, krzk+dt, conor+dt, steen.hegelund, lars.povlsen,
	devicetree, linux-kernel, daniel.machon
  Cc: luka.perkov, benjamin.ryzman, Robert Marko

LAN969x also uses the Microchip reset driver, it reuses the LAN966x
support so use a fallback compatible.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
Changes in v2:
* Use a fallback compatible

 .../devicetree/bindings/reset/microchip,rst.yaml      | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
index f2da0693b05a..12a3b04fc8ed 100644
--- a/Documentation/devicetree/bindings/reset/microchip,rst.yaml
+++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
@@ -20,9 +20,14 @@ properties:
     pattern: "^reset-controller@[0-9a-f]+$"
 
   compatible:
-    enum:
-      - microchip,sparx5-switch-reset
-      - microchip,lan966x-switch-reset
+    oneOf:
+      - enum:
+        - microchip,sparx5-switch-reset
+        - microchip,lan966x-switch-reset
+      - items:
+        - enum:
+          - microchip,lan9691-switch-reset
+        - const: microchip,lan966x-switch-reset
 
   reg:
     items:
-- 
2.51.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] reset: sparx5: add LAN969x support
  2025-09-19  8:28 [PATCH v2 1/2] dt-bindings: reset: microchip: Add LAN969x support Robert Marko
@ 2025-09-19  8:28 ` Robert Marko
  2025-09-19  9:53 ` [PATCH v2 1/2] dt-bindings: reset: microchip: Add " Rob Herring (Arm)
  1 sibling, 0 replies; 4+ messages in thread
From: Robert Marko @ 2025-09-19  8:28 UTC (permalink / raw)
  To: p.zabel, robh, krzk+dt, conor+dt, steen.hegelund, lars.povlsen,
	devicetree, linux-kernel, daniel.machon
  Cc: luka.perkov, benjamin.ryzman, Robert Marko

LAN969x uses the same reset configuration as LAN966x, but we need to
allow compiling it when ARCH_LAN969X is selected.

A fallback compatible to LAN966x will be used.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
Changes in v2:
* Drop driver changes as we are now just using fallback compatible
 drivers/reset/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 78b7078478d4..59245cd0c393 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -170,7 +170,7 @@ config RESET_LPC18XX
 
 config RESET_MCHP_SPARX5
 	tristate "Microchip Sparx5 reset driver"
-	depends on ARCH_SPARX5 || SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST
+	depends on ARCH_SPARX5 || ARCH_LAN969X || SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST
 	default y if SPARX5_SWITCH
 	select MFD_SYSCON
 	help
-- 
2.51.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: reset: microchip: Add LAN969x support
  2025-09-19  8:28 [PATCH v2 1/2] dt-bindings: reset: microchip: Add LAN969x support Robert Marko
  2025-09-19  8:28 ` [PATCH v2 2/2] reset: sparx5: add " Robert Marko
@ 2025-09-19  9:53 ` Rob Herring (Arm)
  2025-09-19 10:59   ` Robert Marko
  1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-09-19  9:53 UTC (permalink / raw)
  To: Robert Marko
  Cc: devicetree, conor+dt, krzk+dt, lars.povlsen, daniel.machon,
	benjamin.ryzman, linux-kernel, steen.hegelund, p.zabel,
	luka.perkov


On Fri, 19 Sep 2025 10:28:38 +0200, Robert Marko wrote:
> LAN969x also uses the Microchip reset driver, it reuses the LAN966x
> support so use a fallback compatible.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> Changes in v2:
> * Use a fallback compatible
> 
>  .../devicetree/bindings/reset/microchip,rst.yaml      | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/reset/microchip,rst.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/reset/microchip,rst.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/reset/microchip,rst.yaml:29:11: [warning] wrong indentation: expected 12 but found 10 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250919082919.19864-1-robert.marko@sartura.hr

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: reset: microchip: Add LAN969x support
  2025-09-19  9:53 ` [PATCH v2 1/2] dt-bindings: reset: microchip: Add " Rob Herring (Arm)
@ 2025-09-19 10:59   ` Robert Marko
  0 siblings, 0 replies; 4+ messages in thread
From: Robert Marko @ 2025-09-19 10:59 UTC (permalink / raw)
  To: Rob Herring (Arm)
  Cc: devicetree, conor+dt, krzk+dt, lars.povlsen, daniel.machon,
	benjamin.ryzman, linux-kernel, steen.hegelund, p.zabel,
	luka.perkov

On Fri, Sep 19, 2025 at 11:53 AM Rob Herring (Arm) <robh@kernel.org> wrote:
>
>
> On Fri, 19 Sep 2025 10:28:38 +0200, Robert Marko wrote:
> > LAN969x also uses the Microchip reset driver, it reuses the LAN966x
> > support so use a fallback compatible.
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > ---
> > Changes in v2:
> > * Use a fallback compatible
> >
> >  .../devicetree/bindings/reset/microchip,rst.yaml      | 11 ++++++++---
> >  1 file changed, 8 insertions(+), 3 deletions(-)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/reset/microchip,rst.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> ./Documentation/devicetree/bindings/reset/microchip,rst.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> ./Documentation/devicetree/bindings/reset/microchip,rst.yaml:29:11: [warning] wrong indentation: expected 12 but found 10 (indentation)

Will fixup in v3.

Regards,
Robert
>
> dtschema/dtc warnings/errors:
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250919082919.19864-1-robert.marko@sartura.hr
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>


-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura d.d.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-09-19 10:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-19  8:28 [PATCH v2 1/2] dt-bindings: reset: microchip: Add LAN969x support Robert Marko
2025-09-19  8:28 ` [PATCH v2 2/2] reset: sparx5: add " Robert Marko
2025-09-19  9:53 ` [PATCH v2 1/2] dt-bindings: reset: microchip: Add " Rob Herring (Arm)
2025-09-19 10:59   ` Robert Marko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®