* [PATCH net-next V3] net: xilinx: axienet: Fix kernel-doc warnings for missing return descriptions
@ 2025-09-19 10:37 Suraj Gupta
2025-09-22 23:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Suraj Gupta @ 2025-09-19 10:37 UTC (permalink / raw)
To: andrew+netdev, davem, edumazet, kuba, pabeni, michal.simek,
sean.anderson, radhey.shyam.pandey, horms
Cc: netdev, linux-arm-kernel, linux-kernel, harini.katakam
Add missing "Return:" sections to kernel-doc comments for four functions:
- axienet_calc_cr()
- axienet_device_reset()
- axienet_free_tx_chain()
- axienet_dim_coalesce_count_rx()
Also standardize the return documentation format by replacing inline
"Returns" text with proper "Return:" tags as per kernel documentation
guidelines.
Fixes below kernel-doc warnings:
- Warning: No description found for return value of 'axienet_calc_cr'
- Warning: No description found for return value of 'axienet_device_reset'
- Warning: No description found for return value of 'axienet_free_tx_chain'
- Warning: No description found for return value of
'axienet_dim_coalesce_count_rx'
Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
---
V2: https://lore.kernel.org/all/20250917124948.226536-1-suraj.gupta2@amd.com/
Changes in V3:
Fix other similiar kernel-doc warnings.
Changes in V2:
Drop mutex documentation patch.
Add Reviewed-by tags.
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index ec6d47dc984a..284031fb2e2c 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -238,6 +238,8 @@ static u64 axienet_dma_rate(struct axienet_local *lp)
*
* Calculate a control register value based on the coalescing settings. The
* run/stop bit is not set.
+ *
+ * Return: Control register value with coalescing settings configured.
*/
static u32 axienet_calc_cr(struct axienet_local *lp, u32 count, u32 usec)
{
@@ -702,7 +704,8 @@ static void axienet_dma_stop(struct axienet_local *lp)
* are connected to Axi Ethernet reset lines, this in turn resets the Axi
* Ethernet core. No separate hardware reset is done for the Axi Ethernet
* core.
- * Returns 0 on success or a negative error number otherwise.
+ *
+ * Return: 0 on success or a negative error number otherwise.
*/
static int axienet_device_reset(struct net_device *ndev)
{
@@ -773,7 +776,8 @@ static int axienet_device_reset(struct net_device *ndev)
*
* Would either be called after a successful transmit operation, or after
* there was an error when setting up the chain.
- * Returns the number of packets handled.
+ *
+ * Return: The number of packets handled.
*/
static int axienet_free_tx_chain(struct axienet_local *lp, u32 first_bd,
int nr_bds, bool force, u32 *sizep, int budget)
@@ -2112,6 +2116,8 @@ static void axienet_update_coalesce_rx(struct axienet_local *lp, u32 cr,
/**
* axienet_dim_coalesce_count_rx() - RX coalesce count for DIM
* @lp: Device private data
+ *
+ * Return: RX coalescing frame count value for DIM.
*/
static u32 axienet_dim_coalesce_count_rx(struct axienet_local *lp)
{
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net-next V3] net: xilinx: axienet: Fix kernel-doc warnings for missing return descriptions
2025-09-19 10:37 [PATCH net-next V3] net: xilinx: axienet: Fix kernel-doc warnings for missing return descriptions Suraj Gupta
@ 2025-09-22 23:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-09-22 23:40 UTC (permalink / raw)
To: Suraj Gupta
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, michal.simek,
sean.anderson, radhey.shyam.pandey, horms, netdev,
linux-arm-kernel, linux-kernel, harini.katakam
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 19 Sep 2025 16:07:54 +0530 you wrote:
> Add missing "Return:" sections to kernel-doc comments for four functions:
> - axienet_calc_cr()
> - axienet_device_reset()
> - axienet_free_tx_chain()
> - axienet_dim_coalesce_count_rx()
>
> Also standardize the return documentation format by replacing inline
> "Returns" text with proper "Return:" tags as per kernel documentation
> guidelines.
>
> [...]
Here is the summary with links:
- [net-next,V3] net: xilinx: axienet: Fix kernel-doc warnings for missing return descriptions
https://git.kernel.org/netdev/net-next/c/312e6a58f764
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-22 23:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-19 10:37 [PATCH net-next V3] net: xilinx: axienet: Fix kernel-doc warnings for missing return descriptions Suraj Gupta
2025-09-22 23:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®