* [PATCH] f2fs: add sanity check on ei.len in __update_extent_tree_range()
@ 2025-09-16 8:52 Chao Yu
2025-09-17 16:40 ` Jaegeuk Kim
2025-09-29 22:30 ` [f2fs-dev] " patchwork-bot+f2fs
0 siblings, 2 replies; 4+ messages in thread
From: Chao Yu @ 2025-09-16 8:52 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, Chao Yu, wangzijie
Add a sanity check in __update_extent_tree_range() to detect any
zero-sized extent update.
Signed-off-by: wangzijie <wangzijie1@honor.com>
Signed-off-by: Chao Yu <chao@kernel.org>
---
fs/f2fs/extent_cache.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
index 199c1e7a83ef..3070d1cb0676 100644
--- a/fs/f2fs/extent_cache.c
+++ b/fs/f2fs/extent_cache.c
@@ -664,6 +664,15 @@ static void __update_extent_tree_range(struct inode *inode,
if (!et)
return;
+ if (unlikely(len == 0)) {
+ f2fs_err_ratelimited(sbi, "%s: extent len is zero, type: %d, "
+ "extent [%u, %u, %u], age [%llu, %llu]",
+ __func__, type, tei->fofs, tei->blk, tei->len,
+ tei->age, tei->last_blocks);
+ f2fs_bug_on(sbi, 1);
+ return;
+ }
+
if (type == EX_READ)
trace_f2fs_update_read_extent_tree_range(inode, fofs, len,
tei->blk, 0);
--
2.49.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] f2fs: add sanity check on ei.len in __update_extent_tree_range()
2025-09-16 8:52 [PATCH] f2fs: add sanity check on ei.len in __update_extent_tree_range() Chao Yu
@ 2025-09-17 16:40 ` Jaegeuk Kim
2025-09-18 2:15 ` Chao Yu
2025-09-29 22:30 ` [f2fs-dev] " patchwork-bot+f2fs
1 sibling, 1 reply; 4+ messages in thread
From: Jaegeuk Kim @ 2025-09-17 16:40 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-f2fs-devel, linux-kernel, wangzijie
Do we need this?
On 09/16, Chao Yu wrote:
> Add a sanity check in __update_extent_tree_range() to detect any
> zero-sized extent update.
>
> Signed-off-by: wangzijie <wangzijie1@honor.com>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> fs/f2fs/extent_cache.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
> index 199c1e7a83ef..3070d1cb0676 100644
> --- a/fs/f2fs/extent_cache.c
> +++ b/fs/f2fs/extent_cache.c
> @@ -664,6 +664,15 @@ static void __update_extent_tree_range(struct inode *inode,
> if (!et)
> return;
>
> + if (unlikely(len == 0)) {
> + f2fs_err_ratelimited(sbi, "%s: extent len is zero, type: %d, "
> + "extent [%u, %u, %u], age [%llu, %llu]",
> + __func__, type, tei->fofs, tei->blk, tei->len,
> + tei->age, tei->last_blocks);
> + f2fs_bug_on(sbi, 1);
> + return;
> + }
> +
> if (type == EX_READ)
> trace_f2fs_update_read_extent_tree_range(inode, fofs, len,
> tei->blk, 0);
> --
> 2.49.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] f2fs: add sanity check on ei.len in __update_extent_tree_range()
2025-09-17 16:40 ` Jaegeuk Kim
@ 2025-09-18 2:15 ` Chao Yu
0 siblings, 0 replies; 4+ messages in thread
From: Chao Yu @ 2025-09-18 2:15 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: chao, linux-f2fs-devel, linux-kernel, wangzijie
On 9/18/25 00:40, Jaegeuk Kim wrote:
> Do we need this?
I think so, it can provide a way to dump more information to troubleshoot
in which function we're trying to update w/ a zero-sized extent.
Thanks,
>
> On 09/16, Chao Yu wrote:
>> Add a sanity check in __update_extent_tree_range() to detect any
>> zero-sized extent update.
>>
>> Signed-off-by: wangzijie <wangzijie1@honor.com>
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>> fs/f2fs/extent_cache.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
>> index 199c1e7a83ef..3070d1cb0676 100644
>> --- a/fs/f2fs/extent_cache.c
>> +++ b/fs/f2fs/extent_cache.c
>> @@ -664,6 +664,15 @@ static void __update_extent_tree_range(struct inode *inode,
>> if (!et)
>> return;
>>
>> + if (unlikely(len == 0)) {
>> + f2fs_err_ratelimited(sbi, "%s: extent len is zero, type: %d, "
>> + "extent [%u, %u, %u], age [%llu, %llu]",
>> + __func__, type, tei->fofs, tei->blk, tei->len,
>> + tei->age, tei->last_blocks);
>> + f2fs_bug_on(sbi, 1);
>> + return;
>> + }
>> +
>> if (type == EX_READ)
>> trace_f2fs_update_read_extent_tree_range(inode, fofs, len,
>> tei->blk, 0);
>> --
>> 2.49.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: add sanity check on ei.len in __update_extent_tree_range()
2025-09-16 8:52 [PATCH] f2fs: add sanity check on ei.len in __update_extent_tree_range() Chao Yu
2025-09-17 16:40 ` Jaegeuk Kim
@ 2025-09-29 22:30 ` patchwork-bot+f2fs
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+f2fs @ 2025-09-29 22:30 UTC (permalink / raw)
To: Chao Yu; +Cc: jaegeuk, wangzijie1, linux-kernel, linux-f2fs-devel
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:
On Tue, 16 Sep 2025 16:52:43 +0800 you wrote:
> Add a sanity check in __update_extent_tree_range() to detect any
> zero-sized extent update.
>
> Signed-off-by: wangzijie <wangzijie1@honor.com>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> fs/f2fs/extent_cache.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Here is the summary with links:
- [f2fs-dev] f2fs: add sanity check on ei.len in __update_extent_tree_range()
https://git.kernel.org/jaegeuk/f2fs/c/45b70947a425
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-29 22:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-16 8:52 [PATCH] f2fs: add sanity check on ei.len in __update_extent_tree_range() Chao Yu
2025-09-17 16:40 ` Jaegeuk Kim
2025-09-18 2:15 ` Chao Yu
2025-09-29 22:30 ` [f2fs-dev] " patchwork-bot+f2fs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome