mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: hehuan1@eswincomputing.com
Cc: linmin@eswincomputing.com, ulf.hansson@linaro.org,
	 lizhi2@eswincomputing.com, devicetree@vger.kernel.org,
	 pinkesh.vaghela@einfochips.com, weishangjuan@eswincomputing.com,
	 jszhang@kernel.org, linux-mmc@vger.kernel.org,
	 zhangsenchuan@eswincomputing.com, conor+dt@kernel.org,
	 p.zabel@pengutronix.de, caohang@eswincomputing.com,
	 dongxuyang@eswincomputing.com, luyulin@eswincomputing.com,
	 ningyu@eswincomputing.com,
	Conor Dooley <conor.dooley@microchip.com>,
	 adrian.hunter@intel.com, linux-kernel@vger.kernel.org,
	 xuxiang@eswincomputing.com, krzk+dt@kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700
Date: Mon, 20 Oct 2025 06:35:16 -0500	[thread overview]
Message-ID: <176096011380.22917.1988679321096076522.robh@kernel.org> (raw)
In-Reply-To: <20251019115238.320-1-hehuan1@eswincomputing.com>


On Sun, 19 Oct 2025 19:52:38 +0800, hehuan1@eswincomputing.com wrote:
> From: Huan He <hehuan1@eswincomputing.com>
> 
> EIC7700 use Synopsys dwcmshc IP for SD/eMMC controllers.
> Add Eswin EIC7700 support in sdhci-of-dwcmshc.yaml.
> 
> Signed-off-by: Huan He <hehuan1@eswincomputing.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  .../bindings/mmc/snps,dwcmshc-sdhci.yaml      | 57 +++++++++++++++++--
>  1 file changed, 51 insertions(+), 6 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/eswin,eic7700-eth.example.dtb: ethernet@50400000 (eswin,eic7700-qos-eth): eswin,hsp-sp-csr: [[4294967295, 256], [264, 280]] is too short
	from schema $id: http://devicetree.org/schemas/net/eswin,eic7700-eth.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/eswin,eic7700-eth.example.dtb: ethernet@50400000 (eswin,eic7700-qos-eth): Unevaluated properties are not allowed ('eswin,hsp-sp-csr' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/eswin,eic7700-eth.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251019115238.320-1-hehuan1@eswincomputing.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-10-20 11:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-19 11:51 [PATCH v5 0/2] Add support for Eswin EIC7700 SD/eMMC controller hehuan1
2025-10-19 11:52 ` [PATCH v5 1/2] dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700 hehuan1
2025-10-20 11:35   ` Rob Herring (Arm) [this message]
2025-10-24 13:57   ` Ulf Hansson
2025-10-24 16:37     ` Conor Dooley
2025-10-24 21:47       ` Conor Dooley
2025-10-24 22:22         ` Rob Herring
2025-10-19 11:53 ` [PATCH v5 2/2] mmc: sdhci-of-dwcmshc: Add support for " hehuan1
2025-10-23 11:08   ` Adrian Hunter
2025-10-24  3:19     ` 何欢
2025-10-24  6:36       ` Adrian Hunter
2025-11-07  9:03 ` [PATCH v5 0/2] Add support for Eswin EIC7700 SD/eMMC controller Huan He
2025-11-11 17:35 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176096011380.22917.1988679321096076522.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=caohang@eswincomputing.com \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dongxuyang@eswincomputing.com \
    --cc=hehuan1@eswincomputing.com \
    --cc=jszhang@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linmin@eswincomputing.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=lizhi2@eswincomputing.com \
    --cc=luyulin@eswincomputing.com \
    --cc=ningyu@eswincomputing.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pinkesh.vaghela@einfochips.com \
    --cc=ulf.hansson@linaro.org \
    --cc=weishangjuan@eswincomputing.com \
    --cc=xuxiang@eswincomputing.com \
    --cc=zhangsenchuan@eswincomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®