From: Adrian Hunter <adrian.hunter@intel.com>
To: 何欢 <hehuan1@eswincomputing.com>, ulf.hansson@linaro.org
Cc: <robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<jszhang@kernel.org>, <p.zabel@pengutronix.de>,
<linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <ningyu@eswincomputing.com>,
<linmin@eswincomputing.com>, <pinkesh.vaghela@einfochips.com>,
<xuxiang@eswincomputing.com>, <luyulin@eswincomputing.com>,
<dongxuyang@eswincomputing.com>,
<zhangsenchuan@eswincomputing.com>,
<weishangjuan@eswincomputing.com>, <lizhi2@eswincomputing.com>,
<caohang@eswincomputing.com>
Subject: Re: [PATCH v5 2/2] mmc: sdhci-of-dwcmshc: Add support for Eswin EIC7700
Date: Fri, 24 Oct 2025 09:36:30 +0300 [thread overview]
Message-ID: <add11b65-c525-4fb7-a70d-9a1f2e18272f@intel.com> (raw)
In-Reply-To: <4dddefe2.63d.19a143ad883.Coremail.hehuan1@eswincomputing.com>
On 24/10/2025 06:19, 何欢 wrote:
> Hi Adrian,
>
> Thank you very much for your Acked-by and the review!
>
>> On 19/10/2025 14:53, hehuan1@eswincomputing.com wrote:
>>> From: Huan He <hehuan1@eswincomputing.com>
>>>
>>> Add support for the mmc controller in the Eswin EIC7700 with the new
>>> compatible "eswin,eic7700-dwcmshc". Implement custom sdhci_ops for
>>> set_clock, reset, set_uhs_signaling, platform_execute_tuning.
>>>
>>> Signed-off-by: Huan He <hehuan1@eswincomputing.com>
>>
>> Noting that the dt-bindings patch still seems to have issues,
>> for this patch, anyway:
>>
>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> I recieved an dt_binding_check error report:
> https://lore.kernel.org/all/176096011380.22917.1988679321096076522.robh@kernel.org/
>
> It seems the error has nothing to do with MMC, but is related to the
> Ethernet binding (eswin,eic7700-eth.yaml), that was pushed by us and
> applied recently, link:
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=888bd0eca93c
>
> We're fixing this issue for the Ethernet. The Ethernet patch with
> this bug fix will be sent out later.
That seems OK, but it is up to Ulf now.
next prev parent reply other threads:[~2025-10-24 6:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-19 11:51 [PATCH v5 0/2] Add support for Eswin EIC7700 SD/eMMC controller hehuan1
2025-10-19 11:52 ` [PATCH v5 1/2] dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700 hehuan1
2025-10-20 11:35 ` Rob Herring (Arm)
2025-10-24 13:57 ` Ulf Hansson
2025-10-24 16:37 ` Conor Dooley
2025-10-24 21:47 ` Conor Dooley
2025-10-24 22:22 ` Rob Herring
2025-10-19 11:53 ` [PATCH v5 2/2] mmc: sdhci-of-dwcmshc: Add support for " hehuan1
2025-10-23 11:08 ` Adrian Hunter
2025-10-24 3:19 ` 何欢
2025-10-24 6:36 ` Adrian Hunter [this message]
2025-11-07 9:03 ` [PATCH v5 0/2] Add support for Eswin EIC7700 SD/eMMC controller Huan He
2025-11-11 17:35 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=add11b65-c525-4fb7-a70d-9a1f2e18272f@intel.com \
--to=adrian.hunter@intel.com \
--cc=caohang@eswincomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongxuyang@eswincomputing.com \
--cc=hehuan1@eswincomputing.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lizhi2@eswincomputing.com \
--cc=luyulin@eswincomputing.com \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pinkesh.vaghela@einfochips.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=weishangjuan@eswincomputing.com \
--cc=xuxiang@eswincomputing.com \
--cc=zhangsenchuan@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®