[PATCH] arm64: dts: qcom: sm8750-mtp: move PCIe GPIOs to pcieport0 node

[PATCH] arm64: dts: qcom: sm8750-mtp: move PCIe GPIOs to pcieport0 node

[Krishna Chaitanya Chundru]

Relocate the wake-gpios and perst-gpios properties from the pcie0
controller node to the pcieport0 node. These GPIOs are associated with
the PCIe root port and should reside under the pcieport0 node.

Also rename perst-gpios to reset-gpios to match the expected property name
in the PCIe port node.

Fixes: 141714e163bb ("arm64: dts: qcom: sm8750-mtp: Add WiFi and Bluetooth")
Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
index 3bbb53b7c71f3c03faee02fc282fbe4bba9b0a0f..45b5f758156700bf916c4122c93092c68488c1aa 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
@@ -960,9 +960,6 @@ &pon_resin {
 };
 
 &pcie0 {
-	wake-gpios = <&tlmm 104 GPIO_ACTIVE_HIGH>;
-	perst-gpios = <&tlmm 102 GPIO_ACTIVE_LOW>;
-
 	pinctrl-0 = <&pcie0_default_state>;
 	pinctrl-names = "default";
 
@@ -977,6 +974,9 @@ &pcie0_phy {
 };
 
 &pcieport0 {
+	wake-gpios = <&tlmm 104 GPIO_ACTIVE_HIGH>;
+	reset-gpios = <&tlmm 102 GPIO_ACTIVE_LOW>;
+
 	wifi@0 {
 		compatible = "pci17cb,1107";
 		reg = <0x10000 0x0 0x0 0x0 0x0>;

---
base-commit: 0b8b9fa6c35e090950da1d2fcf5ab29b74cead1d
change-id: 20251008-sm8750-c50b8421e801

Best regards,
-- 
Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>

Re: [PATCH] arm64: dts: qcom: sm8750-mtp: move PCIe GPIOs to pcieport0 node

[Krzysztof Kozlowski]

On 08/10/2025 13:38, Krishna Chaitanya Chundru wrote:
> Relocate the wake-gpios and perst-gpios properties from the pcie0
> controller node to the pcieport0 node. These GPIOs are associated with
> the PCIe root port and should reside under the pcieport0 node.
> 
> Also rename perst-gpios to reset-gpios to match the expected property name
> in the PCIe port node.
> 
> Fixes: 141714e163bb ("arm64: dts: qcom: sm8750-mtp: Add WiFi and Bluetooth")
> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

I wonder though, why the fallback method fails to work and device
stopped booting (see also Bjorn's report).

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: sm8750-mtp: move PCIe GPIOs to pcieport0 node

[Bjorn Andersson]

On Wed, 08 Oct 2025 10:08:55 +0530, Krishna Chaitanya Chundru wrote:
> Relocate the wake-gpios and perst-gpios properties from the pcie0
> controller node to the pcieport0 node. These GPIOs are associated with
> the PCIe root port and should reside under the pcieport0 node.
> 
> Also rename perst-gpios to reset-gpios to match the expected property name
> in the PCIe port node.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sm8750-mtp: move PCIe GPIOs to pcieport0 node
      commit: cc8056a16472d186140d1a66ed5648cee41f4379

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>