* [PATCH v3 0/3] Fixes/improvements for SM6350 UFS
@ 2025-10-23 11:39 Luca Weiss
2025-10-23 11:39 ` [PATCH v3 1/3] arm64: dts: qcom: sm6350: Fix wrong order of freq-table-hz for UFS Luca Weiss
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Luca Weiss @ 2025-10-23 11:39 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: ~postmarketos/upstreaming, phone-devel, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel, Luca Weiss, stable,
Dmitry Baryshkov, Konrad Dybcio
Fix the order of the freq-table-hz property, then convert to OPP tables
and add interconnect support for UFS for the SM6350 SoC.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v3:
- Actually pick up tags, sorry about that
- Link to v2: https://lore.kernel.org/r/20251023-sm6350-ufs-things-v2-0-799d59178713@fairphone.com
Changes in v2:
- Resend, pick up tags
- Link to v1: https://lore.kernel.org/r/20250314-sm6350-ufs-things-v1-0-3600362cc52c@fairphone.com
---
Luca Weiss (3):
arm64: dts: qcom: sm6350: Fix wrong order of freq-table-hz for UFS
arm64: dts: qcom: sm6350: Add OPP table support to UFSHC
arm64: dts: qcom: sm6350: Add interconnect support to UFS
arch/arm64/boot/dts/qcom/sm6350.dtsi | 49 ++++++++++++++++++++++++++++--------
1 file changed, 39 insertions(+), 10 deletions(-)
---
base-commit: a92c761bcac3d5042559107fa7679470727a4bcb
change-id: 20250314-sm6350-ufs-things-53c5de9fec5e
Best regards,
--
Luca Weiss <luca.weiss@fairphone.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/3] arm64: dts: qcom: sm6350: Fix wrong order of freq-table-hz for UFS
2025-10-23 11:39 [PATCH v3 0/3] Fixes/improvements for SM6350 UFS Luca Weiss
@ 2025-10-23 11:39 ` Luca Weiss
2025-10-23 11:39 ` [PATCH v3 2/3] arm64: dts: qcom: sm6350: Add OPP table support to UFSHC Luca Weiss
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Luca Weiss @ 2025-10-23 11:39 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: ~postmarketos/upstreaming, phone-devel, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel, Luca Weiss, stable,
Dmitry Baryshkov, Konrad Dybcio
During upstreaming the order of clocks was adjusted to match the
upstream sort order, but mistakently freq-table-hz wasn't re-ordered
with the new order.
Fix that by moving the entry for the ICE clk to the last place.
Fixes: 5a814af5fc22 ("arm64: dts: qcom: sm6350: Add UFS nodes")
Cc: stable@vger.kernel.org
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/sm6350.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
index 8459b27cacc7..19a7b9f9ea8b 100644
--- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
@@ -1180,11 +1180,11 @@ ufs_mem_hc: ufshc@1d84000 {
<0 0>,
<0 0>,
<37500000 150000000>,
- <75000000 300000000>,
<0 0>,
<0 0>,
<0 0>,
- <0 0>;
+ <0 0>,
+ <75000000 300000000>;
status = "disabled";
};
--
2.51.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 2/3] arm64: dts: qcom: sm6350: Add OPP table support to UFSHC
2025-10-23 11:39 [PATCH v3 0/3] Fixes/improvements for SM6350 UFS Luca Weiss
2025-10-23 11:39 ` [PATCH v3 1/3] arm64: dts: qcom: sm6350: Fix wrong order of freq-table-hz for UFS Luca Weiss
@ 2025-10-23 11:39 ` Luca Weiss
2025-10-23 11:39 ` [PATCH v3 3/3] arm64: dts: qcom: sm6350: Add interconnect support to UFS Luca Weiss
2025-10-27 22:37 ` [PATCH v3 0/3] Fixes/improvements for SM6350 UFS Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Luca Weiss @ 2025-10-23 11:39 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: ~postmarketos/upstreaming, phone-devel, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel, Luca Weiss,
Dmitry Baryshkov, Konrad Dybcio
UFS host controller, when scaling gears, should choose appropriate
performance state of RPMh power domain controller along with clock
frequency. So let's add the OPP table support to specify both clock
frequency and RPMh performance states replacing the old "freq-table-hz"
property.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/sm6350.dtsi | 42 +++++++++++++++++++++++++++---------
1 file changed, 32 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
index 19a7b9f9ea8b..30e77eca4c02 100644
--- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
@@ -1175,18 +1175,40 @@ ufs_mem_hc: ufshc@1d84000 {
<&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>,
<&gcc GCC_UFS_PHY_RX_SYMBOL_1_CLK>,
<&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
- freq-table-hz =
- <50000000 200000000>,
- <0 0>,
- <0 0>,
- <37500000 150000000>,
- <0 0>,
- <0 0>,
- <0 0>,
- <0 0>,
- <75000000 300000000>;
+
+ operating-points-v2 = <&ufs_opp_table>;
status = "disabled";
+
+ ufs_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-50000000 {
+ opp-hz = /bits/ 64 <50000000>,
+ /bits/ 64 <0>,
+ /bits/ 64 <0>,
+ /bits/ 64 <37500000>,
+ /bits/ 64 <0>,
+ /bits/ 64 <0>,
+ /bits/ 64 <0>,
+ /bits/ 64 <0>,
+ /bits/ 64 <75000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-200000000 {
+ opp-hz = /bits/ 64 <200000000>,
+ /bits/ 64 <0>,
+ /bits/ 64 <0>,
+ /bits/ 64 <150000000>,
+ /bits/ 64 <0>,
+ /bits/ 64 <0>,
+ /bits/ 64 <0>,
+ /bits/ 64 <0>,
+ /bits/ 64 <300000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+ };
};
ufs_mem_phy: phy@1d87000 {
--
2.51.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 3/3] arm64: dts: qcom: sm6350: Add interconnect support to UFS
2025-10-23 11:39 [PATCH v3 0/3] Fixes/improvements for SM6350 UFS Luca Weiss
2025-10-23 11:39 ` [PATCH v3 1/3] arm64: dts: qcom: sm6350: Fix wrong order of freq-table-hz for UFS Luca Weiss
2025-10-23 11:39 ` [PATCH v3 2/3] arm64: dts: qcom: sm6350: Add OPP table support to UFSHC Luca Weiss
@ 2025-10-23 11:39 ` Luca Weiss
2025-10-27 22:37 ` [PATCH v3 0/3] Fixes/improvements for SM6350 UFS Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Luca Weiss @ 2025-10-23 11:39 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: ~postmarketos/upstreaming, phone-devel, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel, Luca Weiss,
Dmitry Baryshkov, Konrad Dybcio
Define the two NoC paths used by UFS: ufs-ddr and cpu-ufs.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/sm6350.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
index 30e77eca4c02..01977d692755 100644
--- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
@@ -1178,6 +1178,13 @@ ufs_mem_hc: ufshc@1d84000 {
operating-points-v2 = <&ufs_opp_table>;
+ interconnects = <&aggre1_noc MASTER_UFS_MEM QCOM_ICC_TAG_ALWAYS
+ &clk_virt SLAVE_EBI_CH0 QCOM_ICC_TAG_ALWAYS>,
+ <&gem_noc MASTER_AMPSS_M0 QCOM_ICC_TAG_ACTIVE_ONLY
+ &config_noc SLAVE_UFS_MEM_CFG QCOM_ICC_TAG_ACTIVE_ONLY>;
+ interconnect-names = "ufs-ddr",
+ "cpu-ufs";
+
status = "disabled";
ufs_opp_table: opp-table {
--
2.51.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 0/3] Fixes/improvements for SM6350 UFS
2025-10-23 11:39 [PATCH v3 0/3] Fixes/improvements for SM6350 UFS Luca Weiss
` (2 preceding siblings ...)
2025-10-23 11:39 ` [PATCH v3 3/3] arm64: dts: qcom: sm6350: Add interconnect support to UFS Luca Weiss
@ 2025-10-27 22:37 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2025-10-27 22:37 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Luca Weiss
Cc: ~postmarketos/upstreaming, phone-devel, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel, stable,
Dmitry Baryshkov, Konrad Dybcio
On Thu, 23 Oct 2025 13:39:25 +0200, Luca Weiss wrote:
> Fix the order of the freq-table-hz property, then convert to OPP tables
> and add interconnect support for UFS for the SM6350 SoC.
>
>
Applied, thanks!
[1/3] arm64: dts: qcom: sm6350: Fix wrong order of freq-table-hz for UFS
commit: ec9d588391761a08aab5eb4523a48ef3df2c910f
[2/3] arm64: dts: qcom: sm6350: Add OPP table support to UFSHC
commit: 06d262bcdb3bc86805739de1c484761f0a59a453
[3/3] arm64: dts: qcom: sm6350: Add interconnect support to UFS
commit: c1a45887a36ef7ded3fb4bac59d4a3445098b04b
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-10-27 22:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-23 11:39 [PATCH v3 0/3] Fixes/improvements for SM6350 UFS Luca Weiss
2025-10-23 11:39 ` [PATCH v3 1/3] arm64: dts: qcom: sm6350: Fix wrong order of freq-table-hz for UFS Luca Weiss
2025-10-23 11:39 ` [PATCH v3 2/3] arm64: dts: qcom: sm6350: Add OPP table support to UFSHC Luca Weiss
2025-10-23 11:39 ` [PATCH v3 3/3] arm64: dts: qcom: sm6350: Add interconnect support to UFS Luca Weiss
2025-10-27 22:37 ` [PATCH v3 0/3] Fixes/improvements for SM6350 UFS Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®