* [PATCH net] dpll: zl3073x: Fix output pin registration
@ 2025-10-27 14:09 Ivan Vecera
2025-10-29 2:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Vecera @ 2025-10-27 14:09 UTC (permalink / raw)
To: netdev
Cc: Petr Oros, Prathosh Satish, Vadim Fedorenko,
Arkadiusz Kubalewski, Jiri Pirko, Jakub Kicinski, open list
Currently, the signal format of an associated output is not considered
during output pin registration. As a result, the driver registers output
pins that are disabled by the signal format configuration.
Fix this by calling zl3073x_output_pin_is_enabled() to check whether
a given output pin should be registered or not.
Fixes: 75a71ecc2412 ("dpll: zl3073x: Register DPLL devices and pins")
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
drivers/dpll/zl3073x/dpll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dpll/zl3073x/dpll.c b/drivers/dpll/zl3073x/dpll.c
index 93dc93eec79e..f93f9a458324 100644
--- a/drivers/dpll/zl3073x/dpll.c
+++ b/drivers/dpll/zl3073x/dpll.c
@@ -1904,7 +1904,7 @@ zl3073x_dpll_pin_is_registrable(struct zl3073x_dpll *zldpll,
}
is_diff = zl3073x_out_is_diff(zldev, out);
- is_enabled = zl3073x_out_is_enabled(zldev, out);
+ is_enabled = zl3073x_output_pin_is_enabled(zldev, index);
}
/* Skip N-pin if the corresponding input/output is differential */
--
2.51.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net] dpll: zl3073x: Fix output pin registration
2025-10-27 14:09 [PATCH net] dpll: zl3073x: Fix output pin registration Ivan Vecera
@ 2025-10-29 2:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-10-29 2:00 UTC (permalink / raw)
To: Ivan Vecera
Cc: netdev, poros, Prathosh.Satish, vadim.fedorenko,
arkadiusz.kubalewski, jiri, kuba, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 27 Oct 2025 15:09:12 +0100 you wrote:
> Currently, the signal format of an associated output is not considered
> during output pin registration. As a result, the driver registers output
> pins that are disabled by the signal format configuration.
>
> Fix this by calling zl3073x_output_pin_is_enabled() to check whether
> a given output pin should be registered or not.
>
> [...]
Here is the summary with links:
- [net] dpll: zl3073x: Fix output pin registration
https://git.kernel.org/netdev/net/c/40c17a02de41
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-29 2:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-27 14:09 [PATCH net] dpll: zl3073x: Fix output pin registration Ivan Vecera
2025-10-29 2:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®