[PATCH] net: atm: fix incorrect cleanup function call in error path

[PATCH] net: atm: fix incorrect cleanup function call in error path

[Sayooj K Karun]

In atm_init(), if atmsvc_init() fails, the code jumps to out_atmpvc_exit
label which incorrectly calls atmsvc_exit() instead of atmpvc_exit().
This results in calling the wrong cleanup function and failing to properly
clean up atmpvc_init().

Fix this by calling atmpvc_exit() in the out_atmpvc_exit error path.

Signed-off-by: Sayooj K Karun <sayooj@aerlync.com>
---
 net/atm/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/atm/common.c b/net/atm/common.c
index 881c7f259..c4edc1111 100644
--- a/net/atm/common.c
+++ b/net/atm/common.c
@@ -881,7 +881,7 @@ static int __init atm_init(void)
 out_atmsvc_exit:
 	atmsvc_exit();
 out_atmpvc_exit:
-	atmsvc_exit();
+	atmpvc_exit();
 out_unregister_vcc_proto:
 	proto_unregister(&vcc_proto);
 	goto out;
-- 
2.43.0

Re: [PATCH] net: atm: fix incorrect cleanup function call in error path

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 19 Nov 2025 14:27:47 +0530 you wrote:
> In atm_init(), if atmsvc_init() fails, the code jumps to out_atmpvc_exit
> label which incorrectly calls atmsvc_exit() instead of atmpvc_exit().
> This results in calling the wrong cleanup function and failing to properly
> clean up atmpvc_init().
> 
> Fix this by calling atmpvc_exit() in the out_atmpvc_exit error path.
> 
> [...]

Here is the summary with links:
  - net: atm: fix incorrect cleanup function call in error path
    https://git.kernel.org/netdev/net/c/4b4749b7b4b3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html