mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2/2] genirq: Remove cpumask availability check on kthread affinity setting
@ 2025-11-18 14:30 Frederic Weisbecker
  2025-11-18 15:26 ` [tip: irq/core] " tip-bot2 for Frederic Weisbecker
  0 siblings, 1 reply; 21+ messages in thread
From: Frederic Weisbecker @ 2025-11-18 14:30 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: LKML, Frederic Weisbecker, Marco Crivellari, Waiman Long, cgroups

Failing to allocate the affinity mask of an irqdesc eventually fails
the whole irqdesc initialization. It is then guaranteed that the cpumask
is always available whenever the related IRQ objects are alive, such as
the kthread handler.

Therefore remove the superfluous check since it is merely just a
historical leftover. Get rid also of the comments above it that are
either obsolete or useless.

Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
 kernel/irq/manage.c | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 76e2cbe21d1f..e9316cba311c 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1001,7 +1001,6 @@ static irqreturn_t irq_forced_secondary_handler(int irq, void *dev_id)
 static void irq_thread_check_affinity(struct irq_desc *desc, struct irqaction *action)
 {
 	cpumask_var_t mask;
-	bool valid = false;
 
 	if (!test_and_clear_bit(IRQTF_AFFINITY, &action->thread_flags))
 		return;
@@ -1018,21 +1017,13 @@ static void irq_thread_check_affinity(struct irq_desc *desc, struct irqaction *a
 	}
 
 	scoped_guard(raw_spinlock_irq, &desc->lock) {
-		/*
-		 * This code is triggered unconditionally. Check the affinity
-		 * mask pointer. For CPU_MASK_OFFSTACK=n this is optimized out.
-		 */
-		if (cpumask_available(desc->irq_common_data.affinity)) {
-			const struct cpumask *m;
+		const struct cpumask *m;
 
-			m = irq_data_get_effective_affinity_mask(&desc->irq_data);
-			cpumask_copy(mask, m);
-			valid = true;
-		}
+		m = irq_data_get_effective_affinity_mask(&desc->irq_data);
+		cpumask_copy(mask, m);
 	}
 
-	if (valid)
-		set_cpus_allowed_ptr(current, mask);
+	set_cpus_allowed_ptr(current, mask);
 	free_cpumask_var(mask);
 }
 
-- 
2.51.0


^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2025-12-18 10:07 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20251121143513eucas1p15c03a2c15aa5a0a15cc46d8f0a4e534e@eucas1p1.samsung.com>
2025-11-21 14:34 ` [PATCH 0/3 v3] genirq: Fix IRQ threads VS cpuset Frederic Weisbecker
2025-11-21 14:34   ` [PATCH 1/3 v3] genirq: Prevent from early irq thread spurious wake-ups Frederic Weisbecker
2025-11-21 19:12     ` Thomas Gleixner
2025-11-21 22:04       ` Frederic Weisbecker
2025-11-21 20:01     ` [tip: irq/core] genirq: Prevent early spurious wake-ups of interrupt threads tip-bot2 for Thomas Gleixner
2025-11-22  8:30     ` tip-bot2 for Frederic Weisbecker
2025-11-21 14:34   ` [PATCH 2/3 v3] genirq: Fix interrupt threads affinity vs. cpuset isolated partitions Frederic Weisbecker
2025-11-21 16:29     ` Waiman Long
2025-11-21 20:01     ` [tip: irq/core] " tip-bot2 for Frederic Weisbecker
2025-11-22  8:30     ` tip-bot2 for Frederic Weisbecker
2025-12-12  1:48     ` [PATCH 2/3 v3] " Chris Mason
2025-12-12  2:26       ` Thomas Gleixner
2025-12-12  4:01         ` [PATCH] genirq: Don't overwrite interrupt thread flags on setup Thomas Gleixner
2025-12-12 11:57           ` Frederic Weisbecker
2025-12-13  1:37           ` [tip: irq/urgent] " tip-bot2 for Thomas Gleixner
2025-12-18 10:07     ` [PATCH 2/3 v3] genirq: Fix interrupt threads affinity vs. cpuset isolated partitions Guenter Roeck
2025-11-21 14:35   ` [PATCH 3/3 v3] genirq: Remove cpumask availability check on kthread affinity setting Frederic Weisbecker
2025-11-21 20:01     ` [tip: irq/core] " tip-bot2 for Frederic Weisbecker
2025-11-22  8:30     ` tip-bot2 for Frederic Weisbecker
2025-11-21 20:05   ` [PATCH 0/3 v3] genirq: Fix IRQ threads VS cpuset Marek Szyprowski
2025-11-18 14:30 [PATCH 2/2] genirq: Remove cpumask availability check on kthread affinity setting Frederic Weisbecker
2025-11-18 15:26 ` [tip: irq/core] " tip-bot2 for Frederic Weisbecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®