From: "tip-bot2 for Alexandre Chartre" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Alexandre Chartre <alexandre.chartre@oracle.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: objtool/core] objtool: Provide access to feature and flags of group alternatives
Date: Mon, 24 Nov 2025 09:11:38 -0000 [thread overview]
Message-ID: <176397549865.498.7720547858368907601.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20251121095340.464045-26-alexandre.chartre@oracle.com>
The following commit has been merged into the objtool/core branch of tip:
Commit-ID: be5ee60ac554c6189cda963e886c4b97d2cb978c
Gitweb: https://git.kernel.org/tip/be5ee60ac554c6189cda963e886c4b97d2cb978c
Author: Alexandre Chartre <alexandre.chartre@oracle.com>
AuthorDate: Fri, 21 Nov 2025 10:53:35 +01:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Fri, 21 Nov 2025 15:30:14 +01:00
objtool: Provide access to feature and flags of group alternatives
Each alternative of a group alternative depends on a specific
feature and flags. Provide access to the feature/flags for each
alternative as an attribute (feature) in struct alt_group.
Signed-off-by: Alexandre Chartre <alexandre.chartre@oracle.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>
Link: https://patch.msgid.link/20251121095340.464045-26-alexandre.chartre@oracle.com
---
tools/objtool/check.c | 2 ++
tools/objtool/include/objtool/check.h | 1 +
tools/objtool/include/objtool/special.h | 2 +-
tools/objtool/special.c | 2 ++
4 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index f75364f..9ec0e07 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1751,6 +1751,7 @@ static int handle_group_alt(struct objtool_file *file,
orig_alt_group->last_insn = last_orig_insn;
orig_alt_group->nop = NULL;
orig_alt_group->ignore = orig_insn->ignore_alts;
+ orig_alt_group->feature = 0;
} else {
if (orig_alt_group->last_insn->offset + orig_alt_group->last_insn->len -
orig_alt_group->first_insn->offset != special_alt->orig_len) {
@@ -1855,6 +1856,7 @@ end:
new_alt_group->nop = nop;
new_alt_group->ignore = (*new_insn)->ignore_alts;
new_alt_group->cfi = orig_alt_group->cfi;
+ new_alt_group->feature = special_alt->feature;
return 0;
}
diff --git a/tools/objtool/include/objtool/check.h b/tools/objtool/include/objtool/check.h
index cbf4af5..2e1346a 100644
--- a/tools/objtool/include/objtool/check.h
+++ b/tools/objtool/include/objtool/check.h
@@ -36,6 +36,7 @@ struct alt_group {
struct cfi_state **cfi;
bool ignore;
+ unsigned int feature;
};
enum alternative_type {
diff --git a/tools/objtool/include/objtool/special.h b/tools/objtool/include/objtool/special.h
index 72d09c0..b224107 100644
--- a/tools/objtool/include/objtool/special.h
+++ b/tools/objtool/include/objtool/special.h
@@ -25,7 +25,7 @@ struct special_alt {
struct section *new_sec;
unsigned long new_off;
- unsigned int orig_len, new_len; /* group only */
+ unsigned int orig_len, new_len, feature; /* group only */
};
int special_get_alts(struct elf *elf, struct list_head *alts);
diff --git a/tools/objtool/special.c b/tools/objtool/special.c
index e262af9..2a533af 100644
--- a/tools/objtool/special.c
+++ b/tools/objtool/special.c
@@ -81,6 +81,8 @@ static int get_alt_entry(struct elf *elf, const struct special_entry *entry,
entry->orig_len);
alt->new_len = *(unsigned char *)(sec->data->d_buf + offset +
entry->new_len);
+ alt->feature = *(unsigned int *)(sec->data->d_buf + offset +
+ entry->feature);
}
orig_reloc = find_reloc_by_dest(elf, sec, offset + entry->orig);
next prev parent reply other threads:[~2025-11-24 9:11 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 9:53 [PATCH v6 00/30] objtool: Function validation tracing Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 01/30] objtool: Move disassembly functions to a separated file Alexandre Chartre
2025-11-24 9:12 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 02/30] objtool: Create disassembly context Alexandre Chartre
2025-11-24 9:12 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 03/30] objtool: Disassemble code with libopcodes instead of running objdump Alexandre Chartre
2025-11-24 9:12 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-25 18:16 ` [PATCH v6 03/30] " Nathan Chancellor
2025-11-26 9:00 ` Alexandre Chartre
2025-11-26 10:07 ` David Laight
2025-11-26 10:29 ` Alexandre Chartre
2025-12-09 6:58 ` Guenter Roeck
2025-12-09 7:51 ` Alexandre Chartre
2025-12-09 15:11 ` Guenter Roeck
2025-12-09 22:25 ` Maciej W. Rozycki
2025-12-10 5:08 ` Guenter Roeck
2025-12-10 7:53 ` Alexandre Chartre
2025-12-10 15:26 ` Guenter Roeck
2025-12-10 16:36 ` Alexandre Chartre
2025-12-10 18:42 ` Guenter Roeck
2025-12-10 21:54 ` Guenter Roeck
2025-12-15 16:00 ` Alexandre Chartre
2025-12-15 16:46 ` Guenter Roeck
2025-12-10 7:06 ` Alexandre Chartre
2025-12-10 8:56 ` Peter Zijlstra
2025-12-10 8:53 ` Peter Zijlstra
2025-12-10 12:01 ` Maciej W. Rozycki
2025-11-21 9:53 ` [PATCH v6 04/30] tool build: Remove annoying newline in build output Alexandre Chartre
2025-11-24 9:12 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 05/30] objtool: Print symbol during disassembly Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 06/30] objtool: Store instruction disassembly result Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 07/30] objtool: Disassemble instruction on warning or backtrace Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 08/30] objtool: Extract code to validate instruction from the validate branch loop Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 09/30] objtool: Record symbol name max length Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 10/30] objtool: Add option to trace function validation Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 11/30] objtool: Trace instruction state changes during " Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-12-01 20:23 ` [PATCH v6 11/30] " Nathan Chancellor
2025-12-02 1:30 ` Josh Poimboeuf
2025-12-02 8:34 ` Alexandre Chartre
2025-12-02 16:13 ` Josh Poimboeuf
2025-12-02 18:09 ` David Laight
2025-11-21 9:53 ` [PATCH v6 12/30] objtool: Improve register reporting " Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 13/30] objtool: Identify the different types of alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 14/30] objtool: Add functions to better name alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 15/30] objtool: Improve tracing of alternative instructions Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 16/30] objtool: Do not validate IBT for .return_sites and .call_sites Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 17/30] objtool: Add the --disas=<function-pattern> action Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 18/30] objtool: Preserve alternatives order Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 19/30] objtool: Print headers for alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 20/30] objtool: Disassemble group alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 21/30] objtool: Print addresses with alternative instructions Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 22/30] objtool: Disassemble exception table alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 23/30] objtool: Disassemble jump " Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 24/30] objtool: Fix address references in alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 25/30] objtool: Provide access to feature and flags of group alternatives Alexandre Chartre
2025-11-24 9:11 ` tip-bot2 for Alexandre Chartre [this message]
2025-11-21 9:53 ` [PATCH v6 26/30] objtool: Function to get the name of a CPU feature Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-24 10:44 ` tip-bot2 for Alexandre Chartre
2025-11-24 11:59 ` Peter Zijlstra
2025-11-24 12:26 ` Borislav Petkov
2025-11-24 12:40 ` Alexandre Chartre
2025-11-24 19:05 ` david laight
2025-11-24 16:43 ` Alexandre Chartre
2025-11-24 20:14 ` Borislav Petkov
2025-11-24 19:49 ` [tip: objtool/core] objtool: Add " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 27/30] objtool: Improve naming of group alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-24 10:44 ` tip-bot2 for Alexandre Chartre
2025-11-24 19:49 ` tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 28/30] objtool: Compact output for alternatives with one instruction Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-24 10:43 ` tip-bot2 for Alexandre Chartre
2025-11-24 19:49 ` tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 29/30] objtool: Add wide output for disassembly Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-24 10:43 ` tip-bot2 for Alexandre Chartre
2025-11-24 19:49 ` tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 30/30] objtool: Trim trailing NOPs in alternative Alexandre Chartre
2025-11-24 9:10 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-24 10:43 ` tip-bot2 for Alexandre Chartre
2025-11-24 19:49 ` tip-bot2 for Alexandre Chartre
2025-11-21 10:36 ` [PATCH v6 00/30] objtool: Function validation tracing Peter Zijlstra
2025-11-21 13:16 ` Alexandre Chartre
2025-11-21 13:51 ` Alexandre Chartre
2025-11-21 14:30 ` Peter Zijlstra
2025-11-24 11:04 ` Borislav Petkov
2025-11-24 11:39 ` Alexandre Chartre
2025-11-24 12:39 ` Borislav Petkov
2025-11-24 12:27 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176397549865.498.7720547858368907601.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=alexandre.chartre@oracle.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome