From: Alexandre Chartre <alexandre.chartre@oracle.com>
To: Borislav Petkov <bp@alien8.de>, Peter Zijlstra <peterz@infradead.org>
Cc: alexandre.chartre@oracle.com, linux-kernel@vger.kernel.org,
linux-tip-commits@vger.kernel.org,
Josh Poimboeuf <jpoimboe@kernel.org>,
x86@kernel.org
Subject: Re: [tip: objtool/core] objtool: Function to get the name of a CPU feature
Date: Mon, 24 Nov 2025 13:40:47 +0100 [thread overview]
Message-ID: <a8b6e603-e3c0-4bc3-b36b-29771d30183b@oracle.com> (raw)
In-Reply-To: <20251124122639.GBaSRO_-G9dUtVHMaY@fat_crate.local>
On 11/24/25 13:26, Borislav Petkov wrote:
> On Mon, Nov 24, 2025 at 12:59:42PM +0100, Peter Zijlstra wrote:
>> On Mon, Nov 24, 2025 at 10:44:01AM -0000, tip-bot2 for Alexandre Chartre wrote:
>>> The following commit has been merged into the objtool/core branch of tip:
>>>
>>> Commit-ID: afff4e5820e9a0d609740a83c366f3f0335db342
>>> Gitweb: https://git.kernel.org/tip/afff4e5820e9a0d609740a83c366f3f0335db342
>>> Author: Alexandre Chartre <alexandre.chartre@oracle.com>
>>> AuthorDate: Fri, 21 Nov 2025 10:53:36 +01:00
>>> Committer: Peter Zijlstra <peterz@infradead.org>
>>> CommitterDate: Mon, 24 Nov 2025 11:35:06 +01:00
>>>
>>> objtool: Function to get the name of a CPU feature
>
> Also, this commit name needs a verb.
>
>> Boris just reported that this doesn't work on mawk, since it uses a GNU
>> awk extension (3rd argument for match()).
>>
>> Could you please look at writing this in strict POSIX awk?
>
> The fail is:
>
> awk: ../arch/x86/tools/gen-cpu-feature-names-x86.awk: line 20: syntax error at or near ,
> awk: ../arch/x86/tools/gen-cpu-feature-names-x86.awk: line 23: syntax error at or near }
> awk: ../arch/x86/tools/gen-cpu-feature-names-x86.awk: line 26: syntax error at or near ,
> awk: ../arch/x86/tools/gen-cpu-feature-names-x86.awk: line 29: syntax error at or near }
> make[5]: *** [arch/x86/Build:21: /root/kernel/linux/tools/objtool/arch/x86/lib/cpu-feature-names.c] Error 2
> make[5]: *** Deleting file '/root/kernel/linux/tools/objtool/arch/x86/lib/cpu-feature-names.c'
> make[4]: *** [/root/kernel/linux/tools/build/Makefile.build:142: arch/x86] Error 2
> make[4]: *** Waiting for unfinished jobs....
> make[3]: *** [Makefile:104: /root/kernel/linux/tools/objtool/objtool-in.o] Error 2
> make[2]: *** [Makefile:73: objtool] Error 2
> make[1]: *** [/root/kernel/linux/Makefile:1449: tools/objtool] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
>
> ls -al /usr/bin/awk
> lrwxrwxrwx 1 root root 21 Feb 19 2021 /usr/bin/awk -> /etc/alternatives/awk
> ls -al /etc/alternatives/awk
> lrwxrwxrwx 1 root root 13 Feb 19 2021 /etc/alternatives/awk -> /usr/bin/mawk
>
> That's debian.
>
Ok. I am working on it.
alex.
next prev parent reply other threads:[~2025-11-24 12:41 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 9:53 [PATCH v6 00/30] objtool: Function validation tracing Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 01/30] objtool: Move disassembly functions to a separated file Alexandre Chartre
2025-11-24 9:12 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 02/30] objtool: Create disassembly context Alexandre Chartre
2025-11-24 9:12 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 03/30] objtool: Disassemble code with libopcodes instead of running objdump Alexandre Chartre
2025-11-24 9:12 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-25 18:16 ` [PATCH v6 03/30] " Nathan Chancellor
2025-11-26 9:00 ` Alexandre Chartre
2025-11-26 10:07 ` David Laight
2025-11-26 10:29 ` Alexandre Chartre
2025-12-09 6:58 ` Guenter Roeck
2025-12-09 7:51 ` Alexandre Chartre
2025-12-09 15:11 ` Guenter Roeck
2025-12-09 22:25 ` Maciej W. Rozycki
2025-12-10 5:08 ` Guenter Roeck
2025-12-10 7:53 ` Alexandre Chartre
2025-12-10 15:26 ` Guenter Roeck
2025-12-10 16:36 ` Alexandre Chartre
2025-12-10 18:42 ` Guenter Roeck
2025-12-10 21:54 ` Guenter Roeck
2025-12-15 16:00 ` Alexandre Chartre
2025-12-15 16:46 ` Guenter Roeck
2025-12-10 7:06 ` Alexandre Chartre
2025-12-10 8:56 ` Peter Zijlstra
2025-12-10 8:53 ` Peter Zijlstra
2025-12-10 12:01 ` Maciej W. Rozycki
2025-11-21 9:53 ` [PATCH v6 04/30] tool build: Remove annoying newline in build output Alexandre Chartre
2025-11-24 9:12 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 05/30] objtool: Print symbol during disassembly Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 06/30] objtool: Store instruction disassembly result Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 07/30] objtool: Disassemble instruction on warning or backtrace Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 08/30] objtool: Extract code to validate instruction from the validate branch loop Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 09/30] objtool: Record symbol name max length Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 10/30] objtool: Add option to trace function validation Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 11/30] objtool: Trace instruction state changes during " Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-12-01 20:23 ` [PATCH v6 11/30] " Nathan Chancellor
2025-12-02 1:30 ` Josh Poimboeuf
2025-12-02 8:34 ` Alexandre Chartre
2025-12-02 16:13 ` Josh Poimboeuf
2025-12-02 18:09 ` David Laight
2025-11-21 9:53 ` [PATCH v6 12/30] objtool: Improve register reporting " Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 13/30] objtool: Identify the different types of alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 14/30] objtool: Add functions to better name alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 15/30] objtool: Improve tracing of alternative instructions Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 16/30] objtool: Do not validate IBT for .return_sites and .call_sites Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 17/30] objtool: Add the --disas=<function-pattern> action Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 18/30] objtool: Preserve alternatives order Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 19/30] objtool: Print headers for alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 20/30] objtool: Disassemble group alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 21/30] objtool: Print addresses with alternative instructions Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 22/30] objtool: Disassemble exception table alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 23/30] objtool: Disassemble jump " Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 24/30] objtool: Fix address references in alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 25/30] objtool: Provide access to feature and flags of group alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 26/30] objtool: Function to get the name of a CPU feature Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-24 10:44 ` tip-bot2 for Alexandre Chartre
2025-11-24 11:59 ` Peter Zijlstra
2025-11-24 12:26 ` Borislav Petkov
2025-11-24 12:40 ` Alexandre Chartre [this message]
2025-11-24 19:05 ` david laight
2025-11-24 16:43 ` Alexandre Chartre
2025-11-24 20:14 ` Borislav Petkov
2025-11-24 19:49 ` [tip: objtool/core] objtool: Add " tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 27/30] objtool: Improve naming of group alternatives Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-24 10:44 ` tip-bot2 for Alexandre Chartre
2025-11-24 19:49 ` tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 28/30] objtool: Compact output for alternatives with one instruction Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-24 10:43 ` tip-bot2 for Alexandre Chartre
2025-11-24 19:49 ` tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 29/30] objtool: Add wide output for disassembly Alexandre Chartre
2025-11-24 9:11 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-24 10:43 ` tip-bot2 for Alexandre Chartre
2025-11-24 19:49 ` tip-bot2 for Alexandre Chartre
2025-11-21 9:53 ` [PATCH v6 30/30] objtool: Trim trailing NOPs in alternative Alexandre Chartre
2025-11-24 9:10 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2025-11-24 10:43 ` tip-bot2 for Alexandre Chartre
2025-11-24 19:49 ` tip-bot2 for Alexandre Chartre
2025-11-21 10:36 ` [PATCH v6 00/30] objtool: Function validation tracing Peter Zijlstra
2025-11-21 13:16 ` Alexandre Chartre
2025-11-21 13:51 ` Alexandre Chartre
2025-11-21 14:30 ` Peter Zijlstra
2025-11-24 11:04 ` Borislav Petkov
2025-11-24 11:39 ` Alexandre Chartre
2025-11-24 12:39 ` Borislav Petkov
2025-11-24 12:27 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8b6e603-e3c0-4bc3-b36b-29771d30183b@oracle.com \
--to=alexandre.chartre@oracle.com \
--cc=bp@alien8.de \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®