* [PATCH] ASoC: bcm: bcm63xx-pcm-whistler: Check return value of of_dma_configure()
@ 2025-12-02 10:16 Haotian Zhang
2025-12-03 14:54 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Haotian Zhang @ 2025-12-02 10:16 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: linux-sound, linux-kernel, Haotian Zhang
bcm63xx_soc_pcm_new() does not check the return value of
of_dma_configure(), which may fail with -EPROBE_DEFER or
other errors, allowing PCM setup to continue with incomplete
DMA configuration.
Add error checking for of_dma_configure() and return on failure.
Fixes: 88eb404ccc3e ("ASoC: brcm: Add DSL/PON SoC audio driver")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
sound/soc/bcm/bcm63xx-pcm-whistler.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/bcm/bcm63xx-pcm-whistler.c b/sound/soc/bcm/bcm63xx-pcm-whistler.c
index e3a4fcc63a56..efeb06ddabeb 100644
--- a/sound/soc/bcm/bcm63xx-pcm-whistler.c
+++ b/sound/soc/bcm/bcm63xx-pcm-whistler.c
@@ -358,7 +358,9 @@ static int bcm63xx_soc_pcm_new(struct snd_soc_component *component,
i2s_priv = dev_get_drvdata(snd_soc_rtd_to_cpu(rtd, 0)->dev);
- of_dma_configure(pcm->card->dev, pcm->card->dev->of_node, 1);
+ ret = of_dma_configure(pcm->card->dev, pcm->card->dev->of_node, 1);
+ if (ret)
+ return ret;
ret = dma_coerce_mask_and_coherent(pcm->card->dev, DMA_BIT_MASK(32));
if (ret)
--
2.50.1.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: bcm: bcm63xx-pcm-whistler: Check return value of of_dma_configure()
2025-12-02 10:16 [PATCH] ASoC: bcm: bcm63xx-pcm-whistler: Check return value of of_dma_configure() Haotian Zhang
@ 2025-12-03 14:54 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2025-12-03 14:54 UTC (permalink / raw)
To: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Haotian Zhang
Cc: linux-sound, linux-kernel
On Tue, 02 Dec 2025 18:16:42 +0800, Haotian Zhang wrote:
> bcm63xx_soc_pcm_new() does not check the return value of
> of_dma_configure(), which may fail with -EPROBE_DEFER or
> other errors, allowing PCM setup to continue with incomplete
> DMA configuration.
>
> Add error checking for of_dma_configure() and return on failure.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: bcm: bcm63xx-pcm-whistler: Check return value of of_dma_configure()
commit: 0ebbd45c33d0049ebf5a22c1434567f0c420b333
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-03 14:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-02 10:16 [PATCH] ASoC: bcm: bcm63xx-pcm-whistler: Check return value of of_dma_configure() Haotian Zhang
2025-12-03 14:54 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®