mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: martin.petersen@oracle.com, stefanha@redhat.com,
	 Deepanshu Kartikey <kartikey406@gmail.com>
Cc: hare@suse.de, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 syzbot+660d079d90f8a1baf54d@syzkaller.appspotmail.com
Subject: Re: [PATCH v3] block: add allocation size check in blkdev_pr_read_keys()
Date: Wed, 17 Dec 2025 07:36:14 -0700	[thread overview]
Message-ID: <176598217497.7122.17206763785166141358.b4-ty@kernel.dk> (raw)
In-Reply-To: <20251217014712.35771-1-kartikey406@gmail.com>


On Wed, 17 Dec 2025 07:17:12 +0530, Deepanshu Kartikey wrote:
> blkdev_pr_read_keys() takes num_keys from userspace and uses it to
> calculate the allocation size for keys_info via struct_size(). While
> there is a check for SIZE_MAX (integer overflow), there is no upper
> bound validation on the allocation size itself.
> 
> A malicious or buggy userspace can pass a large num_keys value that
> doesn't trigger overflow but still results in an excessive allocation
> attempt, causing a warning in the page allocator when the order exceeds
> MAX_PAGE_ORDER.
> 
> [...]

Applied, thanks!

[1/1] block: add allocation size check in blkdev_pr_read_keys()
      commit: a58383fa45c706bda3bf4a1955c3a0327dbec7e7

Best regards,
-- 
Jens Axboe




      parent reply	other threads:[~2025-12-17 14:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17  1:47 Deepanshu Kartikey
2025-12-17 14:05 ` Stefan Hajnoczi
2025-12-17 14:12 ` Martin K. Petersen
2025-12-17 14:36 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176598217497.7122.17206763785166141358.b4-ty@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=kartikey406@gmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stefanha@redhat.com \
    --cc=syzbot+660d079d90f8a1baf54d@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®