[PATCH] spi: mt65xx: Use IRQF_ONESHOT with threaded IRQ

[PATCH] spi: mt65xx: Use IRQF_ONESHOT with threaded IRQ

[Fei Shao]

This driver is migrated to use threaded IRQ since commit 5972eb05ca32
("spi: spi-mt65xx: Use threaded interrupt for non-SPIMEM transfer"), and
we almost always want to disable the interrupt line to avoid excess
interrupts while the threaded handler is processing SPI transfer.
Use IRQF_ONESHOT for that purpose.

In practice, we see MediaTek devices show SPI transfer timeout errors
when communicating with ChromeOS EC in certain scenarios, and with
IRQF_ONESHOT, the issue goes away.

Signed-off-by: Fei Shao <fshao@chromium.org>
---

 drivers/spi/spi-mt65xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
index 4b40985af1ea..90e5813cfdc3 100644
--- a/drivers/spi/spi-mt65xx.c
+++ b/drivers/spi/spi-mt65xx.c
@@ -1320,7 +1320,7 @@ static int mtk_spi_probe(struct platform_device *pdev)
 
 	ret = devm_request_threaded_irq(dev, irq, mtk_spi_interrupt,
 					mtk_spi_interrupt_thread,
-					IRQF_TRIGGER_NONE, dev_name(dev), host);
+					IRQF_ONESHOT, dev_name(dev), host);
 	if (ret)
 		return dev_err_probe(dev, ret, "failed to register irq\n");
 
-- 
2.52.0.305.g3fc767764a-goog

Re: [PATCH] spi: mt65xx: Use IRQF_ONESHOT with threaded IRQ

[Mark Brown]

On Wed, 17 Dec 2025 18:10:47 +0800, Fei Shao wrote:
> This driver is migrated to use threaded IRQ since commit 5972eb05ca32
> ("spi: spi-mt65xx: Use threaded interrupt for non-SPIMEM transfer"), and
> we almost always want to disable the interrupt line to avoid excess
> interrupts while the threaded handler is processing SPI transfer.
> Use IRQF_ONESHOT for that purpose.
> 
> In practice, we see MediaTek devices show SPI transfer timeout errors
> when communicating with ChromeOS EC in certain scenarios, and with
> IRQF_ONESHOT, the issue goes away.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: mt65xx: Use IRQF_ONESHOT with threaded IRQ
      commit: 8c04b77f87e6e321ae6acd28ce1de5553916153f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark