[PATCH] irqchip/riscv-intc: Fix missing .free callback for freeing local IRQs

[PATCH] irqchip/riscv-intc: Fix missing .free callback for freeing local IRQs

[Nick Hu]

The irq_domain_free_irqs() helper requires that the irq_domain_ops->free
callback be implemented. Otherwise, the kernel reports the warning
message "NULL pointer, cannot free irq" when the user calls
irq_dispose_mapping() to release the per-HART local IRQs.

Set the irq_domain_ops->free to irq_domain_free_irqs_top() to free the
IRQs.

Signed-off-by: Nick Hu <nick.hu@sifive.com>
---
 drivers/irqchip/irq-riscv-intc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-riscv-intc.c b/drivers/irqchip/irq-riscv-intc.c
index e5805885394ee3892a9a9784a937e234490ba0ea..70290b35b3173eb1fd5eb448f5432735210b5444 100644
--- a/drivers/irqchip/irq-riscv-intc.c
+++ b/drivers/irqchip/irq-riscv-intc.c
@@ -166,7 +166,8 @@ static int riscv_intc_domain_alloc(struct irq_domain *domain,
 static const struct irq_domain_ops riscv_intc_domain_ops = {
 	.map	= riscv_intc_domain_map,
 	.xlate	= irq_domain_xlate_onecell,
-	.alloc	= riscv_intc_domain_alloc
+	.alloc	= riscv_intc_domain_alloc,
+	.free	= irq_domain_free_irqs_top,
 };
 
 static struct fwnode_handle *riscv_intc_hwnode(void)

---
base-commit: 6da43bbeb6918164f7287269881a5f861ae09d7e
change-id: 20251114-rv-intc-fix-87f4a81a8133

Best regards,
-- 
Nick Hu <nick.hu@sifive.com>

[tip: irq/urgent] irqchip/riscv-intc: Add missing free() callback in riscv_intc_domain_ops

[tip-bot2 for Nick Hu]

The following commit has been merged into the irq/urgent branch of tip:

Commit-ID:     14473a1f88596fd729e892782efc267c0097dd1d
Gitweb:        https://git.kernel.org/tip/14473a1f88596fd729e892782efc267c0097dd1d
Author:        Nick Hu <nick.hu@sifive.com>
AuthorDate:    Fri, 14 Nov 2025 15:28:44 +08:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 14 Nov 2025 16:52:34 +01:00

irqchip/riscv-intc: Add missing free() callback in riscv_intc_domain_ops

The irq_domain_free_irqs() helper requires that the irq_domain_ops->free
callback is implemented. Otherwise, the kernel reports the warning message
"NULL pointer, cannot free irq" when irq_dispose_mapping() is invoked to
release the per-HART local interrupts.

Set irq_domain_ops->free to irq_domain_free_irqs_top() to cure that.

Fixes: 832f15f42646 ("RISC-V: Treat IPIs as normal Linux IRQs")
Signed-off-by: Nick Hu <nick.hu@sifive.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://patch.msgid.link/20251114-rv-intc-fix-v1-1-a3edd1c1a868@sifive.com
---
 drivers/irqchip/irq-riscv-intc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-riscv-intc.c b/drivers/irqchip/irq-riscv-intc.c
index e580588..70290b3 100644
--- a/drivers/irqchip/irq-riscv-intc.c
+++ b/drivers/irqchip/irq-riscv-intc.c
@@ -166,7 +166,8 @@ static int riscv_intc_domain_alloc(struct irq_domain *domain,
 static const struct irq_domain_ops riscv_intc_domain_ops = {
 	.map	= riscv_intc_domain_map,
 	.xlate	= irq_domain_xlate_onecell,
-	.alloc	= riscv_intc_domain_alloc
+	.alloc	= riscv_intc_domain_alloc,
+	.free	= irq_domain_free_irqs_top,
 };
 
 static struct fwnode_handle *riscv_intc_hwnode(void)

Re: [PATCH] irqchip/riscv-intc: Fix missing .free callback for freeing local IRQs

[patchwork-bot+linux-riscv]

Hello:

This patch was applied to riscv/linux.git (fixes)
by Thomas Gleixner <tglx@linutronix.de>:

On Fri, 14 Nov 2025 15:28:44 +0800 you wrote:
> The irq_domain_free_irqs() helper requires that the irq_domain_ops->free
> callback be implemented. Otherwise, the kernel reports the warning
> message "NULL pointer, cannot free irq" when the user calls
> irq_dispose_mapping() to release the per-HART local IRQs.
> 
> Set the irq_domain_ops->free to irq_domain_free_irqs_top() to free the
> IRQs.
> 
> [...]

Here is the summary with links:
  - irqchip/riscv-intc: Fix missing .free callback for freeing local IRQs
    https://git.kernel.org/riscv/c/14473a1f8859

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html