[PATCH] platform/x86: msi-laptop: add missing sysfs_remove_group()

[PATCH] platform/x86: msi-laptop: add missing sysfs_remove_group()

[Thomas Fourier]

A sysfs group is created in msi_init() when old_ec_model is enabled, but
never removed. Remove the msipf_old_attribute_group in that case.

Fixes: 03696e51d75a ("msi-laptop: Disable brightness control for new EC")
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
---
 drivers/platform/x86/msi-laptop.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
index c4b150fa093f..ddef6b78d2fa 100644
--- a/drivers/platform/x86/msi-laptop.c
+++ b/drivers/platform/x86/msi-laptop.c
@@ -1130,6 +1130,9 @@ static void __exit msi_cleanup(void)
 	sysfs_remove_group(&msipf_device->dev.kobj, &msipf_attribute_group);
 	if (!quirks->old_ec_model && threeg_exists)
 		device_remove_file(&msipf_device->dev, &dev_attr_threeg);
+	if (quirks->old_ec_model)
+		sysfs_remove_group(&msipf_device->dev.kobj,
+				   &msipf_old_attribute_group);
 	platform_device_unregister(msipf_device);
 	platform_driver_unregister(&msipf_driver);
 	backlight_device_unregister(msibl_device);
-- 
2.43.0

Re: [PATCH] platform/x86: msi-laptop: add missing sysfs_remove_group()

[Ilpo Järvinen]

On Wed, 17 Dec 2025 11:36:13 +0100, Thomas Fourier wrote:

> A sysfs group is created in msi_init() when old_ec_model is enabled, but
> never removed. Remove the msipf_old_attribute_group in that case.
> 
> 


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: msi-laptop: add missing sysfs_remove_group()
      commit: 1461209cf813b6ee6d40f29b96b544587df6d2b1

--
 i.