* [PATCH] phy: adjust function name reference
@ 2025-12-30 14:06 Julia Lawall
2025-12-30 16:56 ` Daniel Golle
2026-01-01 11:08 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2025-12-30 14:06 UTC (permalink / raw)
To: Daniel Golle
Cc: yunbolyu, kexinsun, ratnadiraw, xutong.ma, Qingfang Deng,
SkyLake Huang, Chunfeng Yun, Vinod Koul, Kishon Vijay Abraham I,
Matthias Brugger, AngeloGioacchino Del Regno, netdev,
linux-arm-kernel, linux-mediatek, linux-phy, linux-kernel
There is no function clk_bulk_prepare_disable. Refer instead to
clk_bulk_disable_unprepare, which is called in the function
defined just below.
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
drivers/phy/mediatek/phy-mtk-xfi-tphy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/mediatek/phy-mtk-xfi-tphy.c b/drivers/phy/mediatek/phy-mtk-xfi-tphy.c
index 1a0b7484f525..100a50d0e861 100644
--- a/drivers/phy/mediatek/phy-mtk-xfi-tphy.c
+++ b/drivers/phy/mediatek/phy-mtk-xfi-tphy.c
@@ -353,7 +353,7 @@ static int mtk_xfi_tphy_power_on(struct phy *phy)
* Disable and unprepare all clocks previously enabled.
*
* Return:
- * See clk_bulk_prepare_disable().
+ * See clk_bulk_disable_unprepare().
*/
static int mtk_xfi_tphy_power_off(struct phy *phy)
{
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: adjust function name reference
2025-12-30 14:06 [PATCH] phy: adjust function name reference Julia Lawall
@ 2025-12-30 16:56 ` Daniel Golle
2026-01-01 11:08 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Golle @ 2025-12-30 16:56 UTC (permalink / raw)
To: Julia Lawall
Cc: yunbolyu, kexinsun, ratnadiraw, xutong.ma, Qingfang Deng,
SkyLake Huang, Chunfeng Yun, Vinod Koul, Kishon Vijay Abraham I,
Matthias Brugger, AngeloGioacchino Del Regno, netdev,
linux-arm-kernel, linux-mediatek, linux-phy, linux-kernel
On Tue, Dec 30, 2025 at 03:06:01PM +0100, Julia Lawall wrote:
> There is no function clk_bulk_prepare_disable. Refer instead to
> clk_bulk_disable_unprepare, which is called in the function
> defined just below.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Thanks for spotting this obviously wrong comment!
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
>
> ---
> drivers/phy/mediatek/phy-mtk-xfi-tphy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-xfi-tphy.c b/drivers/phy/mediatek/phy-mtk-xfi-tphy.c
> index 1a0b7484f525..100a50d0e861 100644
> --- a/drivers/phy/mediatek/phy-mtk-xfi-tphy.c
> +++ b/drivers/phy/mediatek/phy-mtk-xfi-tphy.c
> @@ -353,7 +353,7 @@ static int mtk_xfi_tphy_power_on(struct phy *phy)
> * Disable and unprepare all clocks previously enabled.
> *
> * Return:
> - * See clk_bulk_prepare_disable().
> + * See clk_bulk_disable_unprepare().
> */
> static int mtk_xfi_tphy_power_off(struct phy *phy)
> {
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: adjust function name reference
2025-12-30 14:06 [PATCH] phy: adjust function name reference Julia Lawall
2025-12-30 16:56 ` Daniel Golle
@ 2026-01-01 11:08 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2026-01-01 11:08 UTC (permalink / raw)
To: Daniel Golle, Julia Lawall
Cc: yunbolyu, kexinsun, ratnadiraw, xutong.ma, Qingfang Deng,
SkyLake Huang, Chunfeng Yun, Kishon Vijay Abraham I,
Matthias Brugger, AngeloGioacchino Del Regno, netdev,
linux-arm-kernel, linux-mediatek, linux-phy, linux-kernel
On Tue, 30 Dec 2025 15:06:01 +0100, Julia Lawall wrote:
> There is no function clk_bulk_prepare_disable. Refer instead to
> clk_bulk_disable_unprepare, which is called in the function
> defined just below.
>
>
Applied, thanks!
[1/1] phy: adjust function name reference
commit: 6c1cdea6bafea96a818181e1289e22fbdc09f1d3
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-01 11:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-30 14:06 [PATCH] phy: adjust function name reference Julia Lawall
2025-12-30 16:56 ` Daniel Golle
2026-01-01 11:08 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®