[PATCH 01/25] dm: fix alloc_dev error path

[PATCH 01/25] dm: fix alloc_dev error path

[Alasdair G Kergon]

From: Ishai Rabinovitz <ishai@mellanox.co.il>

While reading the code I found a bug in the error path in alloc_dev in dm.c

When blk_alloc_queue fails there is no call to free_minor.

This patch fixes the problem.

Signed-off-by: Ishai Rabinovitz <ishai@mellanox.co.il>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>

Index: linux-2.6.18-rc7/drivers/md/dm.c
===================================================================
--- linux-2.6.18-rc7.orig/drivers/md/dm.c	2006-09-14 20:11:38.000000000 +0100
+++ linux-2.6.18-rc7/drivers/md/dm.c	2006-09-14 20:19:42.000000000 +0100
@@ -943,7 +943,7 @@ static struct mapped_device *alloc_dev(i
 
 	md->queue = blk_alloc_queue(GFP_KERNEL);
 	if (!md->queue)
-		goto bad1;
+		goto bad1_free_minor;
 
 	md->queue->queuedata = md;
 	md->queue->backing_dev_info.congested_fn = dm_any_congested;
@@ -993,6 +993,7 @@ static struct mapped_device *alloc_dev(i
 	mempool_destroy(md->io_pool);
  bad2:
 	blk_cleanup_queue(md->queue);
+ bad1_free_minor:
 	free_minor(minor);
  bad1:
 	module_put(THIS_MODULE);

Re: [PATCH 01/25] dm: fix alloc_dev error path

[John Stoffel]

So how come these patches aren't also posted to the linux-lvm mailing
list as well?  

John

Re: [PATCH 01/25] dm: fix alloc_dev error path

[Alasdair G Kergon]

On Fri, Sep 15, 2006 at 10:54:19AM -0400, John Stoffel wrote:
> So how come these patches aren't also posted to the linux-lvm mailing
> list as well?  
 
device-mapper patches are discussed on the dm-devel mailing list.

We have discussed the usage of the various mailing lists at the
device-mapper/lvm2 summit here in Germany this week and one decision 
was always to Cc:dm-devel on such patches at submission stage in
future.  (Usually they been on that list already, prior to submission.)

Alasdair
-- 
agk@redhat.com