[PATCH net] net: bnge: add AUXILIARY_BUS to Kconfig dependencies

[PATCH net] net: bnge: add AUXILIARY_BUS to Kconfig dependencies

[Markus Blöchl]

The build can currently fail with

    ld: drivers/net/ethernet/broadcom/bnge/bnge_auxr.o: in function `bnge_rdma_aux_device_add':
    bnge_auxr.c:(.text+0x366): undefined reference to `__auxiliary_device_add'
    ld: drivers/net/ethernet/broadcom/bnge/bnge_auxr.o: in function `bnge_rdma_aux_device_init':
    bnge_auxr.c:(.text+0x43c): undefined reference to `auxiliary_device_init'

if BNGE is enabled but no other driver pulls in AUXILIARY_BUS.

Select AUXILIARY_BUS in BNGE like in all other drivers which create
an auxiliary_device.

Fixes: 8ac050ec3b1c ("bng_en: Add RoCE aux device support")
Signed-off-by: Markus Blöchl <markus@blochl.de>
---
Basic steps to reproduce:
- make allnoconfig
- manually enable just PCI, NETDEVICES, ETHERNET, NET_VENDOR_BROADCOM and BNGE
- make
---
 drivers/net/ethernet/broadcom/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index ca565ace6e6a..cd7dddeb91dd 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -259,6 +259,7 @@ config BNGE
 	depends on PCI
 	select NET_DEVLINK
 	select PAGE_POOL
+	select AUXILIARY_BUS
 	help
 	  This driver supports Broadcom ThorUltra 50/100/200/400/800 gigabit
 	  Ethernet cards. The module will be called bng_en. To compile this

---
base-commit: 4d1442979e4a53b9457ce1e373e187e1511ff688
change-id: 20251228-bnge_aux_bus-4acb743203b5

Best regards,
-- 
Markus Blöchl <markus@blochl.de>


-- 

Re: [PATCH net] net: bnge: add AUXILIARY_BUS to Kconfig dependencies

[Vikas Gupta]

[-- Attachment #1: Type: text/plain, Size: 1814 bytes --]

On Sun, Dec 28, 2025 at 9:23 PM Markus Blöchl <markus@blochl.de> wrote:
>
> The build can currently fail with
>
>     ld: drivers/net/ethernet/broadcom/bnge/bnge_auxr.o: in function `bnge_rdma_aux_device_add':
>     bnge_auxr.c:(.text+0x366): undefined reference to `__auxiliary_device_add'
>     ld: drivers/net/ethernet/broadcom/bnge/bnge_auxr.o: in function `bnge_rdma_aux_device_init':
>     bnge_auxr.c:(.text+0x43c): undefined reference to `auxiliary_device_init'
>
> if BNGE is enabled but no other driver pulls in AUXILIARY_BUS.
>
> Select AUXILIARY_BUS in BNGE like in all other drivers which create
> an auxiliary_device.
>
> Fixes: 8ac050ec3b1c ("bng_en: Add RoCE aux device support")
> Signed-off-by: Markus Blöchl <markus@blochl.de>

Reviewed-by: Vikas Gupta <vikas.gupta@broadcom.com>

> ---
> Basic steps to reproduce:
> - make allnoconfig
> - manually enable just PCI, NETDEVICES, ETHERNET, NET_VENDOR_BROADCOM and BNGE
> - make
> ---
>  drivers/net/ethernet/broadcom/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
> index ca565ace6e6a..cd7dddeb91dd 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -259,6 +259,7 @@ config BNGE
>         depends on PCI
>         select NET_DEVLINK
>         select PAGE_POOL
> +       select AUXILIARY_BUS
>         help
>           This driver supports Broadcom ThorUltra 50/100/200/400/800 gigabit
>           Ethernet cards. The module will be called bng_en. To compile this
>
> ---
> base-commit: 4d1442979e4a53b9457ce1e373e187e1511ff688
> change-id: 20251228-bnge_aux_bus-4acb743203b5
>
> Best regards,
> --
> Markus Blöchl <markus@blochl.de>
>
>
> --

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5465 bytes --]

Re: [PATCH net] net: bnge: add AUXILIARY_BUS to Kconfig dependencies

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 28 Dec 2025 16:52:59 +0100 you wrote:
> The build can currently fail with
> 
>     ld: drivers/net/ethernet/broadcom/bnge/bnge_auxr.o: in function `bnge_rdma_aux_device_add':
>     bnge_auxr.c:(.text+0x366): undefined reference to `__auxiliary_device_add'
>     ld: drivers/net/ethernet/broadcom/bnge/bnge_auxr.o: in function `bnge_rdma_aux_device_init':
>     bnge_auxr.c:(.text+0x43c): undefined reference to `auxiliary_device_init'
> 
> [...]

Here is the summary with links:
  - [net] net: bnge: add AUXILIARY_BUS to Kconfig dependencies
    https://git.kernel.org/netdev/net/c/d7065436e8a0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html