* [PATCH v2] arm64: dts: qcom: lemans: add QCrypto node
@ 2025-12-24 10:20 Abhinaba Rakshit
2025-12-29 12:54 ` Konrad Dybcio
2026-01-05 19:16 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Abhinaba Rakshit @ 2025-12-24 10:20 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Dmitry Baryshkov,
Abhinaba Rakshit
Add Qualcomm Crypto Engine device node for LeMans platform.
QCE and Crypto DMA nodes patch was applied as part of the
commit 7ff3da43ef44 ("arm64: dts: qcom: sa8775p: add QCrypto nodes"),
however was partially reverted by commit 92979f12a201 ("arm64: dts: qcom:
sa8775p: Partially revert "arm64: dts: qcom: sa8775p: add QCrypto nodes"")
due to compatible-string being miss-matched against schema.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
---
QCE device node was reverted for LeMans platform as compatible-string
did not match with bindings schema.
This patch is intended in resubmitting the enablement of
QCE device node for LeMans platform with compatible-string
being aligned with qcom-qce.
Bindings and Crypto DMA nodes for the same platform is already
present in the tree.
---
Changes in v2:
- Update the commit message and cover-letter description.
- Set the interconnect tag to QCOM_ICC_TAG_ALWAYS instead of passing 0(no TAG).
- Link to v1: https://lore.kernel.org/r/20251223-enable-qualcomm-crypto-engine-for-lemans-v1-1-f2c8f8e4f3cd@oss.qualcomm.com
---
arch/arm64/boot/dts/qcom/lemans.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
index 0b154d57ba24e69a9d900f06bbb22baa2781cc3f..6751ed4ebb3c40ee2724fbc7efcec84a2a0fb1ad 100644
--- a/arch/arm64/boot/dts/qcom/lemans.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
@@ -2769,6 +2769,18 @@ cryptobam: dma-controller@1dc4000 {
<&apps_smmu 0x481 0x00>;
};
+ crypto: crypto@1dfa000 {
+ compatible = "qcom,sa8775p-qce", "qcom,sm8150-qce", "qcom,qce";
+ reg = <0x0 0x01dfa000 0x0 0x6000>;
+ dmas = <&cryptobam 4>, <&cryptobam 5>;
+ dma-names = "rx", "tx";
+ iommus = <&apps_smmu 0x480 0x0>,
+ <&apps_smmu 0x481 0x0>;
+ interconnects = <&aggre2_noc MASTER_CRYPTO_CORE0 QCOM_ICC_TAG_ALWAYS
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+ interconnect-names = "memory";
+ };
+
ctcu@4001000 {
compatible = "qcom,sa8775p-ctcu";
reg = <0x0 0x04001000 0x0 0x1000>;
---
base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
change-id: 20251222-enable-qualcomm-crypto-engine-for-lemans-4213e8b2354b
Best regards,
--
Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: lemans: add QCrypto node
2025-12-24 10:20 [PATCH v2] arm64: dts: qcom: lemans: add QCrypto node Abhinaba Rakshit
@ 2025-12-29 12:54 ` Konrad Dybcio
2026-01-05 19:16 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2025-12-29 12:54 UTC (permalink / raw)
To: Abhinaba Rakshit, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Dmitry Baryshkov
On 12/24/25 11:20 AM, Abhinaba Rakshit wrote:
> Add Qualcomm Crypto Engine device node for LeMans platform.
>
> QCE and Crypto DMA nodes patch was applied as part of the
> commit 7ff3da43ef44 ("arm64: dts: qcom: sa8775p: add QCrypto nodes"),
> however was partially reverted by commit 92979f12a201 ("arm64: dts: qcom:
> sa8775p: Partially revert "arm64: dts: qcom: sa8775p: add QCrypto nodes"")
> due to compatible-string being miss-matched against schema.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: lemans: add QCrypto node
2025-12-24 10:20 [PATCH v2] arm64: dts: qcom: lemans: add QCrypto node Abhinaba Rakshit
2025-12-29 12:54 ` Konrad Dybcio
@ 2026-01-05 19:16 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2026-01-05 19:16 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Abhinaba Rakshit
Cc: linux-arm-msm, devicetree, linux-kernel, Dmitry Baryshkov
On Wed, 24 Dec 2025 15:50:24 +0530, Abhinaba Rakshit wrote:
> Add Qualcomm Crypto Engine device node for LeMans platform.
>
> QCE and Crypto DMA nodes patch was applied as part of the
> commit 7ff3da43ef44 ("arm64: dts: qcom: sa8775p: add QCrypto nodes"),
> however was partially reverted by commit 92979f12a201 ("arm64: dts: qcom:
> sa8775p: Partially revert "arm64: dts: qcom: sa8775p: add QCrypto nodes"")
> due to compatible-string being miss-matched against schema.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: lemans: add QCrypto node
commit: 173c43d0e4a435a95568d6b912d0d45c37d6d75f
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-05 19:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-24 10:20 [PATCH v2] arm64: dts: qcom: lemans: add QCrypto node Abhinaba Rakshit
2025-12-29 12:54 ` Konrad Dybcio
2026-01-05 19:16 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®