mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net-next,v2] atm: idt77252: Use sb_pool_remove()
@ 2026-01-05 21:29 Thomas Fourier
  2026-01-07  2:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Fourier @ 2026-01-05 21:29 UTC (permalink / raw)
  Cc: Thomas Fourier, Chas Williams, linux-atm-general, netdev, linux-kernel

Replacing the manual pool remove with the dedicated function.  This is
safer and more consistent with the rest of the code[1].

[1]; https://lore.kernel.org/all/20250625094013.GL1562@horms.kernel.org/

Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
---
 drivers/atm/idt77252.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
index f2e91b7d79f0..888695ccc2a7 100644
--- a/drivers/atm/idt77252.c
+++ b/drivers/atm/idt77252.c
@@ -1844,7 +1844,6 @@ add_rx_skb(struct idt77252_dev *card, int queue,
 {
 	struct sk_buff *skb;
 	dma_addr_t paddr;
-	u32 handle;
 
 	while (count--) {
 		skb = dev_alloc_skb(size);
@@ -1876,8 +1875,7 @@ add_rx_skb(struct idt77252_dev *card, int queue,
 			 skb_end_pointer(skb) - skb->data, DMA_FROM_DEVICE);
 
 outpoolrm:
-	handle = IDT77252_PRV_POOL(skb);
-	card->sbpool[POOL_QUEUE(handle)].skb[POOL_INDEX(handle)] = NULL;
+	sb_pool_remove(card, skb);
 
 outfree:
 	dev_kfree_skb(skb);
-- 
2.43.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next,v2] atm: idt77252: Use sb_pool_remove()
  2026-01-05 21:29 [PATCH net-next,v2] atm: idt77252: Use sb_pool_remove() Thomas Fourier
@ 2026-01-07  2:10 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-01-07  2:10 UTC (permalink / raw)
  To: Thomas Fourier; +Cc: 3chas3, linux-atm-general, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  5 Jan 2026 22:29:15 +0100 you wrote:
> Replacing the manual pool remove with the dedicated function.  This is
> safer and more consistent with the rest of the code[1].
> 
> [1]; https://lore.kernel.org/all/20250625094013.GL1562@horms.kernel.org/
> 
> Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net-next,v2] atm: idt77252: Use sb_pool_remove()
    https://git.kernel.org/netdev/net-next/c/8e7148b56023

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-07  2:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-05 21:29 [PATCH net-next,v2] atm: idt77252: Use sb_pool_remove() Thomas Fourier
2026-01-07  2:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®