[PATCH] mfd: core: Improve compile coverage of mfd_match_of_node_to_dev()

[PATCH] mfd: core: Improve compile coverage of mfd_match_of_node_to_dev()

[Geert Uytterhoeven]

As of commit c7fe3bbfd622b5ee ('mfd: core: Use of_property_read_reg() to
parse "reg"'), all code in mfd_match_of_node_to_dev() compiles fine when
CONFIG_OF is disabled.  As the sole caller of this function is
protected by IS_ENABLED(CONFIG_OF), the #ifdef inside the function can
be removed to increase build coverage, without impacting code size.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/mfd/mfd-core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index 7d14a1e7631ee8d5..6925bedddc80bbb7 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -100,7 +100,6 @@ static int mfd_match_of_node_to_dev(struct platform_device *pdev,
 				    struct device_node *np,
 				    const struct mfd_cell *cell)
 {
-#if IS_ENABLED(CONFIG_OF)
 	struct mfd_of_node_entry *of_entry;
 	u64 of_node_addr;
 
@@ -133,7 +132,6 @@ static int mfd_match_of_node_to_dev(struct platform_device *pdev,
 
 	of_node_get(np);
 	device_set_node(&pdev->dev, of_fwnode_handle(np));
-#endif
 	return 0;
 }
 
-- 
2.43.0

Re: (subset) [PATCH] mfd: core: Improve compile coverage of mfd_match_of_node_to_dev()

[Lee Jones]

On Fri, 28 Nov 2025 10:11:27 +0100, Geert Uytterhoeven wrote:
> As of commit c7fe3bbfd622b5ee ('mfd: core: Use of_property_read_reg() to
> parse "reg"'), all code in mfd_match_of_node_to_dev() compiles fine when
> CONFIG_OF is disabled.  As the sole caller of this function is
> protected by IS_ENABLED(CONFIG_OF), the #ifdef inside the function can
> be removed to increase build coverage, without impacting code size.
> 
> 
> [...]

Applied, thanks!

[1/1] mfd: core: Improve compile coverage of mfd_match_of_node_to_dev()
      commit: d0e9990ba058b25a3d8cf31ab0bb25571515ed34

--
Lee Jones [李琼斯]