From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
To: "Kevin Xie" <kevin.xie@starfivetech.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Emil Renner Berthing" <emil.renner.berthing@canonical.com>,
"Heinrich Schuchardt" <heinrich.schuchardt@canonical.com>,
"E Shattow" <e@freeshell.de>,
"Hal Feng" <hal.feng@starfivetech.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND v1] PCI: starfive: Use regulator APIs instead of GPIO APIs to control the 3V3 power supply of PCIe slots
Date: Tue, 13 Jan 2026 19:43:34 +0530 [thread overview]
Message-ID: <176831361429.497576.11439063740783860965.b4-ty@kernel.org> (raw)
In-Reply-To: <20251218102149.28062-1-hal.feng@starfivetech.com>
On Thu, 18 Dec 2025 18:21:49 +0800, Hal Feng wrote:
> The "enable-gpio" property is obtained to control the 3V3 power supply
> of PCIe slots but it is not documented in the dt-bindings and using
> GPIO APIs is not a standard method to control PCIe slot power, so
> use "vpcie3v3-supply" property and regulator APIs to replace them.
>
> This change will break the DTs which add "enable-gpio" or "enable-gpios"
> property under the node with compatible "starfive,jh7110-pcie".
> Fortunately, there are no such DTs in the upstream mainline, so this
> change has no impact on the upstream mainline.
> If you have used "enable-gpio" or "enable-gpios" property in your
> downstream DTs, please update it with "vpcie3v3-supply" after applying
> this commit.
>
> [...]
Applied, thanks!
[1/1] PCI: starfive: Use regulator APIs instead of GPIO APIs to control the 3V3 power supply of PCIe slots
commit: 05a75df4182e301a1b0059606f77b65c74deaa9b
Best regards,
--
Manivannan Sadhasivam <mani@kernel.org>
prev parent reply other threads:[~2026-01-13 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 10:21 Hal Feng
2026-01-13 14:13 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176831361429.497576.11439063740783860965.b4-ty@kernel.org \
--to=manivannan.sadhasivam@oss.qualcomm.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=e@freeshell.de \
--cc=emil.renner.berthing@canonical.com \
--cc=hal.feng@starfivetech.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=kevin.xie@starfivetech.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®