* [PATCH] phy: socionext: usb2: Simplify with scoped for each OF child loop
@ 2026-01-02 12:48 Krzysztof Kozlowski
2026-01-05 15:31 ` Neil Armstrong
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-02 12:48 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Kunihiko Hayashi, Masami Hiramatsu,
linux-phy, linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
drivers/phy/socionext/phy-uniphier-usb2.c | 28 ++++++++---------------
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git a/drivers/phy/socionext/phy-uniphier-usb2.c b/drivers/phy/socionext/phy-uniphier-usb2.c
index 21c201717d95..c49d432e526b 100644
--- a/drivers/phy/socionext/phy-uniphier-usb2.c
+++ b/drivers/phy/socionext/phy-uniphier-usb2.c
@@ -106,7 +106,7 @@ static const struct phy_ops uniphier_u2phy_ops = {
static int uniphier_u2phy_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
- struct device_node *parent, *child;
+ struct device_node *parent;
struct uniphier_u2phy_priv *priv = NULL, *next = NULL;
struct phy_provider *phy_provider;
struct regmap *regmap;
@@ -129,34 +129,31 @@ static int uniphier_u2phy_probe(struct platform_device *pdev)
return PTR_ERR(regmap);
}
- for_each_child_of_node(dev->of_node, child) {
+ for_each_child_of_node_scoped(dev->of_node, child) {
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
- if (!priv) {
- ret = -ENOMEM;
- goto out_put_child;
- }
+ if (!priv)
+ return -ENOMEM;
+
priv->regmap = regmap;
priv->vbus = devm_regulator_get_optional(dev, "vbus");
if (IS_ERR(priv->vbus)) {
- if (PTR_ERR(priv->vbus) == -EPROBE_DEFER) {
- ret = PTR_ERR(priv->vbus);
- goto out_put_child;
- }
+ if (PTR_ERR(priv->vbus) == -EPROBE_DEFER)
+ return PTR_ERR(priv->vbus);
+
priv->vbus = NULL;
}
priv->phy = devm_phy_create(dev, child, &uniphier_u2phy_ops);
if (IS_ERR(priv->phy)) {
dev_err(dev, "Failed to create phy\n");
- ret = PTR_ERR(priv->phy);
- goto out_put_child;
+ return PTR_ERR(priv->phy);
}
ret = of_property_read_u32(child, "reg", &data_idx);
if (ret) {
dev_err(dev, "Failed to get reg property\n");
- goto out_put_child;
+ return ret;
}
if (data_idx < ndatas)
@@ -174,11 +171,6 @@ static int uniphier_u2phy_probe(struct platform_device *pdev)
phy_provider = devm_of_phy_provider_register(dev,
uniphier_u2phy_xlate);
return PTR_ERR_OR_ZERO(phy_provider);
-
-out_put_child:
- of_node_put(child);
-
- return ret;
}
static const struct uniphier_u2phy_soc_data uniphier_pro4_data[] = {
--
2.51.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: socionext: usb2: Simplify with scoped for each OF child loop
2026-01-02 12:48 [PATCH] phy: socionext: usb2: Simplify with scoped for each OF child loop Krzysztof Kozlowski
@ 2026-01-05 15:31 ` Neil Armstrong
2026-01-06 4:45 ` Kunihiko Hayashi
2026-01-14 16:51 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2026-01-05 15:31 UTC (permalink / raw)
To: Krzysztof Kozlowski, Vinod Koul, Kunihiko Hayashi,
Masami Hiramatsu, linux-phy, linux-arm-kernel, linux-kernel
On 1/2/26 13:48, Krzysztof Kozlowski wrote:
> Use scoped for-each loop when iterating over device nodes to make code a
> bit simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> drivers/phy/socionext/phy-uniphier-usb2.c | 28 ++++++++---------------
> 1 file changed, 10 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/phy/socionext/phy-uniphier-usb2.c b/drivers/phy/socionext/phy-uniphier-usb2.c
> index 21c201717d95..c49d432e526b 100644
> --- a/drivers/phy/socionext/phy-uniphier-usb2.c
> +++ b/drivers/phy/socionext/phy-uniphier-usb2.c
> @@ -106,7 +106,7 @@ static const struct phy_ops uniphier_u2phy_ops = {
> static int uniphier_u2phy_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct device_node *parent, *child;
> + struct device_node *parent;
> struct uniphier_u2phy_priv *priv = NULL, *next = NULL;
> struct phy_provider *phy_provider;
> struct regmap *regmap;
> @@ -129,34 +129,31 @@ static int uniphier_u2phy_probe(struct platform_device *pdev)
> return PTR_ERR(regmap);
> }
>
> - for_each_child_of_node(dev->of_node, child) {
> + for_each_child_of_node_scoped(dev->of_node, child) {
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> - if (!priv) {
> - ret = -ENOMEM;
> - goto out_put_child;
> - }
> + if (!priv)
> + return -ENOMEM;
> +
> priv->regmap = regmap;
>
> priv->vbus = devm_regulator_get_optional(dev, "vbus");
> if (IS_ERR(priv->vbus)) {
> - if (PTR_ERR(priv->vbus) == -EPROBE_DEFER) {
> - ret = PTR_ERR(priv->vbus);
> - goto out_put_child;
> - }
> + if (PTR_ERR(priv->vbus) == -EPROBE_DEFER)
> + return PTR_ERR(priv->vbus);
> +
> priv->vbus = NULL;
> }
>
> priv->phy = devm_phy_create(dev, child, &uniphier_u2phy_ops);
> if (IS_ERR(priv->phy)) {
> dev_err(dev, "Failed to create phy\n");
> - ret = PTR_ERR(priv->phy);
> - goto out_put_child;
> + return PTR_ERR(priv->phy);
> }
>
> ret = of_property_read_u32(child, "reg", &data_idx);
> if (ret) {
> dev_err(dev, "Failed to get reg property\n");
> - goto out_put_child;
> + return ret;
> }
>
> if (data_idx < ndatas)
> @@ -174,11 +171,6 @@ static int uniphier_u2phy_probe(struct platform_device *pdev)
> phy_provider = devm_of_phy_provider_register(dev,
> uniphier_u2phy_xlate);
> return PTR_ERR_OR_ZERO(phy_provider);
> -
> -out_put_child:
> - of_node_put(child);
> -
> - return ret;
> }
>
> static const struct uniphier_u2phy_soc_data uniphier_pro4_data[] = {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: socionext: usb2: Simplify with scoped for each OF child loop
2026-01-02 12:48 [PATCH] phy: socionext: usb2: Simplify with scoped for each OF child loop Krzysztof Kozlowski
2026-01-05 15:31 ` Neil Armstrong
@ 2026-01-06 4:45 ` Kunihiko Hayashi
2026-01-14 16:51 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Kunihiko Hayashi @ 2026-01-06 4:45 UTC (permalink / raw)
To: Krzysztof Kozlowski, Vinod Koul, Neil Armstrong, Masami Hiramatsu
Cc: linux-phy, linux-arm-kernel, linux-kernel
Hi Krzysztof,
On 2026/01/02 21:48, Krzysztof Kozlowski wrote:
> Use scoped for-each loop when iterating over device nodes to make code a
> bit simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> drivers/phy/socionext/phy-uniphier-usb2.c | 28 ++++++++---------------
> 1 file changed, 10 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/phy/socionext/phy-uniphier-usb2.c
> b/drivers/phy/socionext/phy-uniphier-usb2.c
> index 21c201717d95..c49d432e526b 100644
> --- a/drivers/phy/socionext/phy-uniphier-usb2.c
> +++ b/drivers/phy/socionext/phy-uniphier-usb2.c
> @@ -106,7 +106,7 @@ static const struct phy_ops uniphier_u2phy_ops = {
> static int uniphier_u2phy_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct device_node *parent, *child;
> + struct device_node *parent;
> struct uniphier_u2phy_priv *priv = NULL, *next = NULL;
> struct phy_provider *phy_provider;
> struct regmap *regmap;
> @@ -129,34 +129,31 @@ static int uniphier_u2phy_probe(struct
> platform_device *pdev)
> return PTR_ERR(regmap);
> }
>
> - for_each_child_of_node(dev->of_node, child) {
> + for_each_child_of_node_scoped(dev->of_node, child) {
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> - if (!priv) {
> - ret = -ENOMEM;
> - goto out_put_child;
> - }
> + if (!priv)
> + return -ENOMEM;
> +
> priv->regmap = regmap;
>
> priv->vbus = devm_regulator_get_optional(dev, "vbus");
> if (IS_ERR(priv->vbus)) {
> - if (PTR_ERR(priv->vbus) == -EPROBE_DEFER) {
> - ret = PTR_ERR(priv->vbus);
> - goto out_put_child;
> - }
> + if (PTR_ERR(priv->vbus) == -EPROBE_DEFER)
> + return PTR_ERR(priv->vbus);
> +
> priv->vbus = NULL;
> }
>
> priv->phy = devm_phy_create(dev, child,
> &uniphier_u2phy_ops);
> if (IS_ERR(priv->phy)) {
> dev_err(dev, "Failed to create phy\n");
> - ret = PTR_ERR(priv->phy);
> - goto out_put_child;
> + return PTR_ERR(priv->phy);
> }
>
> ret = of_property_read_u32(child, "reg", &data_idx);
> if (ret) {
> dev_err(dev, "Failed to get reg property\n");
> - goto out_put_child;
> + return ret;
> }
>
> if (data_idx < ndatas)
> @@ -174,11 +171,6 @@ static int uniphier_u2phy_probe(struct
> platform_device *pdev)
> phy_provider = devm_of_phy_provider_register(dev,
>
> uniphier_u2phy_xlate);
> return PTR_ERR_OR_ZERO(phy_provider);
> -
> -out_put_child:
> - of_node_put(child);
> -
> - return ret;
> }
>
> static const struct uniphier_u2phy_soc_data uniphier_pro4_data[] = {
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: socionext: usb2: Simplify with scoped for each OF child loop
2026-01-02 12:48 [PATCH] phy: socionext: usb2: Simplify with scoped for each OF child loop Krzysztof Kozlowski
2026-01-05 15:31 ` Neil Armstrong
2026-01-06 4:45 ` Kunihiko Hayashi
@ 2026-01-14 16:51 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2026-01-14 16:51 UTC (permalink / raw)
To: Neil Armstrong, Kunihiko Hayashi, Masami Hiramatsu, linux-phy,
linux-arm-kernel, linux-kernel, Krzysztof Kozlowski
On Fri, 02 Jan 2026 13:48:49 +0100, Krzysztof Kozlowski wrote:
> Use scoped for-each loop when iterating over device nodes to make code a
> bit simpler.
>
>
Applied, thanks!
[1/1] phy: socionext: usb2: Simplify with scoped for each OF child loop
commit: f16741314f68091a8edf116ad5c134a72ffab854
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-14 16:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-02 12:48 [PATCH] phy: socionext: usb2: Simplify with scoped for each OF child loop Krzysztof Kozlowski
2026-01-05 15:31 ` Neil Armstrong
2026-01-06 4:45 ` Kunihiko Hayashi
2026-01-14 16:51 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®