mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: "Vignesh Raghavendra" <vigneshr@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	devicetree@vger.kernel.org,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Théo Lebrun" <theo.lebrun@bootlin.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Benoît Monin" <benoit.monin@bootlin.com>,
	"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
	"Linus Walleij" <linus.walleij@linaro.org>
Subject: Re: [PATCH v3 1/4] of: reserved_mem: Fix placement of __free() annotation
Date: Tue, 20 Jan 2026 20:30:58 -0600	[thread overview]
Message-ID: <176896265605.1837058.2000534852582541394.robh@kernel.org> (raw)
In-Reply-To: <20260107-mtd-memregion-v3-1-f9fc9107b992@bootlin.com>


On Wed, 07 Jan 2026 14:04:52 +0100, Gregory CLEMENT wrote:
> The __free() annotation was incorrectly placed before the variable
> name instead of after it, which resulted in the following checkpatch
> errors:
> 
> ERROR: need consistent spacing around '*' (ctx:WxV)
> +       struct device_node __free(device_node) *target = of_parse_phandle(np, "memory-region", idx);
>                                                ^
> WARNING: function definition argument 'idx' should also have an identifier name
> +       struct device_node __free(device_node) *target = of_parse_phandle(np, "memory-region", idx);
> 
> As part of this cleanup, also remove the useless return statement
> flagged by checkpatch.
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
>  drivers/of/of_reserved_mem.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Applied, thanks!


  reply	other threads:[~2026-01-21  2:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07 13:04 [PATCH v3 0/4] MTD physmap: Adding reserved RAM support and fixing reserved_mem limitations Gregory CLEMENT
2026-01-07 13:04 ` [PATCH v3 1/4] of: reserved_mem: Fix placement of __free() annotation Gregory CLEMENT
2026-01-21  2:30   ` Rob Herring (Arm) [this message]
2026-01-07 13:04 ` [PATCH v3 2/4] of: reserved_mem: Support multiple 'reg' entries for memory-region Gregory CLEMENT
2026-01-08 20:17   ` kernel test robot
2026-01-09 16:12     ` Gregory CLEMENT
2026-01-08 23:06   ` kernel test robot
2026-01-13  2:59   ` kernel test robot
2026-01-13  3:41   ` kernel test robot
2026-01-14 22:31   ` Rob Herring
2026-01-07 13:04 ` [PATCH v3 3/4] dt-bindings: mtd: physmap: Allow using memory-region to access memory resources Gregory CLEMENT
2026-01-09  9:52   ` Linus Walleij
2026-01-07 13:04 ` [PATCH v3 4/4] mtd: physmap: Add support for RAM reserved memory regions Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176896265605.1837058.2000534852582541394.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=benoit.monin@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=theo.lebrun@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    --cc=vladimir.kondratiev@mobileye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®